[GitHub] maskit commented on issue #1225: Enable specification of TLS Protocol Versions and Cipher Suites

2018-02-13 Thread GitBox
maskit commented on issue #1225: Enable specification of TLS Protocol Versions and Cipher Suites URL: https://github.com/apache/incubator-pulsar/pull/1225#issuecomment-365254767 @jai1 You may want to read these. If I understand correctly, HTTP entrypoints, which use

[GitHub] zhaijack commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace

2018-02-13 Thread GitBox
zhaijack commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace URL: https://github.com/apache/incubator-pulsar/pull/1103#discussion_r167864929 ## File path:

[GitHub] zhaijack commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace

2018-02-13 Thread GitBox
zhaijack commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace URL: https://github.com/apache/incubator-pulsar/pull/1103#discussion_r167863222 ## File path:

[GitHub] zhaijack commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace

2018-02-13 Thread GitBox
zhaijack commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace URL: https://github.com/apache/incubator-pulsar/pull/1103#discussion_r167863222 ## File path:

[GitHub] zhaijack commented on a change in pull request #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic

2018-02-13 Thread GitBox
zhaijack commented on a change in pull request #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic URL: https://github.com/apache/incubator-pulsar/pull/1066#discussion_r167811273 ## File path:

[GitHub] ivankelly opened a new pull request #1231: Read from compacted topic ledger if available and enabled

2018-02-13 Thread GitBox
ivankelly opened a new pull request #1231: Read from compacted topic ledger if available and enabled URL: https://github.com/apache/incubator-pulsar/pull/1231 If a topic has been compacted and the client has enabled reads from compacted topics, try to read from the compacted ledger if

[GitHub] ivankelly commented on issue #1231: Read from compacted topic ledger if available and enabled

2018-02-13 Thread GitBox
ivankelly commented on issue #1231: Read from compacted topic ledger if available and enabled URL: https://github.com/apache/incubator-pulsar/pull/1231#issuecomment-365215391 @merlimat This is an automated message from the

[GitHub] ivankelly opened a new pull request #1230: ProxyForwardAuthDataTest shouldn't reuse pulsar client

2018-02-13 Thread GitBox
ivankelly opened a new pull request #1230: ProxyForwardAuthDataTest shouldn't reuse pulsar client URL: https://github.com/apache/incubator-pulsar/pull/1230 This test was flaking due to the pulsar client being reused. The test starts a proxy service, subscribes to a topic, stops the

[GitHub] ivankelly commented on issue #1230: ProxyForwardAuthDataTest shouldn't reuse pulsar client

2018-02-13 Thread GitBox
ivankelly commented on issue #1230: ProxyForwardAuthDataTest shouldn't reuse pulsar client URL: https://github.com/apache/incubator-pulsar/pull/1230#issuecomment-365204264 This patch addresses #1211 This is an automated

[GitHub] ivankelly commented on issue #1230: ProxyForwardAuthDataTest shouldn't reuse pulsar client

2018-02-13 Thread GitBox
ivankelly commented on issue #1230: ProxyForwardAuthDataTest shouldn't reuse pulsar client URL: https://github.com/apache/incubator-pulsar/pull/1230#issuecomment-365205415 @jai1 @merlimat @mgodave This is an automated

svn commit: r25025 - /dev/incubator/pulsar/pulsar-1.22.0-incubating-candidate-0/

2018-02-13 Thread jai1
Author: jai1 Date: Tue Feb 13 09:59:07 2018 New Revision: 25025 Log: Staging artifacts and signature for Pulsar release 1.22.0-incubating Added: dev/incubator/pulsar/pulsar-1.22.0-incubating-candidate-0/

[GitHub] zhaijack commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace

2018-02-13 Thread GitBox
zhaijack commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace URL: https://github.com/apache/incubator-pulsar/pull/1103#discussion_r167813669 ## File path:

[GitHub] sijie commented on a change in pull request #1156: Introduce ActiveConsumerListener for realizing if a consumer is active in a failover subscription group

2018-02-13 Thread GitBox
sijie commented on a change in pull request #1156: Introduce ActiveConsumerListener for realizing if a consumer is active in a failover subscription group URL: https://github.com/apache/incubator-pulsar/pull/1156#discussion_r167913386 ## File path:

[GitHub] zhaijack commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace

2018-02-13 Thread GitBox
zhaijack commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace URL: https://github.com/apache/incubator-pulsar/pull/1103#discussion_r167879404 ## File path:

[GitHub] sijie commented on issue #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic

2018-02-13 Thread GitBox
sijie commented on issue #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic URL: https://github.com/apache/incubator-pulsar/pull/1066#issuecomment-365286252 @zhaijack : can you address @merlimat and @ivankelly 's comments? we need this change for function

[GitHub] zhaijack commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace

2018-02-13 Thread GitBox
zhaijack commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace URL: https://github.com/apache/incubator-pulsar/pull/1103#discussion_r167907583 ## File path:

[GitHub] sijie commented on a change in pull request #1156: Introduce ActiveConsumerListener for realizing if a consumer is active in a failover subscription group

2018-02-13 Thread GitBox
sijie commented on a change in pull request #1156: Introduce ActiveConsumerListener for realizing if a consumer is active in a failover subscription group URL: https://github.com/apache/incubator-pulsar/pull/1156#discussion_r167911055 ## File path:

[GitHub] zhaijack commented on issue #1059: Issue 1014: Rename "global zookeeper" to "configuration-store"(change in code, conf and cli)

2018-02-13 Thread GitBox
zhaijack commented on issue #1059: Issue 1014: Rename "global zookeeper" to "configuration-store"(change in code, conf and cli) URL: https://github.com/apache/incubator-pulsar/pull/1059#issuecomment-365298276 retest this please

[GitHub] zhaijack commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace

2018-02-13 Thread GitBox
zhaijack commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace URL: https://github.com/apache/incubator-pulsar/pull/1103#discussion_r167911587 ## File path:

[GitHub] zhaijack commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace

2018-02-13 Thread GitBox
zhaijack commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace URL: https://github.com/apache/incubator-pulsar/pull/1103#discussion_r167864929 ## File path:

[GitHub] zhaijack commented on issue #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic

2018-02-13 Thread GitBox
zhaijack commented on issue #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic URL: https://github.com/apache/incubator-pulsar/pull/1066#issuecomment-365287664 Thanks, have resolved all the comments, and fixed rebase conflict.

[GitHub] zhaijack commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace

2018-02-13 Thread GitBox
zhaijack commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace URL: https://github.com/apache/incubator-pulsar/pull/1103#discussion_r167906488 ## File path:

[GitHub] sijie commented on a change in pull request #1156: Introduce ActiveConsumerListener for realizing if a consumer is active in a failover subscription group

2018-02-13 Thread GitBox
sijie commented on a change in pull request #1156: Introduce ActiveConsumerListener for realizing if a consumer is active in a failover subscription group URL: https://github.com/apache/incubator-pulsar/pull/1156#discussion_r167909684 ## File path:

[GitHub] zhaijack commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace

2018-02-13 Thread GitBox
zhaijack commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace URL: https://github.com/apache/incubator-pulsar/pull/1103#discussion_r167915637 ## File path:

[GitHub] zhaijack commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace

2018-02-13 Thread GitBox
zhaijack commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace URL: https://github.com/apache/incubator-pulsar/pull/1103#discussion_r167915413 ## File path:

[GitHub] zhaijack commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace

2018-02-13 Thread GitBox
zhaijack commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace URL: https://github.com/apache/incubator-pulsar/pull/1103#discussion_r167915437 ## File path:

[GitHub] zhaijack commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace

2018-02-13 Thread GitBox
zhaijack commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace URL: https://github.com/apache/incubator-pulsar/pull/1103#discussion_r167252486 ## File path:

[GitHub] zhaijack commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace

2018-02-13 Thread GitBox
zhaijack commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace URL: https://github.com/apache/incubator-pulsar/pull/1103#discussion_r167877509 ## File path:

[GitHub] sijie commented on issue #1223: Add a `backend` admin restful endpoint for query backend information

2018-02-13 Thread GitBox
sijie commented on issue #1223: Add a `backend` admin restful endpoint for query backend information URL: https://github.com/apache/incubator-pulsar/pull/1223#issuecomment-365307868 @yush1ga @rdhabalia the combination of zkservers and ledgersrootpath is actually the "bookkeeper service

[GitHub] zhaijack commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace

2018-02-13 Thread GitBox
zhaijack commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace URL: https://github.com/apache/incubator-pulsar/pull/1103#discussion_r167914612 ## File path:

[GitHub] zhaijack commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace

2018-02-13 Thread GitBox
zhaijack commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace URL: https://github.com/apache/incubator-pulsar/pull/1103#discussion_r167914515 ## File path:

[GitHub] mgodave commented on issue #1230: ProxyForwardAuthDataTest shouldn't reuse pulsar client

2018-02-13 Thread GitBox
mgodave commented on issue #1230: ProxyForwardAuthDataTest shouldn't reuse pulsar client URL: https://github.com/apache/incubator-pulsar/pull/1230#issuecomment-365314914 Looks good to me, someone with permissions will have to review it though.

[GitHub] sijie commented on issue #1156: Introduce ActiveConsumerListener for realizing if a consumer is active in a failover subscription group

2018-02-13 Thread GitBox
sijie commented on issue #1156: Introduce ActiveConsumerListener for realizing if a consumer is active in a failover subscription group URL: https://github.com/apache/incubator-pulsar/pull/1156#issuecomment-365325159 @merlimat I have addressed your comments, please take another round of

[incubator-pulsar] branch master updated: ProxyForwardAuthDataTest shouldn't reuse pulsar client (#1230)

2018-02-13 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 56ebe36 ProxyForwardAuthDataTest

[GitHub] merlimat closed pull request #1230: ProxyForwardAuthDataTest shouldn't reuse pulsar client

2018-02-13 Thread GitBox
merlimat closed pull request #1230: ProxyForwardAuthDataTest shouldn't reuse pulsar client URL: https://github.com/apache/incubator-pulsar/pull/1230 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] merlimat commented on a change in pull request #1232: Schema registry (1/4)

2018-02-13 Thread GitBox
merlimat commented on a change in pull request #1232: Schema registry (1/4) URL: https://github.com/apache/incubator-pulsar/pull/1232#discussion_r167958385 ## File path: pulsar-common/src/main/proto/PulsarApi.proto ## @@ -22,6 +22,20 @@ package pulsar.proto; option

[GitHub] merlimat commented on a change in pull request #1232: Schema registry (1/4)

2018-02-13 Thread GitBox
merlimat commented on a change in pull request #1232: Schema registry (1/4) URL: https://github.com/apache/incubator-pulsar/pull/1232#discussion_r167959766 ## File path: pulsar-common/src/main/proto/PulsarApi.proto ## @@ -22,6 +22,20 @@ package pulsar.proto; option

[GitHub] merlimat commented on a change in pull request #1232: Schema registry (1/4)

2018-02-13 Thread GitBox
merlimat commented on a change in pull request #1232: Schema registry (1/4) URL: https://github.com/apache/incubator-pulsar/pull/1232#discussion_r167959515 ## File path: pulsar-common/src/main/proto/PulsarApi.proto ## @@ -272,6 +289,8 @@ message CommandProducer {

[GitHub] mgodave opened a new pull request #1232: Schema registry (1/4)

2018-02-13 Thread GitBox
mgodave opened a new pull request #1232: Schema registry (1/4) URL: https://github.com/apache/incubator-pulsar/pull/1232 See #1137 for reference This is an automated message from the Apache Git Service. To respond to the

[GitHub] mgodave commented on a change in pull request #1232: Schema registry (1/4)

2018-02-13 Thread GitBox
mgodave commented on a change in pull request #1232: Schema registry (1/4) URL: https://github.com/apache/incubator-pulsar/pull/1232#discussion_r167994769 ## File path: pulsar-common/src/main/proto/PulsarApi.proto ## @@ -22,6 +22,20 @@ package pulsar.proto; option

[GitHub] ivankelly commented on issue #1231: Read from compacted topic ledger if available and enabled

2018-02-13 Thread GitBox
ivankelly commented on issue #1231: Read from compacted topic ledger if available and enabled URL: https://github.com/apache/incubator-pulsar/pull/1231#issuecomment-365368533 I need to fixup tests on this, I think some mocks are missing implementations

[incubator-pulsar] branch master updated: Bumped master to 2.0.0-incubating-SNAPSHOT (#1226)

2018-02-13 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new e77faf4 Bumped master to

[GitHub] merlimat closed pull request #1226: Bumped master to 2.0.0-incubating-SNAPSHOT

2018-02-13 Thread GitBox
merlimat closed pull request #1226: Bumped master to 2.0.0-incubating-SNAPSHOT URL: https://github.com/apache/incubator-pulsar/pull/1226 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] mgodave commented on a change in pull request #1232: Schema registry (1/4)

2018-02-13 Thread GitBox
mgodave commented on a change in pull request #1232: Schema registry (1/4) URL: https://github.com/apache/incubator-pulsar/pull/1232#discussion_r167996154 ## File path: pulsar-common/src/main/proto/PulsarApi.proto ## @@ -22,6 +22,20 @@ package pulsar.proto; option

[GitHub] mgodave commented on a change in pull request #1232: Schema registry (1/4)

2018-02-13 Thread GitBox
mgodave commented on a change in pull request #1232: Schema registry (1/4) URL: https://github.com/apache/incubator-pulsar/pull/1232#discussion_r167996411 ## File path: pulsar-common/src/main/proto/PulsarApi.proto ## @@ -272,6 +289,8 @@ message CommandProducer { ///

[GitHub] merlimat commented on a change in pull request #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic

2018-02-13 Thread GitBox
merlimat commented on a change in pull request #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic URL: https://github.com/apache/incubator-pulsar/pull/1066#discussion_r168006084 ## File path:

[GitHub] merlimat commented on a change in pull request #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic

2018-02-13 Thread GitBox
merlimat commented on a change in pull request #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic URL: https://github.com/apache/incubator-pulsar/pull/1066#discussion_r168005589 ## File path:

[GitHub] rdhabalia commented on issue #1223: Add a `backend` admin restful endpoint for query backend information

2018-02-13 Thread GitBox
rdhabalia commented on issue #1223: Add a `backend` admin restful endpoint for query backend information URL: https://github.com/apache/incubator-pulsar/pull/1223#issuecomment-365474351 > the purpose of this PR is to provide a method for application to know which zk, bk that a pulsar

[GitHub] sijie commented on issue #1223: Add a `backend` admin restful endpoint for query backend information

2018-02-13 Thread GitBox
sijie commented on issue #1223: Add a `backend` admin restful endpoint for query backend information URL: https://github.com/apache/incubator-pulsar/pull/1223#issuecomment-365475832 Okay will change it to InternalConfiguration

[GitHub] saandrews opened a new pull request #1233: Added debug logs in MessageCrypto

2018-02-13 Thread GitBox
saandrews opened a new pull request #1233: Added debug logs in MessageCrypto URL: https://github.com/apache/incubator-pulsar/pull/1233 Added additional logging to help debugging. This is an automated message from the Apache

[GitHub] hrsakai opened a new pull request #1234: Make max clients per topic/subscription configurable

2018-02-13 Thread GitBox
hrsakai opened a new pull request #1234: Make max clients per topic/subscription configurable URL: https://github.com/apache/incubator-pulsar/pull/1234 ### Motivation Currently, max clients is not limited by broker. Therefore, if client implementation is incorrect, clients may grow

[GitHub] zhaijack commented on a change in pull request #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic

2018-02-13 Thread GitBox
zhaijack commented on a change in pull request #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic URL: https://github.com/apache/incubator-pulsar/pull/1066#discussion_r168036825 ## File path:

[GitHub] rdhabalia opened a new pull request #1235: Add non-persistent topic stats separately in brokers-stat

2018-02-13 Thread GitBox
rdhabalia opened a new pull request #1235: Add non-persistent topic stats separately in brokers-stat URL: https://github.com/apache/incubator-pulsar/pull/1235 ### Motivation Right now, broker-stats gives persistent/non-persistent topic-stats under the `persistent` topic section. We

[GitHub] zhaijack commented on a change in pull request #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic

2018-02-13 Thread GitBox
zhaijack commented on a change in pull request #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic URL: https://github.com/apache/incubator-pulsar/pull/1066#discussion_r168061308 ## File path:

[GitHub] merlimat commented on a change in pull request #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic

2018-02-13 Thread GitBox
merlimat commented on a change in pull request #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic URL: https://github.com/apache/incubator-pulsar/pull/1066#discussion_r168054738 ## File path:

[GitHub] merlimat commented on a change in pull request #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic

2018-02-13 Thread GitBox
merlimat commented on a change in pull request #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic URL: https://github.com/apache/incubator-pulsar/pull/1066#discussion_r168054861 ## File path:

[GitHub] merlimat commented on a change in pull request #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic

2018-02-13 Thread GitBox
merlimat commented on a change in pull request #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic URL: https://github.com/apache/incubator-pulsar/pull/1066#discussion_r168059642 ## File path:

[incubator-pulsar] branch master updated: Added debug logs in MessageCrypto (#1233)

2018-02-13 Thread rdhabalia
This is an automated email from the ASF dual-hosted git repository. rdhabalia pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new fbb42e7 Added debug logs in

[GitHub] rdhabalia closed pull request #1233: Added debug logs in MessageCrypto

2018-02-13 Thread GitBox
rdhabalia closed pull request #1233: Added debug logs in MessageCrypto URL: https://github.com/apache/incubator-pulsar/pull/1233 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] merlimat commented on a change in pull request #1156: Introduce ActiveConsumerListener for realizing if a consumer is active in a failover subscription group

2018-02-13 Thread GitBox
merlimat commented on a change in pull request #1156: Introduce ActiveConsumerListener for realizing if a consumer is active in a failover subscription group URL: https://github.com/apache/incubator-pulsar/pull/1156#discussion_r168085822 ## File path:

[GitHub] merlimat commented on a change in pull request #1156: Introduce ActiveConsumerListener for realizing if a consumer is active in a failover subscription group

2018-02-13 Thread GitBox
merlimat commented on a change in pull request #1156: Introduce ActiveConsumerListener for realizing if a consumer is active in a failover subscription group URL: https://github.com/apache/incubator-pulsar/pull/1156#discussion_r168085850 ## File path:

[GitHub] merlimat commented on issue #1156: Introduce ActiveConsumerListener for realizing if a consumer is active in a failover subscription group

2018-02-13 Thread GitBox
merlimat commented on issue #1156: Introduce ActiveConsumerListener for realizing if a consumer is active in a failover subscription group URL: https://github.com/apache/incubator-pulsar/pull/1156#issuecomment-365509341 @sijie Change looks good, though there's still the issue at

[GitHub] merlimat closed issue #1211: Intermittent test failure int ProxyForwardAuthDataTest.testForwardAuthData

2018-02-13 Thread GitBox
merlimat closed issue #1211: Intermittent test failure int ProxyForwardAuthDataTest.testForwardAuthData URL: https://github.com/apache/incubator-pulsar/issues/1211 This is an automated message from the Apache Git Service.

[GitHub] merlimat commented on issue #1211: Intermittent test failure int ProxyForwardAuthDataTest.testForwardAuthData

2018-02-13 Thread GitBox
merlimat commented on issue #1211: Intermittent test failure int ProxyForwardAuthDataTest.testForwardAuthData URL: https://github.com/apache/incubator-pulsar/issues/1211#issuecomment-365510063 Fixed in #1230 This is an

[GitHub] merlimat commented on issue #1228: Force to pull docker build image to regenerate PulsarApi.java generat?

2018-02-13 Thread GitBox
merlimat commented on issue #1228: Force to pull docker build image to regenerate PulsarApi.java generat? URL: https://github.com/apache/incubator-pulsar/pull/1228#issuecomment-365509563 retest this please This is an

[GitHub] merlimat commented on issue #1228: Force to pull docker build image to regenerate PulsarApi.java generat?

2018-02-13 Thread GitBox
merlimat commented on issue #1228: Force to pull docker build image to regenerate PulsarApi.java generat? URL: https://github.com/apache/incubator-pulsar/pull/1228#issuecomment-365509563 retest this please This is an

[incubator-pulsar] branch master updated: Issue 937: add CommandGetLastMessageId to make reader know the end of topic (#1066)

2018-02-13 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 7404952 Issue 937: add

[GitHub] merlimat closed pull request #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic

2018-02-13 Thread GitBox
merlimat closed pull request #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic URL: https://github.com/apache/incubator-pulsar/pull/1066 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for

[GitHub] merlimat commented on issue #1089: PIP-12 Introduce builder for creating Producer Consumer Reader

2018-02-13 Thread GitBox
merlimat commented on issue #1089: PIP-12 Introduce builder for creating Producer Consumer Reader URL: https://github.com/apache/incubator-pulsar/pull/1089#issuecomment-365505133 This is ready for review. Once this is finalized and merged, I'll start converting all the code to use new

[GitHub] merlimat commented on issue #1089: PIP-12 Introduce builder for creating Producer Consumer Reader

2018-02-13 Thread GitBox
merlimat commented on issue #1089: PIP-12 Introduce builder for creating Producer Consumer Reader URL: https://github.com/apache/incubator-pulsar/pull/1089#issuecomment-365505550 > Once we have subscription for topics and pattern, we need add them in. Yes, the idea was to have