[GitHub] rdhabalia commented on issue #1253: Increase number of bundles if a topic has huge number of partitions.

2018-02-19 Thread GitBox
rdhabalia commented on issue #1253: Increase number of bundles if a topic has huge number of partitions. URL: https://github.com/apache/incubator-pulsar/issues/1253#issuecomment-366833932 I think based on the few past performance tests, we realized that bundle with 1K topic doesn't have

[GitHub] rdhabalia closed pull request #1241: Add REST api to check host-status for adding/removing from vip

2018-02-19 Thread GitBox
rdhabalia closed pull request #1241: Add REST api to check host-status for adding/removing from vip URL: https://github.com/apache/incubator-pulsar/pull/1241 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[incubator-pulsar] branch master updated: Add REST api to check host-status for adding/removing from vip (#1241)

2018-02-19 Thread rdhabalia
This is an automated email from the ASF dual-hosted git repository. rdhabalia pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new c03943a Add REST api to check

[GitHub] sijie opened a new issue #1253: Increase number of bundles if a topic has huge number of partitions.

2018-02-19 Thread GitBox
sijie opened a new issue #1253: Increase number of bundles if a topic has huge number of partitions. URL: https://github.com/apache/incubator-pulsar/issues/1253 If a topic is created with huge number of partitions, it would be good to increase number of bundles by default.

[GitHub] sijie commented on a change in pull request #1254: Use advertisedAddress for bookies in pulsar standalone

2018-02-19 Thread GitBox
sijie commented on a change in pull request #1254: Use advertisedAddress for bookies in pulsar standalone URL: https://github.com/apache/incubator-pulsar/pull/1254#discussion_r169204266 ## File path:

[GitHub] yush1ga opened a new pull request #1255: Add namespace policy for max clients

2018-02-19 Thread GitBox
yush1ga opened a new pull request #1255: Add namespace policy for max clients URL: https://github.com/apache/incubator-pulsar/pull/1255 ### Motivation We added settings for broker-level max clients limitation in https://github.com/apache/incubator-pulsar/pull/1234 We want to add

[GitHub] sijie opened a new issue #1252: Enable auto-recovery by default in bookie configuration

2018-02-19 Thread GitBox
sijie opened a new issue #1252: Enable auto-recovery by default in bookie configuration URL: https://github.com/apache/incubator-pulsar/issues/1252 It is good to enable `autorecovery` by default in bookie configuration. so people don't have to configure it to re-enable it.

[GitHub] sijie opened a new pull request #1254: Use advertisedAddress for bookies in pulsar standalone (#233)

2018-02-19 Thread GitBox
sijie opened a new pull request #1254: Use advertisedAddress for bookies in pulsar standalone (#233) URL: https://github.com/apache/incubator-pulsar/pull/1254 *Problem* current bookie advertised address is hardcoded in pulsar standalone. when using this in docker environment, those

[GitHub] jai1 commented on a change in pull request #1246: Separating configuration for client and server trust store

2018-02-19 Thread GitBox
jai1 commented on a change in pull request #1246: Separating configuration for client and server trust store URL: https://github.com/apache/incubator-pulsar/pull/1246#discussion_r169190388 ## File path:

[GitHub] rdhabalia commented on a change in pull request #1254: Use advertisedAddress for bookies in pulsar standalone

2018-02-19 Thread GitBox
rdhabalia commented on a change in pull request #1254: Use advertisedAddress for bookies in pulsar standalone URL: https://github.com/apache/incubator-pulsar/pull/1254#discussion_r169203421 ## File path:

[GitHub] sijie commented on issue #1254: Use advertisedAddress for bookies in pulsar standalone

2018-02-19 Thread GitBox
sijie commented on issue #1254: Use advertisedAddress for bookies in pulsar standalone URL: https://github.com/apache/incubator-pulsar/pull/1254#issuecomment-366892773 retest this please This is an automated message from the

[GitHub] sijie commented on issue #1254: Use advertisedAddress for bookies in pulsar standalone

2018-02-19 Thread GitBox
sijie commented on issue #1254: Use advertisedAddress for bookies in pulsar standalone URL: https://github.com/apache/incubator-pulsar/pull/1254#issuecomment-366892738 @rdhabalia I think the idea here is : if advertisedAddress is not specified, both zookeeper and bookie use

[GitHub] rdhabalia commented on a change in pull request #1254: Use advertisedAddress for bookies in pulsar standalone

2018-02-19 Thread GitBox
rdhabalia commented on a change in pull request #1254: Use advertisedAddress for bookies in pulsar standalone URL: https://github.com/apache/incubator-pulsar/pull/1254#discussion_r169234499 ## File path:

[GitHub] maskit commented on issue #1248: Start Proxy in TLS only mode.

2018-02-19 Thread GitBox
maskit commented on issue #1248: Start Proxy in TLS only mode. URL: https://github.com/apache/incubator-pulsar/pull/1248#issuecomment-366644012 I?m also fine with using ?null? as ?disabled? but how are we going to deal with default values/behavior? I didn?t read the details but my

[GitHub] maskit commented on issue #1248: Start Proxy in TLS only mode.

2018-02-19 Thread GitBox
maskit commented on issue #1248: Start Proxy in TLS only mode. URL: https://github.com/apache/incubator-pulsar/pull/1248#issuecomment-366644012 I?m also fine with using ?null? as ?disabled? but how are we going to deal with default values/behavior? I didn?t read the details but my

[GitHub] ivankelly commented on a change in pull request #1231: Read from compacted topic ledger if available and enabled

2018-02-19 Thread GitBox
ivankelly commented on a change in pull request #1231: Read from compacted topic ledger if available and enabled URL: https://github.com/apache/incubator-pulsar/pull/1231#discussion_r169023061 ## File path:

[GitHub] merlimat commented on a change in pull request #1231: Read from compacted topic ledger if available and enabled

2018-02-19 Thread GitBox
merlimat commented on a change in pull request #1231: Read from compacted topic ledger if available and enabled URL: https://github.com/apache/incubator-pulsar/pull/1231#discussion_r169097665 ## File path:

[GitHub] XiaoZYang closed pull request #1186: Pulsar FAQ

2018-02-19 Thread GitBox
XiaoZYang closed pull request #1186: Pulsar FAQ URL: https://github.com/apache/incubator-pulsar/pull/1186 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a

[GitHub] XiaoZYang commented on issue #1186: Pulsar FAQ

2018-02-19 Thread GitBox
XiaoZYang commented on issue #1186: Pulsar FAQ URL: https://github.com/apache/incubator-pulsar/pull/1186#issuecomment-366722732 @sijie 1. Yes, the PR has no related changes to FAQ, so I add a revert to it. So I'm now a little bit confused about it, should I still add a revert yet?

[GitHub] merlimat commented on issue #1231: Read from compacted topic ledger if available and enabled

2018-02-19 Thread GitBox
merlimat commented on issue #1231: Read from compacted topic ledger if available and enabled URL: https://github.com/apache/incubator-pulsar/pull/1231#issuecomment-366717444 retest this please This is an automated message

[GitHub] merlimat commented on issue #1231: Read from compacted topic ledger if available and enabled

2018-02-19 Thread GitBox
merlimat commented on issue #1231: Read from compacted topic ledger if available and enabled URL: https://github.com/apache/incubator-pulsar/pull/1231#issuecomment-366717444 retest this please This is an automated message

[GitHub] XiaoZYang commented on a change in pull request #1219: Issue 1069: Provide a setting in consumer configuration to specify where to start consuming messages

2018-02-19 Thread GitBox
XiaoZYang commented on a change in pull request #1219: Issue 1069: Provide a setting in consumer configuration to specify where to start consuming messages URL: https://github.com/apache/incubator-pulsar/pull/1219#discussion_r169105353 ## File path:

[GitHub] maskit closed pull request #1245: Refactor SecurityUtility class

2018-02-19 Thread GitBox
maskit closed pull request #1245: Refactor SecurityUtility class URL: https://github.com/apache/incubator-pulsar/pull/1245 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[incubator-pulsar] branch master updated: Refactor SecurityUtility class (#1245)

2018-02-19 Thread maskit
This is an automated email from the ASF dual-hosted git repository. maskit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 3d5d760 Refactor SecurityUtility

[GitHub] ivankelly commented on a change in pull request #1231: Read from compacted topic ledger if available and enabled

2018-02-19 Thread GitBox
ivankelly commented on a change in pull request #1231: Read from compacted topic ledger if available and enabled URL: https://github.com/apache/incubator-pulsar/pull/1231#discussion_r169111932 ## File path:

[incubator-pulsar] branch master updated: Read from compacted topic ledger if available and enabled (#1231)

2018-02-19 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 8d04a42 Read from compacted topic

[GitHub] merlimat closed pull request #1231: Read from compacted topic ledger if available and enabled

2018-02-19 Thread GitBox
merlimat closed pull request #1231: Read from compacted topic ledger if available and enabled URL: https://github.com/apache/incubator-pulsar/pull/1231 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] merlimat commented on issue #1251: Fix lookup problem with partions in a non-persistent topics

2018-02-19 Thread GitBox
merlimat commented on issue #1251: Fix lookup problem with partions in a non-persistent topics URL: https://github.com/apache/incubator-pulsar/pull/1251#issuecomment-366752045 @jai1 @rdhabalia I think this should be included in 1.22.0 as well.

[GitHub] merlimat opened a new pull request #1251: Fix lookup problem with partions in a non-persistent topics

2018-02-19 Thread GitBox
merlimat opened a new pull request #1251: Fix lookup problem with partions in a non-persistent topics URL: https://github.com/apache/incubator-pulsar/pull/1251 ### Motivation Lookup for non-persistent partitioned topic was broken under the probuf binary lookup, due to a hard-coded

[GitHub] XiaoZYang commented on a change in pull request #1219: Issue 1069: Provide a setting in consumer configuration to specify where to start consuming messages

2018-02-19 Thread GitBox
XiaoZYang commented on a change in pull request #1219: Issue 1069: Provide a setting in consumer configuration to specify where to start consuming messages URL: https://github.com/apache/incubator-pulsar/pull/1219#discussion_r169108145 ## File path:

[GitHub] merlimat opened a new issue #1250: Metadata lookup for a non-persistent partitioned topic returns there are no partitions

2018-02-19 Thread GitBox
merlimat opened a new issue #1250: Metadata lookup for a non-persistent partitioned topic returns there are no partitions URL: https://github.com/apache/incubator-pulsar/issues/1250 When using a non-persistent topic with partitions, the metadata can be set correctly through the

[incubator-pulsar] branch master updated: Fix lookup problem with partions in a non-persistent topics (#1251)

2018-02-19 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 4f1dc52 Fix lookup problem with

[GitHub] merlimat closed pull request #1251: Fix lookup problem with partions in a non-persistent topics

2018-02-19 Thread GitBox
merlimat closed pull request #1251: Fix lookup problem with partions in a non-persistent topics URL: https://github.com/apache/incubator-pulsar/pull/1251 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] merlimat closed issue #1250: Metadata lookup for a non-persistent partitioned topic returns there are no partitions

2018-02-19 Thread GitBox
merlimat closed issue #1250: Metadata lookup for a non-persistent partitioned topic returns there are no partitions URL: https://github.com/apache/incubator-pulsar/issues/1250 This is an automated message from the Apache

[GitHub] merlimat commented on issue #1251: Fix lookup problem with partions in a non-persistent topics

2018-02-19 Thread GitBox
merlimat commented on issue #1251: Fix lookup problem with partions in a non-persistent topics URL: https://github.com/apache/incubator-pulsar/pull/1251#issuecomment-366758180 (I have the change for 1.22 branch already ready to backport, will do once this is merged)

[incubator-pulsar] branch branch-1.22 updated: Fix lookup problem with partions in a non-persistent topics

2018-02-19 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch branch-1.22 in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/branch-1.22 by this push: new e13bdb3 Fix lookup problem

[GitHub] XiaoZYang commented on a change in pull request #1219: Issue 1069: Provide a setting in consumer configuration to specify where to start consuming messages

2018-02-19 Thread GitBox
XiaoZYang commented on a change in pull request #1219: Issue 1069: Provide a setting in consumer configuration to specify where to start consuming messages URL: https://github.com/apache/incubator-pulsar/pull/1219#discussion_r169108416 ## File path: