[GitHub] hrsakai commented on issue #1273: Allow superuser to consume without subscription_auth_mode check

2018-02-23 Thread GitBox
hrsakai commented on issue #1273: Allow superuser to consume without subscription_auth_mode check URL: https://github.com/apache/incubator-pulsar/pull/1273#issuecomment-368158753 Above modification is included in https://github.com/apache/incubator-pulsar/pull/1242

[incubator-pulsar] branch master updated: Change HTTP status code which WebSocket proxy returns to producer whe… (#1242)

2018-02-23 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new adbf818 Change HTTP status code

[GitHub] merlimat closed pull request #1242: Change HTTP status code which WebSocket proxy returns to producer whe?

2018-02-23 Thread GitBox
merlimat closed pull request #1242: Change HTTP status code which WebSocket proxy returns to producer whe? URL: https://github.com/apache/incubator-pulsar/pull/1242 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[incubator-pulsar] branch master updated: allow superuser to consume without subscription_auth_mode check (#1273)

2018-02-23 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 7eb1002 allow superuser to consume

[GitHub] rdhabalia commented on a change in pull request #1276: Refactored ClientConfuguration to use ClientConfigurationData shared with ClientBuilderImpl

2018-02-23 Thread GitBox
rdhabalia commented on a change in pull request #1276: Refactored ClientConfuguration to use ClientConfigurationData shared with ClientBuilderImpl URL: https://github.com/apache/incubator-pulsar/pull/1276#discussion_r170385060 ## File path: pom.xml ## @@ -598,6 +598,13 @@

[GitHub] merlimat commented on issue #1259: Is there any relationship between Yahoo Message Broker and Pulsar projects?

2018-02-23 Thread GitBox
merlimat commented on issue #1259: Is there any relationship between Yahoo Message Broker and Pulsar projects? URL: https://github.com/apache/incubator-pulsar/issues/1259#issuecomment-368179169 I know about Spanner, though I have no insight about the replication implementation in

[GitHub] merlimat commented on a change in pull request #1276: Refactored ClientConfuguration to use ClientConfigurationData shared with ClientBuilderImpl

2018-02-23 Thread GitBox
merlimat commented on a change in pull request #1276: Refactored ClientConfuguration to use ClientConfigurationData shared with ClientBuilderImpl URL: https://github.com/apache/incubator-pulsar/pull/1276#discussion_r170387619 ## File path:

[GitHub] sijie commented on a change in pull request #1275: Docker image for integration testing

2018-02-23 Thread GitBox
sijie commented on a change in pull request #1275: Docker image for integration testing URL: https://github.com/apache/incubator-pulsar/pull/1275#discussion_r170396462 ## File path: tests/docker-images/latest-version-image/Dockerfile ## @@ -0,0 +1,52 @@ +# +# Licensed to

[GitHub] joefk commented on issue #1259: Is there any relationship between Yahoo Message Broker and Pulsar projects?

2018-02-23 Thread GitBox
joefk commented on issue #1259: Is there any relationship between Yahoo Message Broker and Pulsar projects? URL: https://github.com/apache/incubator-pulsar/issues/1259#issuecomment-368180020 Cockroachdb uses Raft, and the replication is strongly consistent. Doing strict consensus

[GitHub] merlimat commented on a change in pull request #1275: Docker image for integration testing

2018-02-23 Thread GitBox
merlimat commented on a change in pull request #1275: Docker image for integration testing URL: https://github.com/apache/incubator-pulsar/pull/1275#discussion_r170401452 ## File path: tests/docker-images/latest-version-image/Dockerfile ## @@ -0,0 +1,52 @@ +# +# Licensed

[GitHub] sijie commented on issue #1274: Upgrade jersey version to 2.26 and powermock to 1.7.3

2018-02-23 Thread GitBox
sijie commented on issue #1274: Upgrade jersey version to 2.26 and powermock to 1.7.3 URL: https://github.com/apache/incubator-pulsar/pull/1274#issuecomment-368151223 @merlimat I missed the inject package. I fixed this. also includes some other dependencies changes (updated the PR title

[GitHub] rdhabalia commented on a change in pull request #1276: Refactored ClientConfuguration to use ClientConfigurationData shared with ClientBuilderImpl

2018-02-23 Thread GitBox
rdhabalia commented on a change in pull request #1276: Refactored ClientConfuguration to use ClientConfigurationData shared with ClientBuilderImpl URL: https://github.com/apache/incubator-pulsar/pull/1276#discussion_r170382654 ## File path:

[GitHub] rdhabalia commented on a change in pull request #1276: Refactored ClientConfuguration to use ClientConfigurationData shared with ClientBuilderImpl

2018-02-23 Thread GitBox
rdhabalia commented on a change in pull request #1276: Refactored ClientConfuguration to use ClientConfigurationData shared with ClientBuilderImpl URL: https://github.com/apache/incubator-pulsar/pull/1276#discussion_r170383778 ## File path: pom.xml ## @@ -598,6 +598,13 @@

[GitHub] sijie commented on issue #1274: Upgrade jersey version to 2.26 and powermock to 1.7.3

2018-02-23 Thread GitBox
sijie commented on issue #1274: Upgrade jersey version to 2.26 and powermock to 1.7.3 URL: https://github.com/apache/incubator-pulsar/pull/1274#issuecomment-368162596 retest this please This is an automated message from the

[incubator-pulsar] branch master updated: Pulsar FAQ (#1186)

2018-02-23 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new a72c912 Pulsar FAQ (#1186) a72c912

[GitHub] merlimat closed pull request #1186: Pulsar FAQ

2018-02-23 Thread GitBox
merlimat closed pull request #1186: Pulsar FAQ URL: https://github.com/apache/incubator-pulsar/pull/1186 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a

[incubator-pulsar] branch master updated: Improve retention and expiry documentation (WIP) (#1172)

2018-02-23 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 2f1ef0b Improve retention and expiry

[GitHub] merlimat closed pull request #1172: Improve retention and expiry documentation (WIP)

2018-02-23 Thread GitBox
merlimat closed pull request #1172: Improve retention and expiry documentation (WIP) URL: https://github.com/apache/incubator-pulsar/pull/1172 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] merlimat commented on issue #1186: Pulsar FAQ

2018-02-23 Thread GitBox
merlimat commented on issue #1186: Pulsar FAQ URL: https://github.com/apache/incubator-pulsar/pull/1186#issuecomment-368168033 Sure, let's merge and then link it on the homepage after the cleanup. This is an automated message

[GitHub] jerrypeng opened a new pull request #1277: fix bug in seek if no messages in topic

2018-02-23 Thread GitBox
jerrypeng opened a new pull request #1277: fix bug in seek if no messages in topic URL: https://github.com/apache/incubator-pulsar/pull/1277 If you call getLastMessageId and then use that messageId to seek, the seek will throw an exception since the ledgerId will exist but the entryId

[GitHub] merlimat commented on a change in pull request #1277: fix bug in seek if no messages in topic

2018-02-23 Thread GitBox
merlimat commented on a change in pull request #1277: fix bug in seek if no messages in topic URL: https://github.com/apache/incubator-pulsar/pull/1277#discussion_r170398876 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java ## @@

[GitHub] hrsakai commented on issue #1273: Allow superuser to consume without subscription_auth_mode check

2018-02-23 Thread GitBox
hrsakai commented on issue #1273: Allow superuser to consume without subscription_auth_mode check URL: https://github.com/apache/incubator-pulsar/pull/1273#issuecomment-368157487 @merlimat Now, proxy doesn't check. Fix this bug in following modification.

[GitHub] merlimat commented on a change in pull request #1276: Refactored ClientConfuguration to use ClientConfigurationData shared with ClientBuilderImpl

2018-02-23 Thread GitBox
merlimat commented on a change in pull request #1276: Refactored ClientConfuguration to use ClientConfigurationData shared with ClientBuilderImpl URL: https://github.com/apache/incubator-pulsar/pull/1276#discussion_r170387871 ## File path: pom.xml ## @@ -598,6 +598,13 @@

[GitHub] David-Jin commented on issue #1259: Is there any relationship between Yahoo Message Broker and Pulsar projects?

2018-02-23 Thread GitBox
David-Jin commented on issue #1259: Is there any relationship between Yahoo Message Broker and Pulsar projects? URL: https://github.com/apache/incubator-pulsar/issues/1259#issuecomment-368177948 Hi, Merlimat: When in the sync SQL database scenario, what do you think about

[GitHub] sijie commented on a change in pull request #1276: Refactored ClientConfuguration to use ClientConfigurationData shared with ClientBuilderImpl

2018-02-23 Thread GitBox
sijie commented on a change in pull request #1276: Refactored ClientConfuguration to use ClientConfigurationData shared with ClientBuilderImpl URL: https://github.com/apache/incubator-pulsar/pull/1276#discussion_r170387267 ## File path: pom.xml ## @@ -598,6 +598,13 @@

[GitHub] sijie commented on issue #1274: Upgrade jersey version to 2.26 and powermock to 1.7.3

2018-02-23 Thread GitBox
sijie commented on issue #1274: Upgrade jersey version to 2.26 and powermock to 1.7.3 URL: https://github.com/apache/incubator-pulsar/pull/1274#issuecomment-368185972 retest this please This is an automated message from the

[GitHub] merlimat commented on issue #1276: Refactored ClientConfuguration to use ClientConfigurationData shared with ClientBuilderImpl

2018-02-23 Thread GitBox
merlimat commented on issue #1276: Refactored ClientConfuguration to use ClientConfigurationData shared with ClientBuilderImpl URL: https://github.com/apache/incubator-pulsar/pull/1276#issuecomment-368181620 retest this please

[GitHub] merlimat commented on issue #1276: Refactored ClientConfuguration to use ClientConfigurationData shared with ClientBuilderImpl

2018-02-23 Thread GitBox
merlimat commented on issue #1276: Refactored ClientConfuguration to use ClientConfigurationData shared with ClientBuilderImpl URL: https://github.com/apache/incubator-pulsar/pull/1276#issuecomment-368181620 retest this please

[GitHub] merlimat commented on a change in pull request #1276: Refactored ClientConfuguration to use ClientConfigurationData shared with ClientBuilderImpl

2018-02-23 Thread GitBox
merlimat commented on a change in pull request #1276: Refactored ClientConfuguration to use ClientConfigurationData shared with ClientBuilderImpl URL: https://github.com/apache/incubator-pulsar/pull/1276#discussion_r170408057 ## File path: pom.xml ## @@ -598,6 +598,13 @@

[GitHub] zhaijack opened a new pull request #1279: PIP-13-2/3: support regex based subscription

2018-02-23 Thread GitBox
zhaijack opened a new pull request #1279: PIP-13-2/3: support regex based subscription URL: https://github.com/apache/incubator-pulsar/pull/1279 ### Motivation This is a second sub-task for pip-13, which would like to leverage the first task to support regex based subscription.

[GitHub] zhaijack opened a new issue #1278: Update Java admin client to handle both old and new topic names

2018-02-23 Thread GitBox
zhaijack opened a new issue #1278: Update Java admin client to handle both old and new topic names URL: https://github.com/apache/incubator-pulsar/issues/1278 we need to update Java admin client to handle both old and new topic names, switching automatically from `/admin/` to `/admin/v2`

[GitHub] jerrypeng closed pull request #1277: fix bug in seek if no messages in topic

2018-02-23 Thread GitBox
jerrypeng closed pull request #1277: fix bug in seek if no messages in topic URL: https://github.com/apache/incubator-pulsar/pull/1277 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] jerrypeng commented on a change in pull request #1277: fix bug in seek if no messages in topic

2018-02-23 Thread GitBox
jerrypeng commented on a change in pull request #1277: fix bug in seek if no messages in topic URL: https://github.com/apache/incubator-pulsar/pull/1277#discussion_r170411363 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java ## @@

[GitHub] merlimat commented on issue #680: Upgrade to log4j2 dependency and configuration

2018-02-23 Thread GitBox
merlimat commented on issue #680: Upgrade to log4j2 dependency and configuration URL: https://github.com/apache/incubator-pulsar/pull/680#issuecomment-368078530 Yes, this PR was good to go. The only reason it was delayed for 2.0 was the breaking changes in the log4j conf file format.

[GitHub] merlimat commented on issue #1255: Add namespace policy for max clients

2018-02-23 Thread GitBox
merlimat commented on issue #1255: Add namespace policy for max clients URL: https://github.com/apache/incubator-pulsar/pull/1255#issuecomment-368082141 Sure, it would be great to restrict to administrator only then. This is

[GitHub] merlimat commented on a change in pull request #1272: Add prefix setting for Java reader

2018-02-23 Thread GitBox
merlimat commented on a change in pull request #1272: Add prefix setting for Java reader URL: https://github.com/apache/incubator-pulsar/pull/1272#discussion_r170309164 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/api/ReaderBuilder.java ## @@ -137,4

[GitHub] ivankelly opened a new pull request #1275: Docker image for integration testing

2018-02-23 Thread GitBox
ivankelly opened a new pull request #1275: Docker image for integration testing URL: https://github.com/apache/incubator-pulsar/pull/1275 A docker image built with the pulsar distribution tarball. The same image can be used to run zookeeper, bookkeeper, the broker or a proxy. Scripts

[GitHub] merlimat commented on issue #1274: Upgrade jersey version to 2.26

2018-02-23 Thread GitBox
merlimat commented on issue #1274: Upgrade jersey version to 2.26 URL: https://github.com/apache/incubator-pulsar/pull/1274#issuecomment-368071945 There are some failures with Jersey: ``` Caused by: java.lang.IllegalStateException: InjectionManagerFactory not found. at

[incubator-pulsar] branch master updated: Added ManagedLedger perf tool (#1270)

2018-02-23 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new e581d95 Added ManagedLedger perf

[GitHub] merlimat closed pull request #1270: Added ManagedLedger perf tool

2018-02-23 Thread GitBox
merlimat closed pull request #1270: Added ManagedLedger perf tool URL: https://github.com/apache/incubator-pulsar/pull/1270 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] merlimat commented on issue #680: Upgrade to log4j2 dependency and configuration

2018-02-23 Thread GitBox
merlimat commented on issue #680: Upgrade to log4j2 dependency and configuration URL: https://github.com/apache/incubator-pulsar/pull/680#issuecomment-368081404 Fixed the conflict with master This is an automated message from

[GitHub] hrsakai opened a new pull request #1273: Allow superuser to consume without subscription_auth_mode check

2018-02-23 Thread GitBox
hrsakai opened a new pull request #1273: Allow superuser to consume without subscription_auth_mode check URL: https://github.com/apache/incubator-pulsar/pull/1273 ### Motivation In our environment, websocket client can't subscribe topics whose namespace has subscription_auth_mode

[incubator-pulsar] branch asf-site updated: Updated site at revision f38a003

2018-02-23 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/asf-site by this push: new a6e95b2 Updated site at revision

[GitHub] merlimat closed pull request #680: Upgrade to log4j2 dependency and configuration

2018-02-23 Thread GitBox
merlimat closed pull request #680: Upgrade to log4j2 dependency and configuration URL: https://github.com/apache/incubator-pulsar/pull/680 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[incubator-pulsar] branch master updated: Upgrade to log4j2 dependency and configuration (#680)

2018-02-23 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 21d3307 Upgrade to log4j2 dependency

[GitHub] merlimat closed pull request #1246: Separating configuration for client and server trust store

2018-02-23 Thread GitBox
merlimat closed pull request #1246: Separating configuration for client and server trust store URL: https://github.com/apache/incubator-pulsar/pull/1246 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] merlimat commented on a change in pull request #1246: Separating configuration for client and server trust store

2018-02-23 Thread GitBox
merlimat commented on a change in pull request #1246: Separating configuration for client and server trust store URL: https://github.com/apache/incubator-pulsar/pull/1246#discussion_r170337178 ## File path:

[incubator-pulsar] branch master updated: Separating configuration for client and server trust store (#1246)

2018-02-23 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new c351026 Separating configuration

[GitHub] merlimat opened a new pull request #1276: Refactored ClientConfuguration to use ClientConfigurationData shared with ClientBuilderImpl

2018-02-23 Thread GitBox
merlimat opened a new pull request #1276: Refactored ClientConfuguration to use ClientConfigurationData shared with ClientBuilderImpl URL: https://github.com/apache/incubator-pulsar/pull/1276 ### Motivation This is a refactoring change continuing from #1089 for PIP-12. ###

[GitHub] sijie commented on issue #1059: Issue 1014: Rename "global zookeeper" to "configuration-store"(change in code, conf and cli)

2018-02-23 Thread GitBox
sijie commented on issue #1059: Issue 1014: Rename "global zookeeper" to "configuration-store"(change in code, conf and cli) URL: https://github.com/apache/incubator-pulsar/pull/1059#issuecomment-367953526 @zhaijack can you rebase this to latest master?

[GitHub] sijie opened a new pull request #1274: Upgrade jersey version to 2.26

2018-02-23 Thread GitBox
sijie opened a new pull request #1274: Upgrade jersey version to 2.26 URL: https://github.com/apache/incubator-pulsar/pull/1274 ### Motivation when developing pulsar-functions for PIP-15, we upgraded jersey version to 2.26. so upgrade jersey version in master to prepare merging

[GitHub] sijie commented on issue #680: Upgrade to log4j2 dependency and configuration

2018-02-23 Thread GitBox
sijie commented on issue #680: Upgrade to log4j2 dependency and configuration URL: https://github.com/apache/incubator-pulsar/pull/680#issuecomment-367953942 @rdhabalia @merlimat can we consider merging this pull request? since the master is for 2.0 release now. we might need this