[GitHub] sijie commented on a change in pull request #1279: PIP-13-2/3: support regex based subscription

2018-02-26 Thread GitBox
sijie commented on a change in pull request #1279: PIP-13-2/3: support regex based subscription URL: https://github.com/apache/incubator-pulsar/pull/1279#discussion_r170527487 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/api/ConsumerBuilder.java ##

[GitHub] ivankelly commented on a change in pull request #1275: Docker image for integration testing

2018-02-26 Thread GitBox
ivankelly commented on a change in pull request #1275: Docker image for integration testing URL: https://github.com/apache/incubator-pulsar/pull/1275#discussion_r170530767 ## File path: tests/docker-images/latest-version-image/Dockerfile ## @@ -0,0 +1,52 @@ +# +# Licensed

[GitHub] yush1ga commented on issue #1283: Add prefix setting for C++ reader

2018-02-26 Thread GitBox
yush1ga commented on issue #1283: Add prefix setting for C++ reader URL: https://github.com/apache/incubator-pulsar/pull/1283#issuecomment-368440112 retest this please This is an automated message from the Apache Git Service.

[GitHub] yush1ga commented on issue #1283: Add prefix setting for C++ reader

2018-02-26 Thread GitBox
yush1ga commented on issue #1283: Add prefix setting for C++ reader URL: https://github.com/apache/incubator-pulsar/pull/1283#issuecomment-368440112 retest this please This is an automated message from the Apache Git Service.

[incubator-pulsar] branch master updated: Fixed merge issues with DestinationName renaming (#1282)

2018-02-26 Thread yushiga
This is an automated email from the ASF dual-hosted git repository. yushiga pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new c308bd5 Fixed merge issues with

[GitHub] yush1ga closed pull request #1282: Fixed merge issues with DestinationName renaming

2018-02-26 Thread GitBox
yush1ga closed pull request #1282: Fixed merge issues with DestinationName renaming URL: https://github.com/apache/incubator-pulsar/pull/1282 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] ivankelly opened a new pull request #1286: Compaction uses GetLastMessageId

2018-02-26 Thread GitBox
ivankelly opened a new pull request #1286: Compaction uses GetLastMessageId URL: https://github.com/apache/incubator-pulsar/pull/1286 In two phase compaction, we read from the start of the topic to the end. Previously, we had no reliable way to knowing if we were at the end of the

[GitHub] lucperkins opened a new issue #1288: Provide documentation for running BookKeeper auto-recovery

2018-02-26 Thread GitBox
lucperkins opened a new issue #1288: Provide documentation for running BookKeeper auto-recovery URL: https://github.com/apache/incubator-pulsar/issues/1288 While BookKeeper auto-recovery has already been incorporated into the Pulsar setup for DC/OS and Kubernetes. We need to provide

[GitHub] ivankelly commented on issue #1284: Mavenize docker images

2018-02-26 Thread GitBox
ivankelly commented on issue #1284: Mavenize docker images URL: https://github.com/apache/incubator-pulsar/pull/1284#issuecomment-368584735 :+1: will run it This is an automated message from the Apache Git Service. To

[GitHub] merlimat commented on issue #1284: Mavenize docker images

2018-02-26 Thread GitBox
merlimat commented on issue #1284: Mavenize docker images URL: https://github.com/apache/incubator-pulsar/pull/1284#issuecomment-368613499 retest this please This is an automated message from the Apache Git Service. To

[GitHub] merlimat commented on issue #1288: Provide documentation for running BookKeeper auto-recovery

2018-02-26 Thread GitBox
merlimat commented on issue #1288: Provide documentation for running BookKeeper auto-recovery URL: https://github.com/apache/incubator-pulsar/issues/1288#issuecomment-368629520 For auto-recovery, the main documentation is already in the BK side:

[GitHub] lucperkins opened a new issue #1287: Provide documentation for the load manager and bundles

2018-02-26 Thread GitBox
lucperkins opened a new issue #1287: Provide documentation for the load manager and bundles URL: https://github.com/apache/incubator-pulsar/issues/1287 Ensuring proper traffic distribution in Pulsar is an essential administrative function. We currently have very little documentation on

[GitHub] lucperkins commented on issue #1288: Provide documentation for running BookKeeper auto-recovery

2018-02-26 Thread GitBox
lucperkins commented on issue #1288: Provide documentation for running BookKeeper auto-recovery URL: https://github.com/apache/incubator-pulsar/issues/1288#issuecomment-368630025 @merlimat Yep! Should be pretty easy ? This

[GitHub] merlimat closed pull request #1285: BatchMessageIdImpl can be compared to MessageIdImpl

2018-02-26 Thread GitBox
merlimat closed pull request #1285: BatchMessageIdImpl can be compared to MessageIdImpl URL: https://github.com/apache/incubator-pulsar/pull/1285 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[incubator-pulsar] branch master updated: BatchMessageIdImpl can be compared to MessageIdImpl (#1285)

2018-02-26 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 4f1f02b BatchMessageIdImpl can be

[GitHub] merlimat commented on issue #1284: Mavenize docker images

2018-02-26 Thread GitBox
merlimat commented on issue #1284: Mavenize docker images URL: https://github.com/apache/incubator-pulsar/pull/1284#issuecomment-368579322 @ivankelly I think the license plugin is not recognizing the ASF header in the new pom files. Easiest way is to just use `mvn license:format` to fix.

[GitHub] merlimat commented on a change in pull request #1219: Issue 1069: Provide a setting in consumer configuration to specify where to start consuming messages

2018-02-26 Thread GitBox
merlimat commented on a change in pull request #1219: Issue 1069: Provide a setting in consumer configuration to specify where to start consuming messages URL: https://github.com/apache/incubator-pulsar/pull/1219#discussion_r170393313 ## File path:

[GitHub] merlimat commented on a change in pull request #1219: Issue 1069: Provide a setting in consumer configuration to specify where to start consuming messages

2018-02-26 Thread GitBox
merlimat commented on a change in pull request #1219: Issue 1069: Provide a setting in consumer configuration to specify where to start consuming messages URL: https://github.com/apache/incubator-pulsar/pull/1219#discussion_r170393228 ## File path:

[GitHub] merlimat commented on issue #1284: Mavenize docker images

2018-02-26 Thread GitBox
merlimat commented on issue #1284: Mavenize docker images URL: https://github.com/apache/incubator-pulsar/pull/1284#issuecomment-368613499 retest this please This is an automated message from the Apache Git Service. To

[GitHub] merlimat closed pull request #1286: Compaction uses GetLastMessageId

2018-02-26 Thread GitBox
merlimat closed pull request #1286: Compaction uses GetLastMessageId URL: https://github.com/apache/incubator-pulsar/pull/1286 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[incubator-pulsar] branch master updated: Mavenize docker images (#1284)

2018-02-26 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 9656c06 Mavenize docker images

[incubator-pulsar] branch master updated: Compaction uses GetLastMessageId (#1286)

2018-02-26 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new da64d0c Compaction uses

[GitHub] sijie commented on issue #1274: Upgrade jersey version to 2.26 and powermock to 1.7.3

2018-02-26 Thread GitBox
sijie commented on issue #1274: Upgrade jersey version to 2.26 and powermock to 1.7.3 URL: https://github.com/apache/incubator-pulsar/pull/1274#issuecomment-368670589 fixed the test case @merlimat This is an automated

[GitHub] merlimat commented on issue #1295: Use log4j2 as slf4j binding for tests

2018-02-26 Thread GitBox
merlimat commented on issue #1295: Use log4j2 as slf4j binding for tests URL: https://github.com/apache/incubator-pulsar/pull/1295#issuecomment-368762675 Since `buildtools` is not using `pulsar` as parent pom, now we have issue with the missing plugins: ``` [ERROR] Could not

[GitHub] merlimat commented on a change in pull request #1137: Schema registry

2018-02-26 Thread GitBox
merlimat commented on a change in pull request #1137: Schema registry URL: https://github.com/apache/incubator-pulsar/pull/1137#discussion_r170831022 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/SchemasResource.java ## @@ -0,0 +1,274 @@ +/** +

[GitHub] merlimat commented on a change in pull request #1137: Schema registry

2018-02-26 Thread GitBox
merlimat commented on a change in pull request #1137: Schema registry URL: https://github.com/apache/incubator-pulsar/pull/1137#discussion_r170829387 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/schema/SchemaRegistry.java ## @@ -0,0 +1,79 @@

[GitHub] merlimat commented on a change in pull request #1137: Schema registry

2018-02-26 Thread GitBox
merlimat commented on a change in pull request #1137: Schema registry URL: https://github.com/apache/incubator-pulsar/pull/1137#discussion_r170829964 ## File path: pulsar-common/src/main/java/org/apache/pulsar/common/schema/Schema.java ## @@ -0,0 +1,139 @@ +/** + *

[GitHub] merlimat commented on a change in pull request #1137: Schema registry

2018-02-26 Thread GitBox
merlimat commented on a change in pull request #1137: Schema registry URL: https://github.com/apache/incubator-pulsar/pull/1137#discussion_r170829724 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java ## @@ -689,6 +694,33 @@

[GitHub] merlimat commented on a change in pull request #1137: Schema registry

2018-02-26 Thread GitBox
merlimat commented on a change in pull request #1137: Schema registry URL: https://github.com/apache/incubator-pulsar/pull/1137#discussion_r170830884 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/SchemasResource.java ## @@ -0,0 +1,274 @@ +/** +

[GitHub] merlimat commented on a change in pull request #1137: Schema registry

2018-02-26 Thread GitBox
merlimat commented on a change in pull request #1137: Schema registry URL: https://github.com/apache/incubator-pulsar/pull/1137#discussion_r170831151 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/SchemasResource.java ## @@ -0,0 +1,274 @@ +/** +

[GitHub] ivankelly commented on issue #1289: Watch-znode script for docker image

2018-02-26 Thread GitBox
ivankelly commented on issue #1289: Watch-znode script for docker image URL: https://github.com/apache/incubator-pulsar/pull/1289#issuecomment-368649667 @merlimat I'd like to get this into the base image, so that it can be used to build a docker compose for the base image. it doesn't

[GitHub] yush1ga commented on a change in pull request #1283: Add prefix setting for C++/Python reader

2018-02-26 Thread GitBox
yush1ga commented on a change in pull request #1283: Add prefix setting for C++/Python reader URL: https://github.com/apache/incubator-pulsar/pull/1283#discussion_r170834939 ## File path: pulsar-client-cpp/python/src/config.cc ## @@ -142,5 +142,7 @@ void export_config() {

[GitHub] zhaijack commented on issue #1175: PIP-13-3/3: auto subscribe based on regex pattern topics changing

2018-02-26 Thread GitBox
zhaijack commented on issue #1175: PIP-13-3/3: auto subscribe based on regex pattern topics changing URL: https://github.com/apache/incubator-pulsar/pull/1175#issuecomment-368776292 close this for too much conflict, will open new one

[incubator-pulsar] branch cpp-reader-prefix deleted (was ff3dcad)

2018-02-26 Thread yushiga
This is an automated email from the ASF dual-hosted git repository. yushiga pushed a change to branch cpp-reader-prefix in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git. was ff3dcad Ran "make format" This change permanently discards the following revisions:

[GitHub] sijie opened a new pull request #1294: Add a shaded module for pulsar-client-tools

2018-02-26 Thread GitBox
sijie opened a new pull request #1294: Add a shaded module for pulsar-client-tools URL: https://github.com/apache/incubator-pulsar/pull/1294 Provide a pulsar-client-tools shaded module. This will be used by pulsar-functions.

[GitHub] lucperkins opened a new pull request #1296: Update CLI documentation (WIP)

2018-02-26 Thread GitBox
lucperkins opened a new pull request #1296: Update CLI documentation (WIP) URL: https://github.com/apache/incubator-pulsar/pull/1296 The docs for the various Pulsar [CLI tools](http://pulsar.incubator.apache.org/docs/latest/reference/CliTools/) are a bit out of date. This PR brings them

[GitHub] sijie commented on issue #1274: Upgrade jersey version to 2.25 and powermock to 1.7.3

2018-02-26 Thread GitBox
sijie commented on issue #1274: Upgrade jersey version to 2.25 and powermock to 1.7.3 URL: https://github.com/apache/incubator-pulsar/pull/1274#issuecomment-368686589 2.26 has a big change of making Jersey core independent of any specific injection framework, which it seems to disallow

[incubator-pulsar] branch master updated: Fix Terraform/Ansible docs (#1290)

2018-02-26 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 3739567 Fix Terraform/Ansible docs

[GitHub] merlimat closed pull request #1290: Fix Terraform/Ansible docs

2018-02-26 Thread GitBox
merlimat closed pull request #1290: Fix Terraform/Ansible docs URL: https://github.com/apache/incubator-pulsar/pull/1290 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[incubator-pulsar] branch master updated: Upgrade jersey version to 2.25 and powermock to 1.7.3 (#1274)

2018-02-26 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 8a20499 Upgrade jersey version to

[GitHub] merlimat closed pull request #1274: Upgrade jersey version to 2.25 and powermock to 1.7.3

2018-02-26 Thread GitBox
merlimat closed pull request #1274: Upgrade jersey version to 2.25 and powermock to 1.7.3 URL: https://github.com/apache/incubator-pulsar/pull/1274 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] sijie opened a new pull request #1293: Enable multipart feature in pulsar admin and make a few fields protected to allow extension

2018-02-26 Thread GitBox
sijie opened a new pull request #1293: Enable multipart feature in pulsar admin and make a few fields protected to allow extension URL: https://github.com/apache/incubator-pulsar/pull/1293 This change is to allow extension for pulsar function CLI, preparing for merging pulsar-functions.

[GitHub] sijie opened a new pull request #1295: Use log4j2 as slf4j binding for tests

2018-02-26 Thread GitBox
sijie opened a new pull request #1295: Use log4j2 as slf4j binding for tests URL: https://github.com/apache/incubator-pulsar/pull/1295 ### Motivation in pulsar-functions, we are using log4j2 routing appender for logging. so pulsar-functions is using log4j2, if we are using

[GitHub] lucperkins opened a new pull request #1290: Fix Terraform/Ansible docs

2018-02-26 Thread GitBox
lucperkins opened a new pull request #1290: Fix Terraform/Ansible docs URL: https://github.com/apache/incubator-pulsar/pull/1290 There are some issues with the current Terraform/Ansible/AWS docs addressed in this PR.

[GitHub] lucperkins opened a new pull request #1291: Streamline Ansible setup

2018-02-26 Thread GitBox
lucperkins opened a new pull request #1291: Streamline Ansible setup URL: https://github.com/apache/incubator-pulsar/pull/1291 ### Motivation In Pulsar version 1.22.0-incubating, there will be CLI flags that enable you to easily run a Pulsar, a BookKeeper bookie, and a BookKeeper

[GitHub] merlimat opened a new pull request #1292: Switched to BookKeeper-4.7.0-SNAPSHOT + Adjustements

2018-02-26 Thread GitBox
merlimat opened a new pull request #1292: Switched to BookKeeper-4.7.0-SNAPSHOT + Adjustements URL: https://github.com/apache/incubator-pulsar/pull/1292 ### Motivation All the changes done on the Yahoo branch of BookKeeper have been already merged into master, so we can now switch

[GitHub] merlimat commented on a change in pull request #1279: PIP-13-2/3: support regex based subscription

2018-02-26 Thread GitBox
merlimat commented on a change in pull request #1279: PIP-13-2/3: support regex based subscription URL: https://github.com/apache/incubator-pulsar/pull/1279#discussion_r170785931 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/api/ConsumerBuilder.java

[GitHub] yush1ga commented on issue #1283: Add prefix setting for C++ reader

2018-02-26 Thread GitBox
yush1ga commented on issue #1283: Add prefix setting for C++ reader URL: https://github.com/apache/incubator-pulsar/pull/1283#issuecomment-368447133 retest this please This is an automated message from the Apache Git Service.

[GitHub] sijie commented on issue #1274: Upgrade jersey version to 2.26 and powermock to 1.7.3

2018-02-26 Thread GitBox
sijie commented on issue #1274: Upgrade jersey version to 2.26 and powermock to 1.7.3 URL: https://github.com/apache/incubator-pulsar/pull/1274#issuecomment-368476612 retest this please This is an automated message from the

[GitHub] ivankelly commented on issue #1284: Mavenize docker images

2018-02-26 Thread GitBox
ivankelly commented on issue #1284: Mavenize docker images URL: https://github.com/apache/incubator-pulsar/pull/1284#issuecomment-368476463 @merlimat @sijie This is an automated message from the Apache Git Service. To

[GitHub] ivankelly opened a new pull request #1284: Mavenize docker images

2018-02-26 Thread GitBox
ivankelly opened a new pull request #1284: Mavenize docker images URL: https://github.com/apache/incubator-pulsar/pull/1284 Build pulsar docker images with maven. This will make it easier to pull them in as a base for the maven integration tests. I didn't touch the publish script,

[incubator-pulsar] branch master updated: Update CLI documentation (WIP) (#1296)

2018-02-26 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new fadb667 Update CLI documentation

[GitHub] merlimat closed pull request #1296: Update CLI documentation (WIP)

2018-02-26 Thread GitBox
merlimat closed pull request #1296: Update CLI documentation (WIP) URL: https://github.com/apache/incubator-pulsar/pull/1296 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[incubator-pulsar] branch master updated: Enable multipart feature in pulsar admin and make a few fields protected to allow extension (#1293)

2018-02-26 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 83972e1 Enable multipart feature in

[GitHub] XiaoZYang commented on a change in pull request #1219: Issue 1069: Provide a setting in consumer configuration to specify where to start consuming messages

2018-02-26 Thread GitBox
XiaoZYang commented on a change in pull request #1219: Issue 1069: Provide a setting in consumer configuration to specify where to start consuming messages URL: https://github.com/apache/incubator-pulsar/pull/1219#discussion_r170820141 ## File path:

[GitHub] merlimat closed pull request #1279: PIP-13-2/3: support regex based subscription

2018-02-26 Thread GitBox
merlimat closed pull request #1279: PIP-13-2/3: support regex based subscription URL: https://github.com/apache/incubator-pulsar/pull/1279 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[incubator-pulsar] branch master updated: PIP-13-2/3: support regex based subscription (#1279)

2018-02-26 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new ba58a2a PIP-13-2/3: support regex

[GitHub] XiaoZYang commented on a change in pull request #1219: Issue 1069: Provide a setting in consumer configuration to specify where to start consuming messages

2018-02-26 Thread GitBox
XiaoZYang commented on a change in pull request #1219: Issue 1069: Provide a setting in consumer configuration to specify where to start consuming messages URL: https://github.com/apache/incubator-pulsar/pull/1219#discussion_r170821460 ## File path:

[incubator-pulsar] branch master updated: Add a shaded module for pulsar-client-tools (#1294)

2018-02-26 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new fa4493b Add a shaded module for

[GitHub] merlimat closed pull request #1294: Add a shaded module for pulsar-client-tools

2018-02-26 Thread GitBox
merlimat closed pull request #1294: Add a shaded module for pulsar-client-tools URL: https://github.com/apache/incubator-pulsar/pull/1294 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] zhaijack commented on a change in pull request #1279: PIP-13-2/3: support regex based subscription

2018-02-26 Thread GitBox
zhaijack commented on a change in pull request #1279: PIP-13-2/3: support regex based subscription URL: https://github.com/apache/incubator-pulsar/pull/1279#discussion_r170803812 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/api/ConsumerBuilder.java

[GitHub] merlimat commented on a change in pull request #1283: Add prefix setting for C++/Python reader

2018-02-26 Thread GitBox
merlimat commented on a change in pull request #1283: Add prefix setting for C++/Python reader URL: https://github.com/apache/incubator-pulsar/pull/1283#discussion_r170822640 ## File path: pulsar-client-cpp/python/src/config.cc ## @@ -142,5 +142,7 @@ void export_config()

[GitHub] ivankelly opened a new pull request #1285: BatchMessageIdImpl can be compared to MessageIdImpl

2018-02-26 Thread GitBox
ivankelly opened a new pull request #1285: BatchMessageIdImpl can be compared to MessageIdImpl URL: https://github.com/apache/incubator-pulsar/pull/1285 A batch message id is a MessageIdImpl with a batchIndex >= 0. Therefore, they can be compared to MessageIdImpl. If all fields other

[GitHub] mgodave closed pull request #1008: Allow user to specify listener on subscriber or creation of reader

2018-02-26 Thread GitBox
mgodave closed pull request #1008: Allow user to specify listener on subscriber or creation of reader URL: https://github.com/apache/incubator-pulsar/pull/1008 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of