[GitHub] lucperkins opened a new pull request #1378: Standardize on input/output terminology for Pulsar Functions

2018-03-13 Thread GitBox
lucperkins opened a new pull request #1378: Standardize on input/output terminology for Pulsar Functions URL: https://github.com/apache/incubator-pulsar/pull/1378 At the moment, two parallel sets of terminology are in use for Pulsar Functions: source vs. sink and input vs. output. We

[GitHub] merlimat closed pull request #1372: Add byte array to built-in SerDe types for Pulsar Functions

2018-03-13 Thread GitBox
merlimat closed pull request #1372: Add byte array to built-in SerDe types for Pulsar Functions URL: https://github.com/apache/incubator-pulsar/pull/1372 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[incubator-pulsar] branch master updated: add byte array to default pulsar functions serde (#1372)

2018-03-13 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 2f6de57 add byte array to default

[GitHub] srkukarni commented on a change in pull request #1378: Standardize on input/output terminology for Pulsar Functions

2018-03-13 Thread GitBox
srkukarni commented on a change in pull request #1378: Standardize on input/output terminology for Pulsar Functions URL: https://github.com/apache/incubator-pulsar/pull/1378#discussion_r174241958 ## File path: pulsar-functions/instance/src/main/python/contextimpl.py ## @@

[GitHub] lucperkins commented on a change in pull request #1378: Standardize on input/output terminology for Pulsar Functions

2018-03-13 Thread GitBox
lucperkins commented on a change in pull request #1378: Standardize on input/output terminology for Pulsar Functions URL: https://github.com/apache/incubator-pulsar/pull/1378#discussion_r174244167 ## File path: pulsar-functions/instance/src/main/python/contextimpl.py ##

[GitHub] srkukarni commented on issue #1378: Standardize on input/output terminology for Pulsar Functions

2018-03-13 Thread GitBox
srkukarni commented on issue #1378: Standardize on input/output terminology for Pulsar Functions URL: https://github.com/apache/incubator-pulsar/pull/1378#issuecomment-372804418 retest this please This is an automated

[GitHub] sijie opened a new pull request #1374: Update log size limit to 1GB

2018-03-13 Thread GitBox
sijie opened a new pull request #1374: Update log size limit to 1GB URL: https://github.com/apache/incubator-pulsar/pull/1374 ### Motivation Apache BookKeeper enforces log size limit not to be more than 1GB since 4.4.0.

[GitHub] srkukarni commented on a change in pull request #1373: Functions metrics prometheus

2018-03-13 Thread GitBox
srkukarni commented on a change in pull request #1373: Functions metrics prometheus URL: https://github.com/apache/incubator-pulsar/pull/1373#discussion_r174025322 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/prometheus/FunctionsStatsGenerator.java

[GitHub] srkukarni commented on a change in pull request #1373: Functions metrics prometheus

2018-03-13 Thread GitBox
srkukarni commented on a change in pull request #1373: Functions metrics prometheus URL: https://github.com/apache/incubator-pulsar/pull/1373#discussion_r174025115 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/prometheus/FunctionsStatsGenerator.java

[GitHub] srkukarni commented on a change in pull request #1373: Functions metrics prometheus

2018-03-13 Thread GitBox
srkukarni commented on a change in pull request #1373: Functions metrics prometheus URL: https://github.com/apache/incubator-pulsar/pull/1373#discussion_r174025294 ## File path: pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/JavaInstanceMain.java

[GitHub] jerrypeng commented on a change in pull request #1373: Functions metrics prometheus

2018-03-13 Thread GitBox
jerrypeng commented on a change in pull request #1373: Functions metrics prometheus URL: https://github.com/apache/incubator-pulsar/pull/1373#discussion_r174028725 ## File path: pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/JavaInstanceMain.java

[GitHub] jerrypeng commented on a change in pull request #1373: Functions metrics prometheus

2018-03-13 Thread GitBox
jerrypeng commented on a change in pull request #1373: Functions metrics prometheus URL: https://github.com/apache/incubator-pulsar/pull/1373#discussion_r174028587 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/prometheus/FunctionsStatsGenerator.java

[GitHub] jerrypeng commented on a change in pull request #1373: Functions metrics prometheus

2018-03-13 Thread GitBox
jerrypeng commented on a change in pull request #1373: Functions metrics prometheus URL: https://github.com/apache/incubator-pulsar/pull/1373#discussion_r174028725 ## File path: pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/JavaInstanceMain.java

[GitHub] jerrypeng commented on a change in pull request #1373: Functions metrics prometheus

2018-03-13 Thread GitBox
jerrypeng commented on a change in pull request #1373: Functions metrics prometheus URL: https://github.com/apache/incubator-pulsar/pull/1373#discussion_r174031271 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/prometheus/FunctionsStatsGenerator.java

[GitHub] jerrypeng commented on a change in pull request #1373: Functions metrics prometheus

2018-03-13 Thread GitBox
jerrypeng commented on a change in pull request #1373: Functions metrics prometheus URL: https://github.com/apache/incubator-pulsar/pull/1373#discussion_r174028587 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/prometheus/FunctionsStatsGenerator.java

[GitHub] srkukarni opened a new pull request #1375: Moved Python Api to a functions module inside pulsar client python module

2018-03-13 Thread GitBox
srkukarni opened a new pull request #1375: Moved Python Api to a functions module inside pulsar client python module URL: https://github.com/apache/incubator-pulsar/pull/1375 ### Motivation This move enables Python Functions SDK to be shipped alongside regular python client

[GitHub] srkukarni commented on issue #1375: Moved Python Api to a functions module inside pulsar client python module

2018-03-13 Thread GitBox
srkukarni commented on issue #1375: Moved Python Api to a functions module inside pulsar client python module URL: https://github.com/apache/incubator-pulsar/pull/1375#issuecomment-372579546 @sijie @merlimat @jerrypeng This

[GitHub] jerrypeng commented on a change in pull request #1373: Functions metrics prometheus

2018-03-13 Thread GitBox
jerrypeng commented on a change in pull request #1373: Functions metrics prometheus URL: https://github.com/apache/incubator-pulsar/pull/1373#discussion_r174028469 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/prometheus/FunctionsStatsGenerator.java

[GitHub] sijie commented on a change in pull request #1373: Functions metrics prometheus

2018-03-13 Thread GitBox
sijie commented on a change in pull request #1373: Functions metrics prometheus URL: https://github.com/apache/incubator-pulsar/pull/1373#discussion_r174030537 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/prometheus/FunctionsStatsGenerator.java

[GitHub] jerrypeng commented on a change in pull request #1373: Functions metrics prometheus

2018-03-13 Thread GitBox
jerrypeng commented on a change in pull request #1373: Functions metrics prometheus URL: https://github.com/apache/incubator-pulsar/pull/1373#discussion_r174031151 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/prometheus/FunctionsStatsGenerator.java

[GitHub] jerrypeng commented on a change in pull request #1373: Functions metrics prometheus

2018-03-13 Thread GitBox
jerrypeng commented on a change in pull request #1373: Functions metrics prometheus URL: https://github.com/apache/incubator-pulsar/pull/1373#discussion_r174028587 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/prometheus/FunctionsStatsGenerator.java

[GitHub] nkurihar commented on issue #1352: Delete inactive subscriptions automatically

2018-03-13 Thread GitBox
nkurihar commented on issue #1352: Delete inactive subscriptions automatically URL: https://github.com/apache/incubator-pulsar/pull/1352#issuecomment-372565125 @merlimat > I know it's not exactly the same but the effect is very similar to TTL on messages. The aim is the same: to

[GitHub] srkukarni commented on issue #1373: Functions metrics prometheus

2018-03-13 Thread GitBox
srkukarni commented on issue #1373: Functions metrics prometheus URL: https://github.com/apache/incubator-pulsar/pull/1373#issuecomment-372564892 retest this please This is an automated message from the Apache Git Service. To

[GitHub] maskit commented on issue #1266: Pass all Apache Podling Website Checks

2018-03-13 Thread GitBox
maskit commented on issue #1266: Pass all Apache Podling Website Checks URL: https://github.com/apache/incubator-pulsar/issues/1266#issuecomment-372648146 Yay, "Image" row got green. This is an automated message from the

[GitHub] maskit closed pull request #1258: Fix CID 262329

2018-03-13 Thread GitBox
maskit closed pull request #1258: Fix CID 262329 URL: https://github.com/apache/incubator-pulsar/pull/1258 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a

[GitHub] maskit commented on issue #1258: Fix CID 262329

2018-03-13 Thread GitBox
maskit commented on issue #1258: Fix CID 262329 URL: https://github.com/apache/incubator-pulsar/pull/1258#issuecomment-372670442 Huh, finally it passed CI tests. I had to rebase this two times because the base revisions were unstable.

[incubator-pulsar] branch master updated: Fix CID 262329 (#1258)

2018-03-13 Thread maskit
This is an automated email from the ASF dual-hosted git repository. maskit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 4cc20df Fix CID 262329 (#1258)

[GitHub] ivankelly commented on issue #1367: Rest endpoint for triggering compaction

2018-03-13 Thread GitBox
ivankelly commented on issue #1367: Rest endpoint for triggering compaction URL: https://github.com/apache/incubator-pulsar/pull/1367#issuecomment-372713688 retest this please This is an automated message from the Apache Git

[GitHub] ivankelly commented on a change in pull request #1361: Add compactedOut flag for batched messages

2018-03-13 Thread GitBox
ivankelly commented on a change in pull request #1361: Add compactedOut flag for batched messages URL: https://github.com/apache/incubator-pulsar/pull/1361#discussion_r174182400 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java ##

[GitHub] ivankelly commented on issue #1366: Allow override of redirectTestOutput from CLI

2018-03-13 Thread GitBox
ivankelly commented on issue #1366: Allow override of redirectTestOutput from CLI URL: https://github.com/apache/incubator-pulsar/pull/1366#issuecomment-372713820 retest this please This is an automated message from the

[GitHub] jerrypeng commented on issue #1373: Functions metrics prometheus

2018-03-13 Thread GitBox
jerrypeng commented on issue #1373: Functions metrics prometheus URL: https://github.com/apache/incubator-pulsar/pull/1373#issuecomment-372743226 retest This is an automated message from the Apache Git Service. To respond to

[GitHub] jerrypeng commented on issue #1373: Functions metrics prometheus

2018-03-13 Thread GitBox
jerrypeng commented on issue #1373: Functions metrics prometheus URL: https://github.com/apache/incubator-pulsar/pull/1373#issuecomment-372743226 retest This is an automated message from the Apache Git Service. To respond to

[incubator-pulsar] branch master updated: Moved Python Api to a functions module inside pulsar client python module (#1375)

2018-03-13 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 9333202 Moved Python Api to a

[GitHub] merlimat closed pull request #1375: Moved Python Api to a functions module inside pulsar client python module

2018-03-13 Thread GitBox
merlimat closed pull request #1375: Moved Python Api to a functions module inside pulsar client python module URL: https://github.com/apache/incubator-pulsar/pull/1375 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[GitHub] sijie commented on issue #1372: Add byte array to built-in SerDe types for Pulsar Functions

2018-03-13 Thread GitBox
sijie commented on issue #1372: Add byte array to built-in SerDe types for Pulsar Functions URL: https://github.com/apache/incubator-pulsar/pull/1372#issuecomment-372738725 retest this please This is an automated message

[GitHub] sijie commented on issue #1373: Functions metrics prometheus

2018-03-13 Thread GitBox
sijie commented on issue #1373: Functions metrics prometheus URL: https://github.com/apache/incubator-pulsar/pull/1373#issuecomment-372738866 retest this please This is an automated message from the Apache Git Service. To

[GitHub] merlimat opened a new pull request #1379: Fixed BK PrometheusProvider package name

2018-03-13 Thread GitBox
merlimat opened a new pull request #1379: Fixed BK PrometheusProvider package name URL: https://github.com/apache/incubator-pulsar/pull/1379 ### Motivation `PrometheusProvider` package name was changed in BookKeeper 4.7. We need to adjust the default in config file.

[GitHub] jerrypeng commented on issue #1373: Functions metrics prometheus

2018-03-13 Thread GitBox
jerrypeng commented on issue #1373: Functions metrics prometheus URL: https://github.com/apache/incubator-pulsar/pull/1373#issuecomment-372850315 @srkukarni @sijie @merlimat can you review the PR again. I refactored as per our discussion

[incubator-pulsar] branch master updated: Fix partitioned topic update for admin v2 api. (#1376)

2018-03-13 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new e7e340c Fix partitioned topic update

[GitHub] srkukarni commented on issue #1378: Standardize on input/output terminology for Pulsar Functions

2018-03-13 Thread GitBox
srkukarni commented on issue #1378: Standardize on input/output terminology for Pulsar Functions URL: https://github.com/apache/incubator-pulsar/pull/1378#issuecomment-372827950 retest this please This is an automated

[GitHub] merlimat closed pull request #1376: Fix partitioned topic update for admin v2 api.

2018-03-13 Thread GitBox
merlimat closed pull request #1376: Fix partitioned topic update for admin v2 api. URL: https://github.com/apache/incubator-pulsar/pull/1376 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] sijie closed pull request #1377: Renamed PulsarFunction to plain Function

2018-03-13 Thread GitBox
sijie closed pull request #1377: Renamed PulsarFunction to plain Function URL: https://github.com/apache/incubator-pulsar/pull/1377 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[incubator-pulsar] branch master updated: Renamed PulsarFunction to plain Function (#1377)

2018-03-13 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 381ccc0 Renamed PulsarFunction to

[GitHub] lucperkins commented on issue #1291: Streamline Ansible setup

2018-03-13 Thread GitBox
lucperkins commented on issue #1291: Streamline Ansible setup URL: https://github.com/apache/incubator-pulsar/pull/1291#issuecomment-372757079 retest this please This is an automated message from the Apache Git Service. To

[GitHub] cckellogg opened a new pull request #1376: Fix partitioned topic update for admin v2 api.

2018-03-13 Thread GitBox
cckellogg opened a new pull request #1376: Fix partitioned topic update for admin v2 api. URL: https://github.com/apache/incubator-pulsar/pull/1376 Fix partitioned topic update for the admin rest api v2. This also adds a helper class to create zk paths for pulsar objects.

[GitHub] merlimat closed pull request #1366: Allow override of redirectTestOutput from CLI

2018-03-13 Thread GitBox
merlimat closed pull request #1366: Allow override of redirectTestOutput from CLI URL: https://github.com/apache/incubator-pulsar/pull/1366 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[incubator-pulsar] branch master updated: Allow override of redirectTestOutput from CLI (#1366)

2018-03-13 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new e5aebce Allow override of

[GitHub] merlimat closed pull request #1374: Update log size limit to 1GB

2018-03-13 Thread GitBox
merlimat closed pull request #1374: Update log size limit to 1GB URL: https://github.com/apache/incubator-pulsar/pull/1374 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[incubator-pulsar] branch master updated: Update log size limit to 1GB (#1374)

2018-03-13 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 55d3ff0 Update log size limit to 1GB

[GitHub] srkukarni opened a new pull request #1377: Renamed PulsarFunction to plain Function

2018-03-13 Thread GitBox
srkukarni opened a new pull request #1377: Renamed PulsarFunction to plain Function URL: https://github.com/apache/incubator-pulsar/pull/1377 ### Motivation This is not just simpler, but also matches the python interface ### Modifications Describe the modifications

[GitHub] srkukarni commented on issue #1377: Renamed PulsarFunction to plain Function

2018-03-13 Thread GitBox
srkukarni commented on issue #1377: Renamed PulsarFunction to plain Function URL: https://github.com/apache/incubator-pulsar/pull/1377#issuecomment-372754087 @sijie @merlimat @jerrypeng This is an automated message from the

[GitHub] XiaoZYang commented on issue #1219: Issue 1069: Provide a setting in consumer configuration to specify where to start consuming messages

2018-03-13 Thread GitBox
XiaoZYang commented on issue #1219: Issue 1069: Provide a setting in consumer configuration to specify where to start consuming messages URL: https://github.com/apache/incubator-pulsar/pull/1219#issuecomment-372883687 @zhaijack @merlimat please review this change

[GitHub] yush1ga opened a new pull request #1380: Refactor REST API for namespace policy

2018-03-13 Thread GitBox
yush1ga opened a new pull request #1380: Refactor REST API for namespace policy URL: https://github.com/apache/incubator-pulsar/pull/1380 ### Motivation #1317 ### Modifications Added common REST API to set/get some namespace policy properties. ### Result We can

[GitHub] merlimat commented on issue #1379: Fixed BK PrometheusProvider package name

2018-03-13 Thread GitBox
merlimat commented on issue #1379: Fixed BK PrometheusProvider package name URL: https://github.com/apache/incubator-pulsar/pull/1379#issuecomment-372879154 retest this please This is an automated message from the Apache Git

[GitHub] jerrypeng commented on issue #1373: Functions metrics prometheus

2018-03-13 Thread GitBox
jerrypeng commented on issue #1373: Functions metrics prometheus URL: https://github.com/apache/incubator-pulsar/pull/1373#issuecomment-372862717 @srkukarni I have added the instance liveness check This is an automated

[GitHub] srkukarni commented on a change in pull request #1373: Functions metrics prometheus

2018-03-13 Thread GitBox
srkukarni commented on a change in pull request #1373: Functions metrics prometheus URL: https://github.com/apache/incubator-pulsar/pull/1373#discussion_r174323358 ## File path: pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/RuntimeSpawner.java

[GitHub] srkukarni commented on issue #1373: Functions metrics prometheus

2018-03-13 Thread GitBox
srkukarni commented on issue #1373: Functions metrics prometheus URL: https://github.com/apache/incubator-pulsar/pull/1373#issuecomment-372863391 looks good This is an automated message from the Apache Git Service. To respond

[GitHub] srkukarni commented on issue #1378: Standardize on input/output terminology for Pulsar Functions

2018-03-13 Thread GitBox
srkukarni commented on issue #1378: Standardize on input/output terminology for Pulsar Functions URL: https://github.com/apache/incubator-pulsar/pull/1378#issuecomment-372865828 retest this please This is an automated