[GitHub] jai1 commented on issue #1453: Added Throttling mechanism to Pulsar Proxy

2018-03-27 Thread GitBox
jai1 commented on issue #1453: Added Throttling mechanism to Pulsar Proxy URL: https://github.com/apache/incubator-pulsar/pull/1453#issuecomment-376429323 retest this please This is an automated message from the Apache Git

[GitHub] jai1 commented on issue #1454: Check if request is HTTPs before redirecting to TLS URL

2018-03-27 Thread GitBox
jai1 commented on issue #1454: Check if request is HTTPs before redirecting to TLS URL URL: https://github.com/apache/incubator-pulsar/pull/1454#issuecomment-376429271 retest this please This is an automated message from the

[GitHub] jai1 commented on issue #1453: Added Throttling mechanism to Pulsar Proxy

2018-03-27 Thread GitBox
jai1 commented on issue #1453: Added Throttling mechanism to Pulsar Proxy URL: https://github.com/apache/incubator-pulsar/pull/1453#issuecomment-376408530 retest this test This is an automated message from the Apache Git

[GitHub] jai1 commented on issue #1453: Added Throttling mechanism to Pulsar Proxy

2018-03-27 Thread GitBox
jai1 commented on issue #1453: Added Throttling mechanism to Pulsar Proxy URL: https://github.com/apache/incubator-pulsar/pull/1453#issuecomment-376408530 retest this please This is an automated message from the Apache Git

[GitHub] jai1 commented on issue #1297: Add Configuration to set tlsClientAuth

2018-03-27 Thread GitBox
jai1 commented on issue #1297: Add Configuration to set tlsClientAuth URL: https://github.com/apache/incubator-pulsar/pull/1297#issuecomment-376410187 retest this please This is an automated message from the Apache Git

[GitHub] jai1 opened a new pull request #1454: Check if request is HTTPs before redirecting to TLS URL

2018-03-27 Thread GitBox
jai1 opened a new pull request #1454: Check if request is HTTPs before redirecting to TLS URL URL: https://github.com/apache/incubator-pulsar/pull/1454 Code review bug: While deciding whether to return the `serviceUrl` or `serviceUrlTls` of a replication cluster we should check whether

[GitHub] jai1 commented on issue #1453: Added Throttling mechanism to Pulsar Proxy

2018-03-27 Thread GitBox
jai1 commented on issue #1453: Added Throttling mechanism to Pulsar Proxy URL: https://github.com/apache/incubator-pulsar/pull/1453#issuecomment-376408746 retest this please This is an automated message from the Apache Git

[GitHub] jai1 commented on issue #1449: When running standalone broker, force the proxy redirection flag

2018-03-27 Thread GitBox
jai1 commented on issue #1449: When running standalone broker, force the proxy redirection flag URL: https://github.com/apache/incubator-pulsar/pull/1449#issuecomment-376409600 In this approach - by default, we can't create a small test cluster of standalone brokers.

[GitHub] zhaijack commented on issue #1452: reachedEndOfTopic is called twice if a topic has been terminated before subscription

2018-03-27 Thread GitBox
zhaijack commented on issue #1452: reachedEndOfTopic is called twice if a topic has been terminated before subscription URL: https://github.com/apache/incubator-pulsar/issues/1452#issuecomment-376527587 looked into the code. Seems the 2 calling happens like this: 1st call happened when

[GitHub] merlimat commented on issue #1431: Additional checks for Pulsar Function jar submission

2018-03-27 Thread GitBox
merlimat commented on issue #1431: Additional checks for Pulsar Function jar submission URL: https://github.com/apache/incubator-pulsar/pull/1431#issuecomment-376704035 @lucperkins There are failures in the tests: https://builds.apache.org/job/pulsar_precommit_java8/71/

[GitHub] sijie commented on issue #1424: Improve batch message acking by removing batch message tracker

2018-03-27 Thread GitBox
sijie commented on issue #1424: Improve batch message acking by removing batch message tracker URL: https://github.com/apache/incubator-pulsar/pull/1424#issuecomment-376768448 @merlimat the problem is on getting batch size. fixed it at 42fa9e0

[GitHub] sijie commented on issue #1181: Multi-topic subscription documentation

2018-03-27 Thread GitBox
sijie commented on issue #1181: Multi-topic subscription documentation URL: https://github.com/apache/incubator-pulsar/pull/1181#issuecomment-376761878 @lucperkins any updates? This is an automated message from the Apache Git

[GitHub] sijie commented on a change in pull request #1461: If cursor update to BK fails, fallback to meta store

2018-03-27 Thread GitBox
sijie commented on a change in pull request #1461: If cursor update to BK fails, fallback to meta store URL: https://github.com/apache/incubator-pulsar/pull/1461#discussion_r177634349 ## File path:

[GitHub] sijie commented on a change in pull request #1461: If cursor update to BK fails, fallback to meta store

2018-03-27 Thread GitBox
sijie commented on a change in pull request #1461: If cursor update to BK fails, fallback to meta store URL: https://github.com/apache/incubator-pulsar/pull/1461#discussion_r177638796 ## File path:

[GitHub] merlimat closed pull request #1441: Update the bookkeeper configuration file

2018-03-27 Thread GitBox
merlimat closed pull request #1441: Update the bookkeeper configuration file URL: https://github.com/apache/incubator-pulsar/pull/1441 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[incubator-pulsar] branch master updated: Update the bookkeeper configuration file (#1441)

2018-03-27 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 8ffd011 Update the bookkeeper

[GitHub] merlimat closed pull request #1445: Add version warning for latest vs. 2.0

2018-03-27 Thread GitBox
merlimat closed pull request #1445: Add version warning for latest vs. 2.0 URL: https://github.com/apache/incubator-pulsar/pull/1445 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] merlimat closed pull request #1418: Handle null redirection url with error-message at broker

2018-03-27 Thread GitBox
merlimat closed pull request #1418: Handle null redirection url with error-message at broker URL: https://github.com/apache/incubator-pulsar/pull/1418 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[incubator-pulsar] branch master updated: Replace cached data key from the map if present already (#1417)

2018-03-27 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 16b448f Replace cached data key from

[GitHub] merlimat closed pull request #1417: Replace cached data key from the map if present already

2018-03-27 Thread GitBox
merlimat closed pull request #1417: Replace cached data key from the map if present already URL: https://github.com/apache/incubator-pulsar/pull/1417 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] merlimat opened a new pull request #1461: If cursor update to BK fails, fallback to meta store

2018-03-27 Thread GitBox
merlimat opened a new pull request #1461: If cursor update to BK fails, fallback to meta store URL: https://github.com/apache/incubator-pulsar/pull/1461 ### Motivation If writes to BK are failing we cannot update the cursor. If the writes are failing because the disk is full, we

[GitHub] merlimat closed pull request #1410: Convert admin client properties to use v2 endpoints.

2018-03-27 Thread GitBox
merlimat closed pull request #1410: Convert admin client properties to use v2 endpoints. URL: https://github.com/apache/incubator-pulsar/pull/1410 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[incubator-pulsar] branch master updated: Convert admin client properties to use v2 endpoints. (#1410)

2018-03-27 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 5bd13a0 Convert admin client

[GitHub] merlimat commented on issue #1427: Add batching support to compaction

2018-03-27 Thread GitBox
merlimat commented on issue #1427: Add batching support to compaction URL: https://github.com/apache/incubator-pulsar/pull/1427#issuecomment-376703657 retest this please This is an automated message from the Apache Git

[GitHub] merlimat commented on issue #1424: Improve batch message acking by removing batch message tracker

2018-03-27 Thread GitBox
merlimat commented on issue #1424: Improve batch message acking by removing batch message tracker URL: https://github.com/apache/incubator-pulsar/pull/1424#issuecomment-376703499 @sijie I think there might be a legitimate test failure:

[GitHub] jai1 commented on issue #1297: Add Configuration to set tlsClientAuth

2018-03-27 Thread GitBox
jai1 commented on issue #1297: Add Configuration to set tlsClientAuth URL: https://github.com/apache/incubator-pulsar/pull/1297#issuecomment-376703491 @merlimat - can you please review this when you get time. This is an

[GitHub] merlimat closed pull request #1427: Add batching support to compaction

2018-03-27 Thread GitBox
merlimat closed pull request #1427: Add batching support to compaction URL: https://github.com/apache/incubator-pulsar/pull/1427 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] merlimat closed pull request #1449: When running standalone broker, force the proxy redirection flag

2018-03-27 Thread GitBox
merlimat closed pull request #1449: When running standalone broker, force the proxy redirection flag URL: https://github.com/apache/incubator-pulsar/pull/1449 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] merlimat closed issue #1152: Change default pulsar stanalone behavior

2018-03-27 Thread GitBox
merlimat closed issue #1152: Change default pulsar stanalone behavior URL: https://github.com/apache/incubator-pulsar/issues/1152 This is an automated message from the Apache Git Service. To respond to the message, please

[incubator-pulsar] branch master updated: Add batching support to compaction (#1427)

2018-03-27 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new ba855c3 Add batching support to

[incubator-pulsar] branch master updated: When running standalone broker, force the proxy redirection flag (#1449)

2018-03-27 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 8f6e33d When running standalone

[GitHub] zhaijack commented on a change in pull request #1181: Multi-topic subscription documentation

2018-03-27 Thread GitBox
zhaijack commented on a change in pull request #1181: Multi-topic subscription documentation URL: https://github.com/apache/incubator-pulsar/pull/1181#discussion_r177619791 ## File path: site/docs/latest/getting-started/ConceptsAndArchitecture.md ## @@ -146,6 +146,43 @@

[GitHub] zhaijack commented on a change in pull request #1181: Multi-topic subscription documentation

2018-03-27 Thread GitBox
zhaijack commented on a change in pull request #1181: Multi-topic subscription documentation URL: https://github.com/apache/incubator-pulsar/pull/1181#discussion_r177619817 ## File path: site/docs/latest/getting-started/ConceptsAndArchitecture.md ## @@ -146,6 +146,43 @@

[GitHub] jai1 commented on issue #1453: Added Throttling mechanism to Pulsar Proxy

2018-03-27 Thread GitBox
jai1 commented on issue #1453: Added Throttling mechanism to Pulsar Proxy URL: https://github.com/apache/incubator-pulsar/pull/1453#issuecomment-376732348 retest this please This is an automated message from the Apache Git

[GitHub] sijie opened a new issue #1459: unsubscribe doesn't work if bookkeeper is outage

2018-03-27 Thread GitBox
sijie opened a new issue #1459: unsubscribe doesn't work if bookkeeper is outage URL: https://github.com/apache/incubator-pulsar/issues/1459 Expected behavior if bookkeeper is outage due to disk fillup, admins want to unsubscribe a subscription to clear backlog. the unsubscribe

[incubator-pulsar] branch master updated: Add version warning for latest vs. 2.0 (#1445)

2018-03-27 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new bb6daa2 Add version warning for

[GitHub] merlimat closed issue #472: Some Commands are missing in binary protocol specification

2018-03-27 Thread GitBox
merlimat closed issue #472: Some Commands are missing in binary protocol specification URL: https://github.com/apache/incubator-pulsar/issues/472 This is an automated message from the Apache Git Service. To respond to the

[GitHub] jai1 commented on issue #1450: Added multiple position delete in ManagedLedger

2018-03-27 Thread GitBox
jai1 commented on issue #1450: Added multiple position delete in ManagedLedger URL: https://github.com/apache/incubator-pulsar/pull/1450#issuecomment-376714183 retest this please This is an automated message from the Apache

[GitHub] zhaijack commented on a change in pull request #1181: Multi-topic subscription documentation

2018-03-27 Thread GitBox
zhaijack commented on a change in pull request #1181: Multi-topic subscription documentation URL: https://github.com/apache/incubator-pulsar/pull/1181#discussion_r177619392 ## File path: site/docs/latest/clients/Java.md ## @@ -213,7 +218,69 @@ Here's an example:

[GitHub] merlimat commented on issue #1449: When running standalone broker, force the proxy redirection flag

2018-03-27 Thread GitBox
merlimat commented on issue #1449: When running standalone broker, force the proxy redirection flag URL: https://github.com/apache/incubator-pulsar/pull/1449#issuecomment-376592357 retest this please This is an automated

[GitHub] merlimat closed pull request #1297: Add Configuration to set tlsClientAuth

2018-03-27 Thread GitBox
merlimat closed pull request #1297: Add Configuration to set tlsClientAuth URL: https://github.com/apache/incubator-pulsar/pull/1297 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[incubator-pulsar] branch master updated: Add Configuration to set tlsClientAuth (#1297)

2018-03-27 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new ffd6f21 Add Configuration to set

[GitHub] lucperkins commented on issue #472: Some Commands are missing in binary protocol specification

2018-03-27 Thread GitBox
lucperkins commented on issue #472: Some Commands are missing in binary protocol specification URL: https://github.com/apache/incubator-pulsar/issues/472#issuecomment-376696084 The Protobuf API is now comprehensively documented (and always up to date) here:

[GitHub] jai1 commented on issue #1453: Added Throttling mechanism to Pulsar Proxy

2018-03-27 Thread GitBox
jai1 commented on issue #1453: Added Throttling mechanism to Pulsar Proxy URL: https://github.com/apache/incubator-pulsar/pull/1453#issuecomment-376720541 retest this please This is an automated message from the Apache Git

[GitHub] merlimat commented on issue #1449: When running standalone broker, force the proxy redirection flag

2018-03-27 Thread GitBox
merlimat commented on issue #1449: When running standalone broker, force the proxy redirection flag URL: https://github.com/apache/incubator-pulsar/pull/1449#issuecomment-376703852 retest this please This is an automated

[GitHub] merlimat commented on issue #1427: Add batching support to compaction

2018-03-27 Thread GitBox
merlimat commented on issue #1427: Add batching support to compaction URL: https://github.com/apache/incubator-pulsar/pull/1427#issuecomment-376703657 retest this please This is an automated message from the Apache Git

[GitHub] merlimat commented on issue #1449: When running standalone broker, force the proxy redirection flag

2018-03-27 Thread GitBox
merlimat commented on issue #1449: When running standalone broker, force the proxy redirection flag URL: https://github.com/apache/incubator-pulsar/pull/1449#issuecomment-376703852 retest this please This is an automated

[GitHub] merlimat commented on issue #1450: Added multiple position delete in ManagedLedger

2018-03-27 Thread GitBox
merlimat commented on issue #1450: Added multiple position delete in ManagedLedger URL: https://github.com/apache/incubator-pulsar/pull/1450#issuecomment-376729667 retest this please This is an automated message from the

[GitHub] merlimat commented on issue #1450: Added multiple position delete in ManagedLedger

2018-03-27 Thread GitBox
merlimat commented on issue #1450: Added multiple position delete in ManagedLedger URL: https://github.com/apache/incubator-pulsar/pull/1450#issuecomment-376729667 retest this please This is an automated message from the

[GitHub] sijie commented on issue #1458: skip-all/clear-backlog doesn't work if bookkeeper is outage

2018-03-27 Thread GitBox
sijie commented on issue #1458: skip-all/clear-backlog doesn't work if bookkeeper is outage URL: https://github.com/apache/incubator-pulsar/issues/1458#issuecomment-376734934 from @merlimat : "for the clear backlog. there is a very easy fix. If the cursor update fail on BK, we can

[GitHub] sijie opened a new issue #1458: skip-all/clear-backlog doesn't work if bookkeeper is outage

2018-03-27 Thread GitBox
sijie opened a new issue #1458: skip-all/clear-backlog doesn't work if bookkeeper is outage URL: https://github.com/apache/incubator-pulsar/issues/1458 Expected behavior skip-all/clear-backlog should work if bookkeeper is outage due to backlog Actual behavior

[GitHub] sijie commented on issue #1424: Improve batch message acking by removing batch message tracker

2018-03-27 Thread GitBox
sijie commented on issue #1424: Improve batch message acking by removing batch message tracker URL: https://github.com/apache/incubator-pulsar/pull/1424#issuecomment-376738349 @merlimat will take a look This is an automated

[GitHub] jai1 closed pull request #1318: Added localhost as default advertised address in standalone.conf

2018-03-27 Thread GitBox
jai1 closed pull request #1318: Added localhost as default advertised address in standalone.conf URL: https://github.com/apache/incubator-pulsar/pull/1318 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] zhaijack commented on a change in pull request #1181: Multi-topic subscription documentation

2018-03-27 Thread GitBox
zhaijack commented on a change in pull request #1181: Multi-topic subscription documentation URL: https://github.com/apache/incubator-pulsar/pull/1181#discussion_r177619661 ## File path: site/docs/latest/getting-started/ConceptsAndArchitecture.md ## @@ -146,6 +146,43 @@

[GitHub] zhaijack commented on a change in pull request #1181: Multi-topic subscription documentation

2018-03-27 Thread GitBox
zhaijack commented on a change in pull request #1181: Multi-topic subscription documentation URL: https://github.com/apache/incubator-pulsar/pull/1181#discussion_r177619392 ## File path: site/docs/latest/clients/Java.md ## @@ -213,7 +218,69 @@ Here's an example:

[GitHub] zhaijack commented on a change in pull request #1181: Multi-topic subscription documentation

2018-03-27 Thread GitBox
zhaijack commented on a change in pull request #1181: Multi-topic subscription documentation URL: https://github.com/apache/incubator-pulsar/pull/1181#discussion_r177619702 ## File path: site/docs/latest/clients/Java.md ## @@ -213,7 +218,69 @@ Here's an example:

[GitHub] zubchenok opened a new issue #1455: MessageID has always batch index 0 when sending messages in a batch

2018-03-27 Thread GitBox
zubchenok opened a new issue #1455: MessageID has always batch index 0 when sending messages in a batch URL: https://github.com/apache/incubator-pulsar/issues/1455 When I send messages I always get 0 in batchIndex component of MessageID. Here is a unit test that reproduce the issue: `

[GitHub] merlimat commented on issue #1445: Add version warning for latest vs. 2.0

2018-03-27 Thread GitBox
merlimat commented on issue #1445: Add version warning for latest vs. 2.0 URL: https://github.com/apache/incubator-pulsar/pull/1445#issuecomment-376583890 @lucperkins `version-warning.html` is missing the license header This

[GitHub] merlimat commented on issue #1410: Convert admin client properties to use v2 endpoints.

2018-03-27 Thread GitBox
merlimat commented on issue #1410: Convert admin client properties to use v2 endpoints. URL: https://github.com/apache/incubator-pulsar/pull/1410#issuecomment-376584080 retest this please This is an automated message from

[GitHub] merlimat commented on issue #1410: Convert admin client properties to use v2 endpoints.

2018-03-27 Thread GitBox
merlimat commented on issue #1410: Convert admin client properties to use v2 endpoints. URL: https://github.com/apache/incubator-pulsar/pull/1410#issuecomment-376584080 retest this please This is an automated message from

[GitHub] merlimat commented on issue #1410: Convert admin client properties to use v2 endpoints.

2018-03-27 Thread GitBox
merlimat commented on issue #1410: Convert admin client properties to use v2 endpoints. URL: https://github.com/apache/incubator-pulsar/pull/1410#issuecomment-376396644 retest this please This is an automated message from

[GitHub] merlimat commented on issue #1451: Fix: NPE on http-lookup redirection

2018-03-27 Thread GitBox
merlimat commented on issue #1451: Fix: NPE on http-lookup redirection URL: https://github.com/apache/incubator-pulsar/pull/1451#issuecomment-376583303 retest this please This is an automated message from the Apache Git

[GitHub] merlimat commented on issue #1451: Fix: NPE on http-lookup redirection

2018-03-27 Thread GitBox
merlimat commented on issue #1451: Fix: NPE on http-lookup redirection URL: https://github.com/apache/incubator-pulsar/pull/1451#issuecomment-376583303 retest this please This is an automated message from the Apache Git

[incubator-pulsar] branch master updated: Fix: NPE on http-lookup redirection (#1451)

2018-03-27 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 4bf44d9 Fix: NPE on http-lookup

[GitHub] merlimat closed pull request #1451: Fix: NPE on http-lookup redirection

2018-03-27 Thread GitBox
merlimat closed pull request #1451: Fix: NPE on http-lookup redirection URL: https://github.com/apache/incubator-pulsar/pull/1451 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] sijie commented on a change in pull request #1447: Send Log statements to log Topic for Java Functions

2018-03-27 Thread GitBox
sijie commented on a change in pull request #1447: Send Log statements to log Topic for Java Functions URL: https://github.com/apache/incubator-pulsar/pull/1447#discussion_r177508262 ## File path:

[GitHub] jai1 commented on issue #1454: Check if request is HTTPs before redirecting to TLS URL

2018-03-27 Thread GitBox
jai1 commented on issue #1454: Check if request is HTTPs before redirecting to TLS URL URL: https://github.com/apache/incubator-pulsar/pull/1454#issuecomment-376613151 retest this please This is an automated message from the

[GitHub] merlimat commented on issue #1451: Fix: NPE on http-lookup redirection

2018-03-27 Thread GitBox
merlimat commented on issue #1451: Fix: NPE on http-lookup redirection URL: https://github.com/apache/incubator-pulsar/pull/1451#issuecomment-376580716 retest this please This is an automated message from the Apache Git

[GitHub] merlimat commented on issue #1451: Fix: NPE on http-lookup redirection

2018-03-27 Thread GitBox
merlimat commented on issue #1451: Fix: NPE on http-lookup redirection URL: https://github.com/apache/incubator-pulsar/pull/1451#issuecomment-376580716 retest this please This is an automated message from the Apache Git

[GitHub] merlimat commented on issue #1451: Fix: NPE on http-lookup redirection

2018-03-27 Thread GitBox
merlimat commented on issue #1451: Fix: NPE on http-lookup redirection URL: https://github.com/apache/incubator-pulsar/pull/1451#issuecomment-376592422 retest this please This is an automated message from the Apache Git

[GitHub] merlimat commented on issue #1450: Added multiple position delete in ManagedLedger

2018-03-27 Thread GitBox
merlimat commented on issue #1450: Added multiple position delete in ManagedLedger URL: https://github.com/apache/incubator-pulsar/pull/1450#issuecomment-376599758 retest this please This is an automated message from the

[GitHub] merlimat commented on issue #1450: Added multiple position delete in ManagedLedger

2018-03-27 Thread GitBox
merlimat commented on issue #1450: Added multiple position delete in ManagedLedger URL: https://github.com/apache/incubator-pulsar/pull/1450#issuecomment-376599758 retest this please This is an automated message from the

[GitHub] merlimat commented on issue #1451: Fix: NPE on http-lookup redirection

2018-03-27 Thread GitBox
merlimat commented on issue #1451: Fix: NPE on http-lookup redirection URL: https://github.com/apache/incubator-pulsar/pull/1451#issuecomment-376592422 retest this please This is an automated message from the Apache Git

[GitHub] merlimat commented on issue #1449: When running standalone broker, force the proxy redirection flag

2018-03-27 Thread GitBox
merlimat commented on issue #1449: When running standalone broker, force the proxy redirection flag URL: https://github.com/apache/incubator-pulsar/pull/1449#issuecomment-376592357 retest this please This is an automated

[GitHub] srkukarni commented on a change in pull request #1447: Send Log statements to log Topic for Java Functions

2018-03-27 Thread GitBox
srkukarni commented on a change in pull request #1447: Send Log statements to log Topic for Java Functions URL: https://github.com/apache/incubator-pulsar/pull/1447#discussion_r177503258 ## File path:

[GitHub] merlimat commented on a change in pull request #1454: Check if request is HTTPs before redirecting to TLS URL

2018-03-27 Thread GitBox
merlimat commented on a change in pull request #1454: Check if request is HTTPs before redirecting to TLS URL URL: https://github.com/apache/incubator-pulsar/pull/1454#discussion_r177531386 ## File path:

[GitHub] merlimat commented on issue #1428: Issue #1117: handle race in concurrent bundle split

2018-03-27 Thread GitBox
merlimat commented on issue #1428: Issue #1117: handle race in concurrent bundle split URL: https://github.com/apache/incubator-pulsar/pull/1428#issuecomment-376643718 retest this please This is an automated message from

[GitHub] merlimat commented on issue #1428: Issue #1117: handle race in concurrent bundle split

2018-03-27 Thread GitBox
merlimat commented on issue #1428: Issue #1117: handle race in concurrent bundle split URL: https://github.com/apache/incubator-pulsar/pull/1428#issuecomment-376643718 retest this please This is an automated message from

[GitHub] merlimat commented on issue #1424: Improve batch message acking by removing batch message tracker

2018-03-27 Thread GitBox
merlimat commented on issue #1424: Improve batch message acking by removing batch message tracker URL: https://github.com/apache/incubator-pulsar/pull/1424#issuecomment-376625693 retest this please This is an automated

[GitHub] merlimat commented on issue #1424: Improve batch message acking by removing batch message tracker

2018-03-27 Thread GitBox
merlimat commented on issue #1424: Improve batch message acking by removing batch message tracker URL: https://github.com/apache/incubator-pulsar/pull/1424#issuecomment-376625693 retest this please This is an automated

[GitHub] sijie closed pull request #1447: Send Log statements to log Topic for Java Functions

2018-03-27 Thread GitBox
sijie closed pull request #1447: Send Log statements to log Topic for Java Functions URL: https://github.com/apache/incubator-pulsar/pull/1447 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[incubator-pulsar] branch master updated: Send Log statements to log Topic for Java Functions (#1447)

2018-03-27 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 86b9546 Send Log statements to log

[GitHub] jai1 commented on issue #1453: Added Throttling mechanism to Pulsar Proxy

2018-03-27 Thread GitBox
jai1 commented on issue #1453: Added Throttling mechanism to Pulsar Proxy URL: https://github.com/apache/incubator-pulsar/pull/1453#issuecomment-376618145 retest this please This is an automated message from the Apache Git

[GitHub] lucperkins commented on issue #1362: More Pulsar Functions documentation

2018-03-27 Thread GitBox
lucperkins commented on issue #1362: More Pulsar Functions documentation URL: https://github.com/apache/incubator-pulsar/pull/1362#issuecomment-376668030 retest this please This is an automated message from the Apache Git

[GitHub] saandrews commented on issue #1417: Replace cached data key from the map if present already

2018-03-27 Thread GitBox
saandrews commented on issue #1417: Replace cached data key from the map if present already URL: https://github.com/apache/incubator-pulsar/pull/1417#issuecomment-376670241 retest this please This is an automated message

[GitHub] lucperkins commented on issue #1362: More Pulsar Functions documentation

2018-03-27 Thread GitBox
lucperkins commented on issue #1362: More Pulsar Functions documentation URL: https://github.com/apache/incubator-pulsar/pull/1362#issuecomment-376649644 retest this please This is an automated message from the Apache Git

[GitHub] merlimat commented on issue #1418: Handle null redirection url with error-message at broker

2018-03-27 Thread GitBox
merlimat commented on issue #1418: Handle null redirection url with error-message at broker URL: https://github.com/apache/incubator-pulsar/pull/1418#issuecomment-376684161 @rdhabalia Can your rebase or merge master to get the fix for the flaky test?

[GitHub] jai1 commented on issue #1453: Added Throttling mechanism to Pulsar Proxy

2018-03-27 Thread GitBox
jai1 commented on issue #1453: Added Throttling mechanism to Pulsar Proxy URL: https://github.com/apache/incubator-pulsar/pull/1453#issuecomment-376688402 @merlimat @rdhabalia - can you please review this This is an automated

[GitHub] lucperkins opened a new pull request #1457: Schema registry documentation (WIP)

2018-03-27 Thread GitBox
lucperkins opened a new pull request #1457: Schema registry documentation (WIP) URL: https://github.com/apache/incubator-pulsar/pull/1457 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] merlimat closed issue #1117: Exception during namespace bundle split

2018-03-27 Thread GitBox
merlimat closed issue #1117: Exception during namespace bundle split URL: https://github.com/apache/incubator-pulsar/issues/1117 This is an automated message from the Apache Git Service. To respond to the message, please log

[incubator-pulsar] branch master updated: Check if request is HTTPs before redirecting to TLS URL (#1454)

2018-03-27 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 527731c Check if request is HTTPs

[GitHub] merlimat closed pull request #1454: Check if request is HTTPs before redirecting to TLS URL

2018-03-27 Thread GitBox
merlimat closed pull request #1454: Check if request is HTTPs before redirecting to TLS URL URL: https://github.com/apache/incubator-pulsar/pull/1454 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] merlimat closed pull request #1428: Issue #1117: handle race in concurrent bundle split

2018-03-27 Thread GitBox
merlimat closed pull request #1428: Issue #1117: handle race in concurrent bundle split URL: https://github.com/apache/incubator-pulsar/pull/1428 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[incubator-pulsar] branch master updated: Issue #1117: handle race in concurrent bundle split (#1428)

2018-03-27 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new ea39148 Issue #1117: handle race in

[GitHub] merlimat commented on issue #1441: Update the bookkeeper configuration file

2018-03-27 Thread GitBox
merlimat commented on issue #1441: Update the bookkeeper configuration file URL: https://github.com/apache/incubator-pulsar/pull/1441#issuecomment-376680888 retest this please This is an automated message from the Apache Git

[GitHub] merlimat commented on issue #1410: Convert admin client properties to use v2 endpoints.

2018-03-27 Thread GitBox
merlimat commented on issue #1410: Convert admin client properties to use v2 endpoints. URL: https://github.com/apache/incubator-pulsar/pull/1410#issuecomment-376682215 retest this please This is an automated message from

[GitHub] merlimat commented on issue #1410: Convert admin client properties to use v2 endpoints.

2018-03-27 Thread GitBox
merlimat commented on issue #1410: Convert admin client properties to use v2 endpoints. URL: https://github.com/apache/incubator-pulsar/pull/1410#issuecomment-376682215 retest this please This is an automated message from

[GitHub] sijie opened a new issue #1456: `bin/pulsar-admin persistent stats` doesn't work if there is no enough bookies available

2018-03-27 Thread GitBox
sijie opened a new issue #1456: `bin/pulsar-admin persistent stats` doesn't work if there is no enough bookies available URL: https://github.com/apache/incubator-pulsar/issues/1456 Expected behavior `bin/pulsar-admin persistent stats` and `bin/pulsar-admin persistent