[GitHub] srkukarni commented on a change in pull request #2397: Integrate Functions with Schema

srkukarni commented on a change in pull request #2397: Integrate Functions with Schema URL: https://github.com/apache/incubator-pulsar/pull/2397#discussion_r211515618 ## File path: pulsar-functions/api-java/src/main/java/org/apache/pulsar/functions/api/Context.java ## @@

[GitHub] srkukarni commented on a change in pull request #2397: Integrate Functions with Schema

srkukarni commented on a change in pull request #2397: Integrate Functions with Schema URL: https://github.com/apache/incubator-pulsar/pull/2397#discussion_r211515762 ## File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSinks.java ## @@ -469,20

[incubator-pulsar] branch master updated: Add admin api to support stop function (#2415)

This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new d804701 Add admin api to support

[incubator-pulsar] branch master updated: [tiered storage] bump jclouds version to 2.1.1 (#2410)

This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 05f8560 [tiered storage] bump jclouds

[GitHub] jai1 commented on issue #1002: Making Pulsar Proxy more secure

jai1 commented on issue #1002: Making Pulsar Proxy more secure URL: https://github.com/apache/incubator-pulsar/pull/1002#issuecomment-414568135 > was the proxy auth action ever added? No, and we don't need to > @jai1 @merlimat

[GitHub] codelipenghui commented on issue #2375: Support for delayed message delivery

codelipenghui commented on issue #2375: Support for delayed message delivery URL: https://github.com/apache/incubator-pulsar/issues/2375#issuecomment-414561637 Is any idea to implement this feature? I'm interest to join the discussion of design and contribute for this feature.

[incubator-pulsar] branch master updated: [tiered storage] store driver name and driver specific metadata in original ledger metadata (#2398)

This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 5980169 [tiered storage] store

[GitHub] jiazhai commented on issue #2417: update jclouds version to 2.1.1

jiazhai commented on issue #2417: update jclouds version to 2.1.1 URL: https://github.com/apache/incubator-pulsar/pull/2417#issuecomment-414561159 a dup This is an automated message from the Apache Git Service. To respond

[GitHub] jiazhai closed pull request #2417: update jclouds version to 2.1.1

jiazhai closed pull request #2417: update jclouds version to 2.1.1 URL: https://github.com/apache/incubator-pulsar/pull/2417 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] sijie closed pull request #2398: [tiered storage] store driver name and driver specific metadata in original ledger metadata

sijie closed pull request #2398: [tiered storage] store driver name and driver specific metadata in original ledger metadata URL: https://github.com/apache/incubator-pulsar/pull/2398 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is

[GitHub] sijie closed pull request #2415: Add admin api to support stop function

sijie closed pull request #2415: Add admin api to support stop function URL: https://github.com/apache/incubator-pulsar/pull/2415 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] sijie closed pull request #2410: [tiered storage] bump jclouds version to 2.1.1

sijie closed pull request #2410: [tiered storage] bump jclouds version to 2.1.1 URL: https://github.com/apache/incubator-pulsar/pull/2410 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] k2la opened a new pull request #2418: Fix Description of Options on Pulsar Admin

k2la opened a new pull request #2418: Fix Description of Options on Pulsar Admin URL: https://github.com/apache/incubator-pulsar/pull/2418 ### Motivation https://pulsar.incubator.apache.org/docs/en/pulsar-admin/#get-1

[incubator-pulsar.wiki] branch master updated: Updated Home (markdown)

This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.wiki.git The following commit(s) were added to refs/heads/master by this push: new 7d081a9 Updated Home (markdown)

[incubator-pulsar.wiki] branch master updated: Created PIP 23: Message Tracing By Interceptors (markdown)

This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.wiki.git The following commit(s) were added to refs/heads/master by this push: new e0388dd Created PIP 23: Message

[GitHub] massakam commented on issue #2401: Consumer often discards received messages

massakam commented on issue #2401: Consumer often discards received messages URL: https://github.com/apache/incubator-pulsar/issues/2401#issuecomment-414642945 This phenomenon seems to happen when the consumer is receiving a lot of messages. For example, it is prone to happen when the

[GitHub] jerrypeng commented on issue #2414: allow predicates concerning publish time to push down to pulsar

jerrypeng commented on issue #2414: allow predicates concerning publish time to push down to pulsar URL: https://github.com/apache/incubator-pulsar/pull/2414#issuecomment-414744387 rerun java8 tests This is an automated

[GitHub] rdhabalia commented on a change in pull request #2421: Fix bug during user publish

rdhabalia commented on a change in pull request #2421: Fix bug during user publish URL: https://github.com/apache/incubator-pulsar/pull/2421#discussion_r211787361 ## File path: pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/ContextImpl.java

[GitHub] sijie closed pull request #2418: Fix Description of Options on Pulsar Admin

sijie closed pull request #2418: Fix Description of Options on Pulsar Admin URL: https://github.com/apache/incubator-pulsar/pull/2418 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] srkukarni closed pull request #2422: Improve the documentation about publish function

srkukarni closed pull request #2422: Improve the documentation about publish function URL: https://github.com/apache/incubator-pulsar/pull/2422 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[incubator-pulsar] branch master updated: Improve the documentation about publish function (#2422)

This is an automated email from the ASF dual-hosted git repository. sanjeevrk pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 6ddc2ad Improve the documentation

[GitHub] sijie opened a new pull request #2423: [client] add properties to consumer for cpp & python client

sijie opened a new pull request #2423: [client] add properties to consumer for cpp & python client URL: https://github.com/apache/incubator-pulsar/pull/2423 ### Motivation This is a caught-up change to enable properties for consumer as java clients. ### Changes

[GitHub] sijie commented on a change in pull request #2423: [client] add properties to consumer for cpp & python client

sijie commented on a change in pull request #2423: [client] add properties to consumer for cpp & python client URL: https://github.com/apache/incubator-pulsar/pull/2423#discussion_r211793997 ## File path: pulsar-client-cpp/docker-build.sh ## @@ -41,4 +41,4 @@

[GitHub] merlimat commented on a change in pull request #2423: [client] add properties to consumer for cpp & python client

merlimat commented on a change in pull request #2423: [client] add properties to consumer for cpp & python client URL: https://github.com/apache/incubator-pulsar/pull/2423#discussion_r211785148 ## File path: pulsar-client-cpp/docker-build.sh ## @@ -41,4 +41,4 @@

[GitHub] srkukarni commented on issue #2422: Improve the documentation about publish function

srkukarni commented on issue #2422: Improve the documentation about publish function URL: https://github.com/apache/incubator-pulsar/pull/2422#issuecomment-414859049 run integration tests This is an automated message from

[GitHub] srkukarni commented on issue #2422: Improve the documentation about publish function

srkukarni commented on issue #2422: Improve the documentation about publish function URL: https://github.com/apache/incubator-pulsar/pull/2422#issuecomment-414859021 run java8 tests This is an automated message from the

[GitHub] srkukarni commented on issue #2422: Improve the documentation about publish function

srkukarni commented on issue #2422: Improve the documentation about publish function URL: https://github.com/apache/incubator-pulsar/pull/2422#issuecomment-414858935 run cpp tests This is an automated message from the Apache

[GitHub] sijie commented on a change in pull request #2420: [client] add properties to producer for cpp & python client

sijie commented on a change in pull request #2420: [client] add properties to producer for cpp & python client URL: https://github.com/apache/incubator-pulsar/pull/2420#discussion_r211781198 ## File path: pulsar-client-cpp/python/pulsar/__init__.py ## @@ -321,7 +321,8 @@

[GitHub] rdhabalia commented on issue #2416: Fix: authorization while redirecting function admin call

rdhabalia commented on issue #2416: Fix: authorization while redirecting function admin call URL: https://github.com/apache/incubator-pulsar/pull/2416#issuecomment-414884730 rerun java8 tests This is an automated message

[incubator-pulsar] branch master updated: remove 'to delete' (#2418)

This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 3bd1ad9 remove 'to delete' (#2418)

[GitHub] codelipenghui commented on a change in pull request #2400: PIP-22: Dead Letter Topic

codelipenghui commented on a change in pull request #2400: PIP-22: Dead Letter Topic URL: https://github.com/apache/incubator-pulsar/pull/2400#discussion_r211807555 ## File path:

[GitHub] codelipenghui commented on a change in pull request #2400: PIP-22: Dead Letter Topic

codelipenghui commented on a change in pull request #2400: PIP-22: Dead Letter Topic URL: https://github.com/apache/incubator-pulsar/pull/2400#discussion_r211807555 ## File path:

[GitHub] jiazhai commented on a change in pull request #2400: PIP-22: Dead Letter Topic

jiazhai commented on a change in pull request #2400: PIP-22: Dead Letter Topic URL: https://github.com/apache/incubator-pulsar/pull/2400#discussion_r211835573 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/client/api/SimpleProducerConsumerTest.java ## @@

[GitHub] codelipenghui commented on a change in pull request #2400: PIP-22: Dead Letter Topic

codelipenghui commented on a change in pull request #2400: PIP-22: Dead Letter Topic URL: https://github.com/apache/incubator-pulsar/pull/2400#discussion_r211831981 ## File path:

[GitHub] codelipenghui commented on a change in pull request #2400: PIP-22: Dead Letter Topic

codelipenghui commented on a change in pull request #2400: PIP-22: Dead Letter Topic URL: https://github.com/apache/incubator-pulsar/pull/2400#discussion_r211831981 ## File path:

[GitHub] merlimat commented on issue #2423: [client] add properties to consumer for cpp & python client

merlimat commented on issue #2423: [client] add properties to consumer for cpp & python client URL: https://github.com/apache/incubator-pulsar/pull/2423#issuecomment-414917313 run integration tests This is an automated

[GitHub] merlimat commented on issue #2423: [client] add properties to consumer for cpp & python client

merlimat commented on issue #2423: [client] add properties to consumer for cpp & python client URL: https://github.com/apache/incubator-pulsar/pull/2423#issuecomment-414917527 @sijie This seems a dup of #2420, which one should get merged?

[GitHub] jiazhai commented on a change in pull request #2400: PIP-22: Dead Letter Topic

jiazhai commented on a change in pull request #2400: PIP-22: Dead Letter Topic URL: https://github.com/apache/incubator-pulsar/pull/2400#discussion_r211836331 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/client/api/SimpleProducerConsumerTest.java ## @@

[GitHub] jiazhai commented on a change in pull request #2400: PIP-22: Dead Letter Topic

jiazhai commented on a change in pull request #2400: PIP-22: Dead Letter Topic URL: https://github.com/apache/incubator-pulsar/pull/2400#discussion_r211835151 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/utils/Quorum.java ## @@ -0,0 +1,59 @@ +/** + *

[GitHub] sijie commented on a change in pull request #2411: [functions] change instance id from string to int and expose number of instances in context

sijie commented on a change in pull request #2411: [functions] change instance id from string to int and expose number of instances in context URL: https://github.com/apache/incubator-pulsar/pull/2411#discussion_r211772934 ## File path:

[GitHub] sijie commented on issue #2411: [functions] change instance id from string to int and expose number of instances in context

sijie commented on issue #2411: [functions] change instance id from string to int and expose number of instances in context URL: https://github.com/apache/incubator-pulsar/pull/2411#issuecomment-414834875 > What about python changes? okay will take a look at python

[incubator-pulsar.wiki] branch master updated: Updated PIP 23: Message Tracing By Interceptors (markdown)

This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.wiki.git The following commit(s) were added to refs/heads/master by this push: new ed4b0e9 Updated PIP 23: Message

[GitHub] sijie commented on issue #2282: Document the settings to enable authorization

sijie commented on issue #2282: Document the settings to enable authorization URL: https://github.com/apache/incubator-pulsar/issues/2282#issuecomment-414793036 yeah the documentation is great! This is an automated message

[GitHub] sijie closed issue #2282: Document the settings to enable authorization

sijie closed issue #2282: Document the settings to enable authorization URL: https://github.com/apache/incubator-pulsar/issues/2282 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] sijie commented on a change in pull request #2400: PIP-22: Dead Letter Topic

sijie commented on a change in pull request #2400: PIP-22: Dead Letter Topic URL: https://github.com/apache/incubator-pulsar/pull/2400#discussion_r211723819 ## File path:

[GitHub] sijie commented on a change in pull request #2400: PIP-22: Dead Letter Topic

sijie commented on a change in pull request #2400: PIP-22: Dead Letter Topic URL: https://github.com/apache/incubator-pulsar/pull/2400#discussion_r211724307 ## File path:

[GitHub] sijie commented on issue #2379: Initializing cluster metadata should handle /managed-ledger path better

sijie commented on issue #2379: Initializing cluster metadata should handle /managed-ledger path better URL: https://github.com/apache/incubator-pulsar/issues/2379#issuecomment-414792602 @ivankelly I think we should two changes here: 1) disable initializing /managed-ledgers in

[GitHub] sijie opened a new pull request #2420: [client] add properties to producer for cpp & python client

sijie opened a new pull request #2420: [client] add properties to producer for cpp & python client URL: https://github.com/apache/incubator-pulsar/pull/2420 ### Motivation This is a caught-up change to enable properties for producer as java clients. ### Changes

[GitHub] srkukarni opened a new pull request #2422: Improve the documentation about publish function

srkukarni opened a new pull request #2422: Improve the documentation about publish function URL: https://github.com/apache/incubator-pulsar/pull/2422 ### Motivation Cleaned up the comments around publish ### Modifications Describe the modifications you've done. ###

[GitHub] srkukarni commented on a change in pull request #2411: [functions] change instance id from string to int and expose number of instances in context

srkukarni commented on a change in pull request #2411: [functions] change instance id from string to int and expose number of instances in context URL: https://github.com/apache/incubator-pulsar/pull/2411#discussion_r211776412 ## File path:

[GitHub] srkukarni commented on a change in pull request #2411: [functions] change instance id from string to int and expose number of instances in context

srkukarni commented on a change in pull request #2411: [functions] change instance id from string to int and expose number of instances in context URL: https://github.com/apache/incubator-pulsar/pull/2411#discussion_r211750888 ## File path:

[GitHub] sijie commented on issue #2418: Fix Description of Options on Pulsar Admin

sijie commented on issue #2418: Fix Description of Options on Pulsar Admin URL: https://github.com/apache/incubator-pulsar/pull/2418#issuecomment-414827155 run cpp tests This is an automated message from the Apache Git

[GitHub] sijie commented on a change in pull request #2420: [client] add properties to producer for cpp & python client

sijie commented on a change in pull request #2420: [client] add properties to producer for cpp & python client URL: https://github.com/apache/incubator-pulsar/pull/2420#discussion_r211773131 ## File path: pulsar-client-cpp/python/pulsar/__init__.py ## @@ -321,7 +321,8 @@

[GitHub] sijie opened a new pull request #2419: [documentation] cherry-pick deploy-kubernetes documentation changes

sijie opened a new pull request #2419: [documentation] cherry-pick deploy-kubernetes documentation changes URL: https://github.com/apache/incubator-pulsar/pull/2419 Cherry-pick changes from #2363 to 2.1.0 documentation

[GitHub] srkukarni opened a new pull request #2421: Fix bug during user publish

srkukarni opened a new pull request #2421: Fix bug during user publish URL: https://github.com/apache/incubator-pulsar/pull/2421 ### Motivation This pr fixes two bugs in the path of user publish 1. Stackoverflow error in ContextImpl where getSchema was calling itself 2. Add

[GitHub] sijie commented on issue #2346: Issue #2330: change getTopicName in MultiTopicsConsumer

sijie commented on issue #2346: Issue #2330: change getTopicName in MultiTopicsConsumer URL: https://github.com/apache/incubator-pulsar/pull/2346#issuecomment-414835396 @jiazhai can you rebase this PR to master? @merlimat can you review it again? we need this for 2.1.1 release

[GitHub] merlimat commented on issue #2418: Fix Description of Options on Pulsar Admin

merlimat commented on issue #2418: Fix Description of Options on Pulsar Admin URL: https://github.com/apache/incubator-pulsar/pull/2418#issuecomment-414754274 run cpp tests This is an automated message from the Apache Git