[GitHub] ivankelly commented on issue #1137: Schema registry

2018-02-14 Thread GitBox
ivankelly commented on issue #1137: Schema registry URL: https://github.com/apache/incubator-pulsar/pull/1137#issuecomment-365634195 I don't see any client changes in this. How is a schema set for a topic? This is an

[GitHub] ivankelly commented on issue #1137: Schema registry

2018-02-12 Thread GitBox
ivankelly commented on issue #1137: Schema registry URL: https://github.com/apache/incubator-pulsar/pull/1137#issuecomment-365062216 Yes, github really sucks at this. gerrit does it much better. What I do these days is to create a larger WIP patch which has everything and is there

[GitHub] ivankelly commented on issue #1137: Schema registry

2018-02-12 Thread GitBox
ivankelly commented on issue #1137: Schema registry URL: https://github.com/apache/incubator-pulsar/pull/1137#issuecomment-365060799 And maybe the bookkeeper schema storage implementation can be a separate patch too? This is

[GitHub] ivankelly commented on issue #1137: Schema registry

2018-02-12 Thread GitBox
ivankelly commented on issue #1137: Schema registry URL: https://github.com/apache/incubator-pulsar/pull/1137#issuecomment-365059871 Even just having the proto (and compiled stuff) separate would make it easier to look at.

[GitHub] ivankelly commented on issue #1137: Schema registry

2018-02-12 Thread GitBox
ivankelly commented on issue #1137: Schema registry URL: https://github.com/apache/incubator-pulsar/pull/1137#issuecomment-365058390 Almost 7000 LoCs. Any chance this could be broken into more digestible pieces for review? Like leave this PR here for reference, for example submit proto