[GitHub] ivankelly commented on issue #1137: Schema registry
ivankelly commented on issue #1137: Schema registry URL: https://github.com/apache/incubator-pulsar/pull/1137#issuecomment-365634195 I don't see any client changes in this. How is a schema set for a topic? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ivankelly commented on issue #1137: Schema registry
ivankelly commented on issue #1137: Schema registry URL: https://github.com/apache/incubator-pulsar/pull/1137#issuecomment-365062216 Yes, github really sucks at this. gerrit does it much better. What I do these days is to create a larger WIP patch which has everything and is there for reference. Then I push one patch at a time. The review velocity isn't so high that having multiple patches out for review makes much sense anyhow. Once an out for review patch is merged, I then merge master into my WIP branch, and break off another chunk. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ivankelly commented on issue #1137: Schema registry
ivankelly commented on issue #1137: Schema registry URL: https://github.com/apache/incubator-pulsar/pull/1137#issuecomment-365060799 And maybe the bookkeeper schema storage implementation can be a separate patch too? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ivankelly commented on issue #1137: Schema registry
ivankelly commented on issue #1137: Schema registry URL: https://github.com/apache/incubator-pulsar/pull/1137#issuecomment-365059871 Even just having the proto (and compiled stuff) separate would make it easier to look at. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ivankelly commented on issue #1137: Schema registry
ivankelly commented on issue #1137: Schema registry URL: https://github.com/apache/incubator-pulsar/pull/1137#issuecomment-365058390 Almost 7000 LoCs. Any chance this could be broken into more digestible pieces for review? Like leave this PR here for reference, for example submit proto files first, and then chunk it into patches around 400-500 lines long each that can be reviewed in around an hour? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
