[GitHub] maskit commented on issue #1258: Fix CID 262329
maskit commented on issue #1258: Fix CID 262329 URL: https://github.com/apache/incubator-pulsar/pull/1258#issuecomment-372670442 Huh, finally it passed CI tests. I had to rebase this two times because the base revisions were unstable. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] maskit commented on issue #1258: Fix CID 262329
maskit commented on issue #1258: Fix CID 262329 URL: https://github.com/apache/incubator-pulsar/pull/1258#issuecomment-371185764 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] maskit commented on issue #1258: Fix CID 262329
maskit commented on issue #1258: Fix CID 262329 URL: https://github.com/apache/incubator-pulsar/pull/1258#issuecomment-370231379 @merlimat Thank you for looking into the detail. I'm happy to fix the tests but please don't wait me and feel free to fix it yourself if this blocks something else. I just haven't been able to take time for this. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] maskit commented on issue #1258: Fix CID 262329
maskit commented on issue #1258: Fix CID 262329 URL: https://github.com/apache/incubator-pulsar/pull/1258#issuecomment-367142780 Got it. I'll ping you after I fix the test. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] maskit commented on issue #1258: Fix CID 262329
maskit commented on issue #1258: Fix CID 262329 URL: https://github.com/apache/incubator-pulsar/pull/1258#issuecomment-366994520 Hm, maybe the test case is wrong? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] maskit commented on issue #1258: Fix CID 262329
maskit commented on issue #1258: Fix CID 262329 URL: https://github.com/apache/incubator-pulsar/pull/1258#issuecomment-366973083 @jai1 This would be a candidate for 1.22.x. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
