merlimat commented on a change in pull request #1554: Fix: handle invalid
markDelete position at managed-cursor
URL: https://github.com/apache/incubator-pulsar/pull/1554#discussion_r180930432
##########
File path:
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java
##########
@@ -1301,6 +1301,16 @@ public void asyncMarkDelete(final Position position,
Map<String, Long> propertie
final MarkDeleteCallback callback, final Object ctx) {
checkNotNull(position);
checkArgument(position instanceof PositionImpl);
+
+ if (((PositionImpl)
ledger.getLastConfirmedEntry()).compareTo((PositionImpl) position) <= 0) {
Review comment:
Shouldn't this check for `< 0` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
