merlimat commented on a change in pull request #2460: Add backlog quota
retention policy to server config.
URL: https://github.com/apache/incubator-pulsar/pull/2460#discussion_r213179479
##########
File path:
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
##########
@@ -86,6 +86,11 @@
private int backlogQuotaCheckIntervalInSeconds = 60;
// Default per-topic backlog quota limit
private long backlogQuotaDefaultLimitGB = 50;
+ //Default backlog quota retention policy. Default is producer_request_hold
+ //'producer_request_hold' Policy which holds producer's send request until
the resource becomes available (or holding times out)
+ //'producer_exception' Policy which throws
javax.jms.ResourceAllocationException to the producer
+ //'consumer_backlog_eviction' Policy which evicts the oldest message from
the slowest consumer's backlog
+ private String backlogQuotaRetentionPolicy = "producer_request_hold";
Review comment:
This could be set with the enum so that we can validate the value when
loading the config file.
Also, similar to the `backlogQuotaDefaultLimitGB` this config var could be
called `backlogQuotaDefaultRetentionPolicy`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
