[GitHub] mgodave commented on issue #1551: Json schema codec

[GitBox]

mgodave commented on issue #1551: Json schema codec
URL: https://github.com/apache/incubator-pulsar/pull/1551#issuecomment-385047231
 
 
   @sijie, everything (finally) checks out.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mgodave commented on issue #1551: Json schema codec

[GitBox]

mgodave commented on issue #1551: Json schema codec
URL: https://github.com/apache/incubator-pulsar/pull/1551#issuecomment-385017875
 
 
   Actually looked at the stack trace and it looks like the call to 
SecureRandom was timing out. I was using it as a simple way to generate 
nonsense data but it twas overkill, I removed the calls and replaced them with 
static data.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mgodave commented on issue #1551: Json schema codec

[GitBox]

mgodave commented on issue #1551: Json schema codec
URL: https://github.com/apache/incubator-pulsar/pull/1551#issuecomment-385015482
 
 
   One option is to mark ignored and come back to this but that feels wrong.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mgodave commented on issue #1551: Json schema codec

[GitBox]

mgodave commented on issue #1551: Json schema codec
URL: https://github.com/apache/incubator-pulsar/pull/1551#issuecomment-385015293
 
 
   @sijie I'm not sure what's going on. I can't reproduce locally (ran test 100 
times in a loop). I'm working on docs right now and will have to circle back to 
this.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mgodave commented on issue #1551: Json schema codec

[GitBox]

mgodave commented on issue #1551: Json schema codec
URL: https://github.com/apache/incubator-pulsar/pull/1551#issuecomment-384807897
 
 
   They are intermittently timing out for some reason. Let me loop into it...
   sigh...
   
   On Thu, Apr 26, 2018 at 3:16 PM, Sijie Guo  wrote:
   
   > @mgodave 
   >
   > Test Result (2 failures / +2)
   > org.apache.pulsar.client.api.SimpleTypedProducerConsumerTest.
   > testJsonConsumerWithWrongPrestoredSchema
   > org.apache.pulsar.client.api.SimpleTypedProducerConsumerTest.
   > testJsonProducerWithWrongPrestoredSchema
   >
   > these 2 failures look like related to schema changes?
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > 
,
   > or mute the thread
   > 

   > .
   >
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mgodave commented on issue #1551: Json schema codec

[GitBox]

mgodave commented on issue #1551: Json schema codec
URL: https://github.com/apache/incubator-pulsar/pull/1551#issuecomment-384448768
 
 
   retest this please


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mgodave commented on issue #1551: Json schema codec

[GitBox]

mgodave commented on issue #1551: Json schema codec
URL: https://github.com/apache/incubator-pulsar/pull/1551#issuecomment-384445656
 
 
   retest this please


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mgodave commented on issue #1551: Json schema codec

[GitBox]

mgodave commented on issue #1551: Json schema codec
URL: https://github.com/apache/incubator-pulsar/pull/1551#issuecomment-384445656
 
 
   retest this please


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mgodave commented on issue #1551: Json schema codec

[GitBox]

mgodave commented on issue #1551: Json schema codec
URL: https://github.com/apache/incubator-pulsar/pull/1551#issuecomment-384409566
 
 
   I just noticed that, I included a stashed change by accident, one sec...
   
   On Wed, Apr 25, 2018 at 1:36 PM, Sijie Guo  wrote:
   
   > @mgodave  :
   >
   > "Java 8 Unit Tests" failed with missing header -
   > /home/jenkins/jenkins-slave/workspace/pulsar_precommit_
   > java8/pulsar-broker/src/test/java/org/apache/pulsar/client/api/
   > SimpleTypedProducerConsumerTest.java
   >
   > "Integration Tests" failed with incompatible schema -
   > "org.apache.pulsar.client.api.PulsarClientException: Trying to subscribe
   > with incompatible schema"
   >
   > https://builds.apache.org/job/pulsar_precommit_integrationtests/1001/
   > testReport/junit/org.apache.pulsar.tests.integration/TestCompaction/
   > testPublishCompactAndConsumeCLI/
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > 
,
   > or mute the thread
   > 

   > .
   >
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mgodave commented on issue #1551: Json schema codec

[GitBox]

mgodave commented on issue #1551: Json schema codec
URL: https://github.com/apache/incubator-pulsar/pull/1551#issuecomment-380936892
 
 
   I suppose I could hack in a default "is compatible" check that literally 
checks if they are equal which would require schema updates to happen via the 
REST interface. This would make upgrades hard/impossible to do seamlessly.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mgodave commented on issue #1551: Json schema codec

[GitBox]

mgodave commented on issue #1551: Json schema codec
URL: https://github.com/apache/incubator-pulsar/pull/1551#issuecomment-380928449
 
 
   > * When we attempt to create the producer, we should validate the schema 
this producer is about to start sending is compatible with the last schema we 
have in store, otherwise the producer should be denied.
   > * Same for consumer, if the type is incompatible we should fail the 
consumer creation.
   
   This will have to happen in the broker. At this very moment I have zero idea 
what it means for two JSON schemas to be "compatible", this will take some 
additional research.
   
   > * We should have tests to do basic operations on the JSON schema, eg: get 
the schemas for a topic, delete, create, update
   
   fair enough
   
   > * We should be able to have a check to control whether schema is enforced 
or not for topics of a particular namespace.
   
   "check", do you mean a config parameter?
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mgodave commented on issue #1551: Json schema codec

[GitBox]

mgodave commented on issue #1551: Json schema codec
URL: https://github.com/apache/incubator-pulsar/pull/1551#issuecomment-380866438
 
 
   @sijie circling back on your tutorial comment, I merely added some more 
files to an existing set of examples. I agree that this should not live under 
test but in order to keep like things together and to isolate changes I propose 
we leave these new files here and submit a new PR to move the tutorial files to 
a different location.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mgodave commented on issue #1551: Json schema codec

[GitBox]

mgodave commented on issue #1551: Json schema codec
URL: https://github.com/apache/incubator-pulsar/pull/1551#issuecomment-380845432
 
 
   Yeah, I had hoped to take a look yesterday evening but fell asleep. Looking 
now. re: example under "test", I honestly didn't look, I copied an existing 
example so I could run an end-to-end test, I will move it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mgodave commented on issue #1551: Json schema codec

[GitBox]

mgodave commented on issue #1551: Json schema codec
URL: https://github.com/apache/incubator-pulsar/pull/1551#issuecomment-380531331
 
 
   Fixes #1532 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services