rdhabalia commented on a change in pull request #2603: Share EventLoopGroup
between Broker and BK client
URL: https://github.com/apache/incubator-pulsar/pull/2603#discussion_r218323237
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/BookKeeperClientFactory.java
##########
@@ -28,6 +30,6 @@
* Provider of a new BookKeeper client instance
*/
public interface BookKeeperClientFactory {
- BookKeeper create(ServiceConfiguration conf, ZooKeeper zkClient) throws
IOException;
+ BookKeeper create(ServiceConfiguration conf, ZooKeeper zkClient,
EventLoopGroup eventLoopGroup) throws IOException;
Review comment:
yes, this will help in avoiding context switching while publish and
dispatching messages. however, do you see contention issue where high
dispatching can impact publish?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
