[GitHub] sijie commented on a change in pull request #1314: PIP-15: Pulsar Functions

2018-03-02 Thread GitBox
sijie commented on a change in pull request #1314: PIP-15: Pulsar Functions URL: https://github.com/apache/incubator-pulsar/pull/1314#discussion_r171998515 ## File path:

[GitHub] sijie commented on a change in pull request #1314: PIP-15: Pulsar Functions

2018-03-02 Thread GitBox
sijie commented on a change in pull request #1314: PIP-15: Pulsar Functions URL: https://github.com/apache/incubator-pulsar/pull/1314#discussion_r171998495 ## File path: pulsar-functions/python-examples/exclamation.py ## @@ -0,0 +1,29 @@ +#!/usr/bin/env python +# +#

[GitHub] sijie commented on a change in pull request #1314: PIP-15: Pulsar Functions

2018-03-02 Thread GitBox
sijie commented on a change in pull request #1314: PIP-15: Pulsar Functions URL: https://github.com/apache/incubator-pulsar/pull/1314#discussion_r171998450 ## File path: pulsar-functions/java-examples/src/main/java/org/apache/pulsar/functions/api/examples/CounterFunction.java

[GitHub] sijie commented on a change in pull request #1314: PIP-15: Pulsar Functions

2018-03-02 Thread GitBox
sijie commented on a change in pull request #1314: PIP-15: Pulsar Functions URL: https://github.com/apache/incubator-pulsar/pull/1314#discussion_r171998313 ## File path: pulsar-functions/instance/pom.xml ## @@ -0,0 +1,227 @@ + +http://maven.apache.org/POM/4.0.0;

[GitHub] sijie commented on a change in pull request #1314: PIP-15: Pulsar Functions

2018-03-02 Thread GitBox
sijie commented on a change in pull request #1314: PIP-15: Pulsar Functions URL: https://github.com/apache/incubator-pulsar/pull/1314#discussion_r171998294 ## File path: pulsar-functions/instance/pom.xml ## @@ -0,0 +1,227 @@ + +http://maven.apache.org/POM/4.0.0;

[GitHub] sijie commented on a change in pull request #1314: PIP-15: Pulsar Functions

2018-03-02 Thread GitBox
sijie commented on a change in pull request #1314: PIP-15: Pulsar Functions URL: https://github.com/apache/incubator-pulsar/pull/1314#discussion_r171998264 ## File path: pulsar-functions/dist/pom.xml ## @@ -0,0 +1,109 @@