sijie commented on issue #1551: Json schema codec
URL: https://github.com/apache/incubator-pulsar/pull/1551#issuecomment-385049216
great! well done, @mgodave
@merlimat please review this latest PR. if you don't have any objections, I
will merge today.
sijie commented on issue #1551: Json schema codec
URL: https://github.com/apache/incubator-pulsar/pull/1551#issuecomment-384791560
@mgodave
Test Result (2 failures / +2)
org.apache.pulsar.client.api.SimpleTypedProducerConsumerTest.testJsonConsumerWithWrongPrestoredSchema
sijie commented on issue #1551: Json schema codec
URL: https://github.com/apache/incubator-pulsar/pull/1551#issuecomment-384711360
retest this please
This is an automated message from the Apache Git Service.
To respond to the
sijie commented on issue #1551: Json schema codec
URL: https://github.com/apache/incubator-pulsar/pull/1551#issuecomment-384211810
@merlimat can you review @mgodave 's latest change?
This is an automated message from the
sijie commented on issue #1551: Json schema codec
URL: https://github.com/apache/incubator-pulsar/pull/1551#issuecomment-384211672
retest this please
This is an automated message from the Apache Git Service.
To respond to the
sijie commented on issue #1551: Json schema codec
URL: https://github.com/apache/incubator-pulsar/pull/1551#issuecomment-380883551
@mgodave works for me. +1
This is an automated message from the Apache Git Service.
To respond
sijie commented on issue #1551: Json schema codec
URL: https://github.com/apache/incubator-pulsar/pull/1551#issuecomment-380743237
@mgodave "javax/validation/constraints/NotBlank" not found - it sounds
strange to me.
This is
