[GitHub] sijie commented on issue #2570: Fix BC issue in functions trigger function submitted by old CLI
sijie commented on issue #2570: Fix BC issue in functions trigger function submitted by old CLI URL: https://github.com/apache/incubator-pulsar/pull/2570#issuecomment-421231882 > --topic-pattern = Input Topic Pattern with default schema hmm, I don't believe so. Let me find the original pull request. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie commented on issue #2570: Fix BC issue in functions trigger function submitted by old CLI
sijie commented on issue #2570: Fix BC issue in functions trigger function submitted by old CLI URL: https://github.com/apache/incubator-pulsar/pull/2570#issuecomment-421232586 looking into the refactor. I believe the refactor mess up this - https://github.com/apache/incubator-pulsar/blob/59df98bd5675fa17cc858fa2a0c5cac45475a5f4/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java#L628 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie commented on issue #2570: Fix BC issue in functions trigger function submitted by old CLI
sijie commented on issue #2570: Fix BC issue in functions trigger function submitted by old CLI URL: https://github.com/apache/incubator-pulsar/pull/2570#issuecomment-421232435 https://github.com/apache/incubator-pulsar/pull/1903/files#diff-cae1c6ad6356263a1292cfcb9fddc015R110 if --topic-pattern is specified, it will look up the --custom-serde-inputs, if no serde is used, it will be using default serde. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie commented on issue #2570: Fix BC issue in functions trigger function submitted by old CLI
sijie commented on issue #2570: Fix BC issue in functions trigger function submitted by old CLI URL: https://github.com/apache/incubator-pulsar/pull/2570#issuecomment-421231232 @srkukarni : ``` @Parameter(names = "--topicsPattern", description = "TopicsPattern to consume from list of topics under a namespace that match the pattern. [--input] and [--topic-pattern] are mutually exclusive. Add SerDe class name for a pattern in --custom-serde-inputs (supported for java fun only)", hidden = true) protected String DEPRECATED_topicsPattern; @Parameter(names = "--topics-pattern", description = "The topic pattern to consume from list of topics under a namespace that match the pattern. [--input] and [--topic-pattern] are mutually exclusive. Add SerDe class name for a pattern in --custom-serde-inputs (supported for java fun only)") protected String topicsPattern; ``` unless I missing understand the comment here ... and here https://github.com/apache/incubator-pulsar/blob/59df98bd5675fa17cc858fa2a0c5cac45475a5f4/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java#L628 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services