[GitHub] srkukarni commented on a change in pull request #2445: Remove schema validator from annotations
srkukarni commented on a change in pull request #2445: Remove schema validator from annotations URL: https://github.com/apache/incubator-pulsar/pull/2445#discussion_r212862442 ## File path: pulsar-functions/utils/src/main/java/org/apache/pulsar/functions/utils/SourceConfig.java ## @@ -58,7 +58,6 @@ @isImplementationOfClass(implementsClass = SerDe.class) private String serdeClassName; -@isImplementationOfClass(implementsClass = Schema.class) Review comment: Validating schemas is a little complicated becuase we need the types to do full validation. Thus their validation class cannot just be annotations, but actually involve more logic after we extract the types. Thus in the ValidatorImpls class, validation of schemas is done without using annotations This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] srkukarni commented on a change in pull request #2445: Remove schema validator from annotations
srkukarni commented on a change in pull request #2445: Remove schema validator from annotations URL: https://github.com/apache/incubator-pulsar/pull/2445#discussion_r212777878 ## File path: pulsar-functions/utils/src/main/java/org/apache/pulsar/functions/utils/SourceConfig.java ## @@ -58,7 +58,6 @@ @isImplementationOfClass(implementsClass = SerDe.class) private String serdeClassName; -@isImplementationOfClass(implementsClass = Schema.class) Review comment: We allow inbuilt things like avro, json, etc, which make this not the right check This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
