[GitHub] srkukarni commented on a change in pull request #2549: [Function] avoid creating assignment snapshot and publish individual assignment msg

2018-09-13 Thread GitBox 
srkukarni commented on a change in pull request #2549: [Function] avoid 
creating assignment snapshot and publish individual assignment msg
URL: https://github.com/apache/incubator-pulsar/pull/2549#discussion_r217493540
 
 

 ##
 File path: 
pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/FunctionAssignmentTailer.java
 ##
 @@ -34,15 +36,16 @@
 private final FunctionRuntimeManager functionRuntimeManager;
 private final Reader reader;
 
 Review comment:
   Instead of byte[], do you think we could make it a typed reader?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] srkukarni commented on a change in pull request #2549: [Function] avoid creating assignment snapshot and publish individual assignment msg

2018-09-13 Thread GitBox 
srkukarni commented on a change in pull request #2549: [Function] avoid 
creating assignment snapshot and publish individual assignment msg
URL: https://github.com/apache/incubator-pulsar/pull/2549#discussion_r217492954
 
 

 ##
 File path: pulsar-functions/proto/src/main/proto/Function.proto
 ##
 @@ -133,4 +133,5 @@ message Instance {
 message Assignment {
 Instance instance = 1;
 string workerId = 2;
+bool removed = 3;
 
 Review comment:
   Why do we take this approach. Instead we could just write an empty value to 
the key, which is the removal?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services