[GitHub] yush1ga commented on a change in pull request #1352: Delete inactive subscriptions automatically

2018-04-10 Thread GitBox
yush1ga commented on a change in pull request #1352: Delete inactive 
subscriptions automatically
URL: https://github.com/apache/incubator-pulsar/pull/1352#discussion_r180614996
 
 

 ##
 File path: 
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/ManagedCursor.java
 ##
 @@ -57,6 +57,19 @@
  */
 String getName();
 
+/**
+ * Get tthe last active time of the cursor.
 
 Review comment:
   Fixed:)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] yush1ga commented on a change in pull request #1352: Delete inactive subscriptions automatically

2018-03-07 Thread GitBox
yush1ga commented on a change in pull request #1352: Delete inactive 
subscriptions automatically
URL: https://github.com/apache/incubator-pulsar/pull/1352#discussion_r172765485
 
 

 ##
 File path: 
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
 ##
 @@ -812,6 +820,15 @@ public void checkMessageDeduplicationInfo() {
 });
 }
 
+public void checkInactiveSubscriptions() {
+topics.forEach((n, t) -> {
+Topic topic = t.getNow(null);
 
 Review comment:
   I see, thank you.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] yush1ga commented on a change in pull request #1352: Delete inactive subscriptions automatically

2018-03-06 Thread GitBox
yush1ga commented on a change in pull request #1352: Delete inactive 
subscriptions automatically
URL: https://github.com/apache/incubator-pulsar/pull/1352#discussion_r172758083
 
 

 ##
 File path: 
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
 ##
 @@ -812,6 +820,15 @@ public void checkMessageDeduplicationInfo() {
 });
 }
 
+public void checkInactiveSubscriptions() {
+topics.forEach((n, t) -> {
+Topic topic = t.getNow(null);
 
 Review comment:
   Do I have to fix 't.getNow(null);' of other parts? (e.g. 
   
https://github.com/apache/incubator-pulsar/pull/1352/files/320a0f71cfb5c8c8fe67430806281417b6982120#diff-bb90edad9f69a5d791cb43b04d9a4c82R816)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services