Repository: qpid-jms Updated Branches: refs/heads/master da0f0e6e6 -> 1c3ff1cbb
QPIDJMS-207 Add more test coverage Project: http://git-wip-us.apache.org/repos/asf/qpid-jms/repo Commit: http://git-wip-us.apache.org/repos/asf/qpid-jms/commit/6dd3d2b1 Tree: http://git-wip-us.apache.org/repos/asf/qpid-jms/tree/6dd3d2b1 Diff: http://git-wip-us.apache.org/repos/asf/qpid-jms/diff/6dd3d2b1 Branch: refs/heads/master Commit: 6dd3d2b1d088b52685ca75a6edd7da279a2e4c78 Parents: da0f0e6 Author: Timothy Bish <tabish...@gmail.com> Authored: Tue Sep 20 10:59:50 2016 -0400 Committer: Timothy Bish <tabish...@gmail.com> Committed: Tue Sep 20 10:59:50 2016 -0400 ---------------------------------------------------------------------- .../qpid/jms/meta/JmsConnectionInfoTest.java | 32 +++++++++++++++ .../qpid/jms/meta/JmsConsumerInfoTest.java | 10 +++++ .../qpid/jms/meta/JmsProducerInfoTest.java | 14 +++++++ .../qpid/jms/meta/JmsSessionInfoTest.java | 42 +++++++++++++++++++- 4 files changed, 97 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/qpid-jms/blob/6dd3d2b1/qpid-jms-client/src/test/java/org/apache/qpid/jms/meta/JmsConnectionInfoTest.java ---------------------------------------------------------------------- diff --git a/qpid-jms-client/src/test/java/org/apache/qpid/jms/meta/JmsConnectionInfoTest.java b/qpid-jms-client/src/test/java/org/apache/qpid/jms/meta/JmsConnectionInfoTest.java index 8e4fb23..0511840 100644 --- a/qpid-jms-client/src/test/java/org/apache/qpid/jms/meta/JmsConnectionInfoTest.java +++ b/qpid-jms-client/src/test/java/org/apache/qpid/jms/meta/JmsConnectionInfoTest.java @@ -20,9 +20,11 @@ import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertFalse; import static org.junit.Assert.assertNotNull; import static org.junit.Assert.assertNotSame; +import static org.junit.Assert.assertNull; import static org.junit.Assert.assertSame; import static org.junit.Assert.assertTrue; +import java.nio.charset.StandardCharsets; import java.util.concurrent.atomic.AtomicBoolean; import org.apache.qpid.jms.policy.JmsDefaultMessageIDPolicy; @@ -157,4 +159,34 @@ public class JmsConnectionInfoTest { assertTrue(visited.get()); } + + @Test + public void testGetEncodedUsername() { + final JmsConnectionInfo info = new JmsConnectionInfo(firstId); + info.setUsername("user"); + byte[] result = info.getEncodedUsername(); + assertEquals("user", new String(result, StandardCharsets.UTF_8)); + } + + @Test + public void testGetEncodedUsernameValueIsCached() { + final JmsConnectionInfo info = new JmsConnectionInfo(firstId); + info.setUsername("user"); + byte[] result1 = info.getEncodedUsername(); + byte[] result2 = info.getEncodedUsername(); + assertSame(result1, result2); + } + + @Test + public void testGetEncodedUsernameWithNoUsername() { + final JmsConnectionInfo info = new JmsConnectionInfo(firstId); + assertNull(info.getEncodedUsername()); + } + + @Test + public void testGetEncodedUsernameWithEmptyUsername() { + final JmsConnectionInfo info = new JmsConnectionInfo(firstId); + info.setUsername(""); + assertNotNull(info.getEncodedUsername()); + } } http://git-wip-us.apache.org/repos/asf/qpid-jms/blob/6dd3d2b1/qpid-jms-client/src/test/java/org/apache/qpid/jms/meta/JmsConsumerInfoTest.java ---------------------------------------------------------------------- diff --git a/qpid-jms-client/src/test/java/org/apache/qpid/jms/meta/JmsConsumerInfoTest.java b/qpid-jms-client/src/test/java/org/apache/qpid/jms/meta/JmsConsumerInfoTest.java index 20ff635..87f0908 100644 --- a/qpid-jms-client/src/test/java/org/apache/qpid/jms/meta/JmsConsumerInfoTest.java +++ b/qpid-jms-client/src/test/java/org/apache/qpid/jms/meta/JmsConsumerInfoTest.java @@ -172,4 +172,14 @@ public class JmsConsumerInfoTest { assertTrue(visited.get()); } + + @Test + public void testGetRedeliveryPolicyDefaults() { + final JmsConsumerInfo info = new JmsConsumerInfo(firstId); + + assertNotNull(info.getRedeliveryPolicy()); + info.setRedeliveryPolicy(null); + assertNotNull(info.getRedeliveryPolicy()); + assertTrue(info.getRedeliveryPolicy() instanceof JmsDefaultRedeliveryPolicy); + } } http://git-wip-us.apache.org/repos/asf/qpid-jms/blob/6dd3d2b1/qpid-jms-client/src/test/java/org/apache/qpid/jms/meta/JmsProducerInfoTest.java ---------------------------------------------------------------------- diff --git a/qpid-jms-client/src/test/java/org/apache/qpid/jms/meta/JmsProducerInfoTest.java b/qpid-jms-client/src/test/java/org/apache/qpid/jms/meta/JmsProducerInfoTest.java index f2371d0..79ef89f 100644 --- a/qpid-jms-client/src/test/java/org/apache/qpid/jms/meta/JmsProducerInfoTest.java +++ b/qpid-jms-client/src/test/java/org/apache/qpid/jms/meta/JmsProducerInfoTest.java @@ -21,6 +21,7 @@ import static org.junit.Assert.assertFalse; import static org.junit.Assert.assertNotNull; import static org.junit.Assert.assertSame; import static org.junit.Assert.assertTrue; +import static org.junit.Assert.fail; import java.util.concurrent.atomic.AtomicBoolean; @@ -64,6 +65,19 @@ public class JmsProducerInfoTest { } @Test + public void testCreateThrowsOnNullParameters() { + try { + new JmsProducerInfo(null, JmsMessageIDBuilder.BUILTIN.DEFAULT.createBuilder()); + fail("Should not allow create will null params"); + } catch (IllegalArgumentException ex) {} + + try { + new JmsProducerInfo(firstId, null); + fail("Should not allow create will null params"); + } catch (IllegalArgumentException ex) {} + } + + @Test public void testCopy() { JmsProducerInfo info = createPorducerInfo(firstId); info.setDestination(new JmsTopic("Test")); http://git-wip-us.apache.org/repos/asf/qpid-jms/blob/6dd3d2b1/qpid-jms-client/src/test/java/org/apache/qpid/jms/meta/JmsSessionInfoTest.java ---------------------------------------------------------------------- diff --git a/qpid-jms-client/src/test/java/org/apache/qpid/jms/meta/JmsSessionInfoTest.java b/qpid-jms-client/src/test/java/org/apache/qpid/jms/meta/JmsSessionInfoTest.java index 2ba79ab..947b00c 100644 --- a/qpid-jms-client/src/test/java/org/apache/qpid/jms/meta/JmsSessionInfoTest.java +++ b/qpid-jms-client/src/test/java/org/apache/qpid/jms/meta/JmsSessionInfoTest.java @@ -36,7 +36,7 @@ import org.junit.Before; import org.junit.Test; /** - * + * Tests for the JmsSessionInfo object */ public class JmsSessionInfoTest { @@ -167,4 +167,44 @@ public class JmsSessionInfoTest { assertTrue(visited.get()); } + + @Test + public void testGetMessageIDPolicyDefaults() { + final JmsSessionInfo info = new JmsSessionInfo(firstId); + + assertNotNull(info.getMessageIDPolicy()); + info.setMessageIDPolicy(null); + assertNotNull(info.getMessageIDPolicy()); + assertTrue(info.getMessageIDPolicy() instanceof JmsDefaultMessageIDPolicy); + } + + @Test + public void testGetPrefetchPolicyDefaults() { + final JmsSessionInfo info = new JmsSessionInfo(firstId); + + assertNotNull(info.getPrefetchPolicy()); + info.setPrefetchPolicy(null); + assertNotNull(info.getPrefetchPolicy()); + assertTrue(info.getPrefetchPolicy() instanceof JmsDefaultPrefetchPolicy); + } + + @Test + public void testGetPresettlePolicyDefaults() { + final JmsSessionInfo info = new JmsSessionInfo(firstId); + + assertNotNull(info.getPresettlePolicy()); + info.setPresettlePolicy(null); + assertNotNull(info.getPresettlePolicy()); + assertTrue(info.getPresettlePolicy() instanceof JmsDefaultPresettlePolicy); + } + + @Test + public void testGetRedeliveryPolicyDefaults() { + final JmsSessionInfo info = new JmsSessionInfo(firstId); + + assertNotNull(info.getRedeliveryPolicy()); + info.setRedeliveryPolicy(null); + assertNotNull(info.getRedeliveryPolicy()); + assertTrue(info.getRedeliveryPolicy() instanceof JmsDefaultRedeliveryPolicy); + } } --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@qpid.apache.org For additional commands, e-mail: commits-h...@qpid.apache.org
