Repository: incubator-ranger Updated Branches: refs/heads/master bb420d5c2 -> 0af413157
Minor cleanup stuff Project: http://git-wip-us.apache.org/repos/asf/incubator-ranger/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-ranger/commit/0af41315 Tree: http://git-wip-us.apache.org/repos/asf/incubator-ranger/tree/0af41315 Diff: http://git-wip-us.apache.org/repos/asf/incubator-ranger/diff/0af41315 Branch: refs/heads/master Commit: 0af4131570f8a1c97a11c0f22ce69d6613442096 Parents: bb420d5 Author: Colm O hEigeartaigh <cohei...@apache.org> Authored: Fri Sep 16 11:07:38 2016 +0100 Committer: Colm O hEigeartaigh <cohei...@apache.org> Committed: Fri Sep 16 11:07:38 2016 +0100 ---------------------------------------------------------------------- .../ranger/audit/provider/BaseAuditHandler.java | 6 ++--- .../ranger/examples/sampleapp/SampleApp.java | 23 +++----------------- 2 files changed, 5 insertions(+), 24 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-ranger/blob/0af41315/agents-audit/src/main/java/org/apache/ranger/audit/provider/BaseAuditHandler.java ---------------------------------------------------------------------- diff --git a/agents-audit/src/main/java/org/apache/ranger/audit/provider/BaseAuditHandler.java b/agents-audit/src/main/java/org/apache/ranger/audit/provider/BaseAuditHandler.java index 6717c92..fe6d973 100644 --- a/agents-audit/src/main/java/org/apache/ranger/audit/provider/BaseAuditHandler.java +++ b/agents-audit/src/main/java/org/apache/ranger/audit/provider/BaseAuditHandler.java @@ -138,9 +138,7 @@ public abstract class BaseAuditHandler implements AuditHandler { */ @Override public boolean log(AuditEventBase event) { - List<AuditEventBase> eventList = new ArrayList<AuditEventBase>(); - eventList.add(event); - return log(eventList); + return log(Collections.singletonList(event)); } /* @@ -165,7 +163,7 @@ public abstract class BaseAuditHandler implements AuditHandler { */ @Override public boolean logJSON(Collection<String> events) { - List<AuditEventBase> eventList = new ArrayList<AuditEventBase>(); + List<AuditEventBase> eventList = new ArrayList<AuditEventBase>(events.size()); for (String event : events) { eventList.add(MiscUtil.fromJson(event, AuthzAuditEvent.class)); } http://git-wip-us.apache.org/repos/asf/incubator-ranger/blob/0af41315/ranger-examples/sampleapp/src/main/java/org/apache/ranger/examples/sampleapp/SampleApp.java ---------------------------------------------------------------------- diff --git a/ranger-examples/sampleapp/src/main/java/org/apache/ranger/examples/sampleapp/SampleApp.java b/ranger-examples/sampleapp/src/main/java/org/apache/ranger/examples/sampleapp/SampleApp.java index 3b9d14f..045ffab 100644 --- a/ranger-examples/sampleapp/src/main/java/org/apache/ranger/examples/sampleapp/SampleApp.java +++ b/ranger-examples/sampleapp/src/main/java/org/apache/ranger/examples/sampleapp/SampleApp.java @@ -128,28 +128,11 @@ public class SampleApp { return args[index]; } - private Set<String> getStringSetArg(String[] args, int index) { - String argValue = getStringArg(args, index); - - if(argValue == null) { - return null; - } - - Set<String> ret = new HashSet<String>(); - - for(String value : argValue.split(",")) { - ret.add(value); - } - - return ret; - } - private String getInput() { - Scanner inputReader = new Scanner(System.in, StandardCharsets.UTF_8.name()); - System.out.print("command> "); - System.out.flush(); - try { + try (Scanner inputReader = new Scanner(System.in, StandardCharsets.UTF_8.name())) { + System.out.print("command> "); + System.out.flush(); return inputReader.nextLine(); } catch(Exception excp) { // ignore
