Re: [PR] [#8859] Fix duplicate mapped file in mutil commitlog store path mode. [rocketmq]
hexueyuan commented on PR #8897: URL: https://github.com/apache/rocketmq/pull/8897#issuecomment-2492768260 This pr may need someone review it again, thanks ~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [#8859] Fix duplicate mapped file in mutil commitlog store path mode. [rocketmq]
hexueyuan commented on code in PR #8897:
URL: https://github.com/apache/rocketmq/pull/8897#discussion_r1838036088
##
store/src/main/java/org/apache/rocketmq/store/AllocateMappedFileService.java:
##
@@ -76,13 +82,14 @@ public MappedFile putRequestAndReturnMappedFile(String
nextFilePath, String next
canSubmitRequests--;
}
+String nextNextFileName =
nextNextFilePath.substring(nextNextFilePath.lastIndexOf("/") + 1);
Review Comment:
It seems like some errors blocked the workflow checks, but I don't have
permission to stop or rerun it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [#8859] Fix duplicate mapped file in mutil commitlog store path mode. [rocketmq]
hexueyuan commented on code in PR #8897:
URL: https://github.com/apache/rocketmq/pull/8897#discussion_r1836274976
##
store/src/main/java/org/apache/rocketmq/store/AllocateMappedFileService.java:
##
@@ -76,13 +82,14 @@ public MappedFile putRequestAndReturnMappedFile(String
nextFilePath, String next
canSubmitRequests--;
}
+String nextNextFileName =
nextNextFilePath.substring(nextNextFilePath.lastIndexOf("/") + 1);
Review Comment:
> a new patch after completing the test in my repository
Fixed compatibility issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [#8859] Fix duplicate mapped file in mutil commitlog store path mode. [rocketmq]
hexueyuan commented on code in PR #8897:
URL: https://github.com/apache/rocketmq/pull/8897#discussion_r1836274976
##
store/src/main/java/org/apache/rocketmq/store/AllocateMappedFileService.java:
##
@@ -76,13 +82,14 @@ public MappedFile putRequestAndReturnMappedFile(String
nextFilePath, String next
canSubmitRequests--;
}
+String nextNextFileName =
nextNextFilePath.substring(nextNextFilePath.lastIndexOf("/") + 1);
Review Comment:
> a new patch after completing the test in my repository
Fixed compatibility issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [#8859] Fix duplicate mapped file in mutil commitlog store path mode. [rocketmq]
hexueyuan commented on code in PR #8897:
URL: https://github.com/apache/rocketmq/pull/8897#discussion_r1836126949
##
store/src/main/java/org/apache/rocketmq/store/AllocateMappedFileService.java:
##
@@ -76,13 +82,14 @@ public MappedFile putRequestAndReturnMappedFile(String
nextFilePath, String next
canSubmitRequests--;
}
+String nextNextFileName =
nextNextFilePath.substring(nextNextFilePath.lastIndexOf("/") + 1);
Review Comment:
Sorry, there are indeed some compatibility issues in my UTs, I have located
the problem in the workflows. I will provide a new patch after completing the
test in my repository later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [#8859] Fix duplicate mapped file in mutil commitlog store path mode. [rocketmq]
hexueyuan commented on code in PR #8897:
URL: https://github.com/apache/rocketmq/pull/8897#discussion_r1836039056
##
store/src/main/java/org/apache/rocketmq/store/AllocateMappedFileService.java:
##
@@ -76,13 +82,14 @@ public MappedFile putRequestAndReturnMappedFile(String
nextFilePath, String next
canSubmitRequests--;
}
+String nextNextFileName =
nextNextFilePath.substring(nextNextFilePath.lastIndexOf("/") + 1);
Review Comment:
Do you mean file path separator in test case? I also have this doubts but
the other use cases I refer to in this file are like this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [#8859] Fix duplicate mapped file in mutil commitlog store path mode. [rocketmq]
RongtongJin commented on code in PR #8897:
URL: https://github.com/apache/rocketmq/pull/8897#discussion_r1836004799
##
store/src/main/java/org/apache/rocketmq/store/AllocateMappedFileService.java:
##
@@ -76,13 +82,14 @@ public MappedFile putRequestAndReturnMappedFile(String
nextFilePath, String next
canSubmitRequests--;
}
+String nextNextFileName =
nextNextFilePath.substring(nextNextFilePath.lastIndexOf("/") + 1);
Review Comment:
> The UTs also need to be modified accordingly.
By the way, is there any compatibility issue here? From the code, it seems
that there isn't.
##
store/src/main/java/org/apache/rocketmq/store/AllocateMappedFileService.java:
##
@@ -76,13 +82,14 @@ public MappedFile putRequestAndReturnMappedFile(String
nextFilePath, String next
canSubmitRequests--;
}
+String nextNextFileName =
nextNextFilePath.substring(nextNextFilePath.lastIndexOf("/") + 1);
Review Comment:
> Sorry, it was my oversight. I have modified it as required. Please review
it again. Thank you.
By the way, is there any compatibility issue here? From the code, it seems
that there isn't.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [#8859] Fix duplicate mapped file in mutil commitlog store path mode. [rocketmq]
RongtongJin commented on code in PR #8897:
URL: https://github.com/apache/rocketmq/pull/8897#discussion_r1836004799
##
store/src/main/java/org/apache/rocketmq/store/AllocateMappedFileService.java:
##
@@ -76,13 +82,14 @@ public MappedFile putRequestAndReturnMappedFile(String
nextFilePath, String next
canSubmitRequests--;
}
+String nextNextFileName =
nextNextFilePath.substring(nextNextFilePath.lastIndexOf("/") + 1);
Review Comment:
> The UTs also need to be modified accordingly.
By the way, is there any compatibility issue here? From the code, it seems
that there isn't.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [#8859] Fix duplicate mapped file in mutil commitlog store path mode. [rocketmq]
hexueyuan commented on code in PR #8897:
URL: https://github.com/apache/rocketmq/pull/8897#discussion_r1835886913
##
store/src/main/java/org/apache/rocketmq/store/AllocateMappedFileService.java:
##
@@ -76,13 +82,14 @@ public MappedFile putRequestAndReturnMappedFile(String
nextFilePath, String next
canSubmitRequests--;
}
+String nextNextFileName =
nextNextFilePath.substring(nextNextFilePath.lastIndexOf("/") + 1);
Review Comment:
Sorry, it was my oversight. I have modified it as required. Please review it
again. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [#8859] Fix duplicate mapped file in mutil commitlog store path mode. [rocketmq]
RongtongJin commented on code in PR #8897:
URL: https://github.com/apache/rocketmq/pull/8897#discussion_r1835870473
##
store/src/main/java/org/apache/rocketmq/store/AllocateMappedFileService.java:
##
@@ -76,13 +82,14 @@ public MappedFile putRequestAndReturnMappedFile(String
nextFilePath, String next
canSubmitRequests--;
}
+String nextNextFileName =
nextNextFilePath.substring(nextNextFilePath.lastIndexOf("/") + 1);
Review Comment:
The UTs also need to be modified accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [#8859] Fix duplicate mapped file in mutil commitlog store path mode. [rocketmq]
hexueyuan commented on code in PR #8897:
URL: https://github.com/apache/rocketmq/pull/8897#discussion_r1835287005
##
store/src/main/java/org/apache/rocketmq/store/AllocateMappedFileService.java:
##
@@ -76,13 +82,14 @@ public MappedFile putRequestAndReturnMappedFile(String
nextFilePath, String next
canSubmitRequests--;
}
+String nextNextFileName =
nextNextFilePath.substring(nextNextFilePath.lastIndexOf("/") + 1);
Review Comment:
Okay, fixed now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [#8859] Fix duplicate mapped file in mutil commitlog store path mode. [rocketmq]
RongtongJin commented on code in PR #8897:
URL: https://github.com/apache/rocketmq/pull/8897#discussion_r1835214112
##
store/src/main/java/org/apache/rocketmq/store/AllocateMappedFileService.java:
##
@@ -76,13 +82,14 @@ public MappedFile putRequestAndReturnMappedFile(String
nextFilePath, String next
canSubmitRequests--;
}
+String nextNextFileName =
nextNextFilePath.substring(nextNextFilePath.lastIndexOf("/") + 1);
Review Comment:
It is necessary to use File.separator, as the file path separator on other
OS may not be '/'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
