Re: [PR] [ISSUE #8912] Rebalancing logic shift in POP consumption mode [rocketmq]
3424672656 closed pull request #8923: [ISSUE #8912] Rebalancing logic shift in POP consumption mode URL: https://github.com/apache/rocketmq/pull/8923 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #8912] Rebalancing logic shift in POP consumption mode [rocketmq]
3424672656 commented on PR #8923: URL: https://github.com/apache/rocketmq/pull/8923#issuecomment-2476238565 > Why not reduce the computational load on the server side by adding a cache to the broker, instead of adopting a client-side computation approach? And the server cache should also consider the problem of sensing and updating cache in time, and the delay of cache update and rebalancing at the same time -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #8912] Rebalancing logic shift in POP consumption mode [rocketmq]
3424672656 commented on PR #8923: URL: https://github.com/apache/rocketmq/pull/8923#issuecomment-2476227811 > Why not reduce the computational load on the server side by adding a cache to the broker, instead of adopting a client-side computation approach? Do you mean the results of the distribution cached on the broker side? When POP consumption mode is enabled, I think there are also a large number of network requests, and each topic subscribed by the corresponding client is a network request, which does not seem to solve the problem completely. Transferring to the client side can unify the rebalancing logic. Because it doesn't seem easy to completely isolate POP and PULL rebalancing logic in the original version, and the initial client execution is ideally local rebalancing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #8912] Rebalancing logic shift in POP consumption mode [rocketmq]
qianye1001 commented on PR #8923: URL: https://github.com/apache/rocketmq/pull/8923#issuecomment-2476165179 Why not reduce the computational load on the server side by adding a cache to the broker, instead of adopting a client-side computation approach? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #8912] Rebalancing logic shift in POP consumption mode [rocketmq]
codecov-commenter commented on PR #8923: URL: https://github.com/apache/rocketmq/pull/8923#issuecomment-2476016027 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/8923?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report Attention: Patch coverage is `13.79310%` with `175 lines` in your changes missing coverage. Please review. > Project coverage is 47.50%. Comparing base [(`66ba456`)](https://app.codecov.io/gh/apache/rocketmq/commit/66ba4566f5ebaeac47c73eaaf4a86567e3760063?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`f214dcf`)](https://app.codecov.io/gh/apache/rocketmq/commit/f214dcf70f90555b9516936711a7e2e1d508f0e8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). | [Files with missing lines](https://app.codecov.io/gh/apache/rocketmq/pull/8923?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/rocketmq/client/impl/consumer/RebalanceImpl.java](https://app.codecov.io/gh/apache/rocketmq/pull/8923?src=pr&el=tree&filepath=client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fclient%2Fimpl%2Fconsumer%2FRebalanceImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9SZWJhbGFuY2VJbXBsLmphdmE=) | 3.00% | [95 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/8923?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...cketmq/client/impl/consumer/RebalancePushImpl.java](https://app.codecov.io/gh/apache/rocketmq/pull/8923?src=pr&el=tree&filepath=client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fclient%2Fimpl%2Fconsumer%2FRebalancePushImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9SZWJhbGFuY2VQdXNoSW1wbC5qYXZh) | 17.50% | [32 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/8923?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rocketmq/client/impl/factory/MQClientInstance.java](https://app.codecov.io/gh/apache/rocketmq/pull/8923?src=pr&el=tree&filepath=client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fclient%2Fimpl%2Ffactory%2FMQClientInstance.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9mYWN0b3J5L01RQ2xpZW50SW5zdGFuY2UuamF2YQ==) | 0.00% | [22 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/8923?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../rocketmq/client/impl/ClientRemotingProcessor.java](https://app.codecov.io/gh/apache/rocketmq/pull/8923?src=pr&el=tree&filepath=client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fclient%2Fimpl%2FClientRemotingProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9DbGllbnRSZW1vdGluZ1Byb2Nlc3Nvci5qYXZh) | 0.00% | [11 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/8923?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...g/apache/rocketmq/client/impl/MQClientAPIImpl.java](https://app.codecov.io/gh/apache/rocketmq/pull/8923?src=pr&el=tree&filepath=client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fclient%2Fimpl%2FMQClientAPIImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9NUUNsaWVudEFQSUltcGwuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/8923?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/rocketmq/broker/client/net/Broker2Client.java](https://app.codecov.io/gh/apache/rocketmq/pull/8923?src=pr&el=tree&filepath=broker%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fbroker%2Fclient%2Fnet%2FBroker2Client.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvY2xpZW50L25ldC9Ccm9rZXIyQ2xpZW50LmphdmE=) | 83.33% | [2 M
