[GitHub] [samza] bkonold commented on a change in pull request #1343: SAMZA-2353: Support standby containers with transactional state

bkonold commented on a change in pull request #1343: URL: https://github.com/apache/samza/pull/1343#discussion_r429069274 ## File path: samza-core/src/main/java/org/apache/samza/container/RunLoop.java ## @@ -625,7 +625,9 @@ public void run() { log.trace("Update o

[GitHub] [samza] bkonold commented on a change in pull request #1343: SAMZA-2353: Support standby containers with transactional state

bkonold commented on a change in pull request #1343: URL: https://github.com/apache/samza/pull/1343#discussion_r429138576 ## File path: samza-core/src/main/java/org/apache/samza/storage/TransactionalTaskSideInputStorageManager.java ## @@ -0,0 +1,113 @@ +/* + * Licensed to the

[GitHub] [samza] bkonold commented on a change in pull request #1343: SAMZA-2353: Support standby containers with transactional state

bkonold commented on a change in pull request #1343: URL: https://github.com/apache/samza/pull/1343#discussion_r429146510 ## File path: samza-core/src/main/scala/org/apache/samza/storage/ContainerStorageManager.java ## @@ -149,22 +153,26 @@ private final int maxChangeLogStr

[GitHub] [samza] bkonold commented on a change in pull request #1343: SAMZA-2353: Support standby containers with transactional state

bkonold commented on a change in pull request #1343: URL: https://github.com/apache/samza/pull/1343#discussion_r429146954 ## File path: samza-core/src/main/scala/org/apache/samza/storage/ContainerStorageManager.java ## @@ -239,66 +253,102 @@ public ContainerStorageManager(

[jira] [Created] (SAMZA-2529) Extract interface from TaskInstance for reuse of RunLoop

Brett Konold created SAMZA-2529: --- Summary: Extract interface from TaskInstance for reuse of RunLoop Key: SAMZA-2529 URL: https://issues.apache.org/jira/browse/SAMZA-2529 Project: Samza Issue Ty

[GitHub] [samza] bkonold opened a new pull request #1366: SAMZA-2529: Extract interface from TaskInstance for reuse of RunLoop

bkonold opened a new pull request #1366: URL: https://github.com/apache/samza/pull/1366 **Issues**: Hard to reuse RunLoop for non-TaskInstance use cases because of coupling **Changes**: This is an initial pass at extracting an interface from TaskInstance. I've introduced RunLoopTas

[GitHub] [samza] prateekm commented on pull request #1366: SAMZA-2529: Extract interface from TaskInstance for reuse of RunLoop

prateekm commented on pull request #1366: URL: https://github.com/apache/samza/pull/1366#issuecomment-632841552 Thanks for the cleanup. Please get a review from @cameronlee314 and @bharathkk on this. This is an automated mes

[GitHub] [samza] mynameborat commented on a change in pull request #1366: SAMZA-2529: Extract interface from TaskInstance for reuse of RunLoop

mynameborat commented on a change in pull request #1366: URL: https://github.com/apache/samza/pull/1366#discussion_r429404171 ## File path: samza-core/src/main/java/org/apache/samza/container/RunLoopTask.java ## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundatio

[GitHub] [samza] bkonold commented on a change in pull request #1366: SAMZA-2529: Extract interface from TaskInstance for reuse of RunLoop

bkonold commented on a change in pull request #1366: URL: https://github.com/apache/samza/pull/1366#discussion_r429418245 ## File path: samza-core/src/main/java/org/apache/samza/container/RunLoopTask.java ## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation (A

[GitHub] [samza] bkonold commented on a change in pull request #1366: SAMZA-2529: Extract interface from TaskInstance for reuse of RunLoop

bkonold commented on a change in pull request #1366: URL: https://github.com/apache/samza/pull/1366#discussion_r429421367 ## File path: samza-core/src/main/java/org/apache/samza/container/RunLoopTask.java ## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation (A

[GitHub] [samza] bkonold commented on a change in pull request #1366: SAMZA-2529: Extract interface from TaskInstance for reuse of RunLoop

bkonold commented on a change in pull request #1366: URL: https://github.com/apache/samza/pull/1366#discussion_r429421558 ## File path: samza-core/src/main/java/org/apache/samza/container/RunLoopTask.java ## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation (A

[GitHub] [samza] cameronlee314 commented on a change in pull request #1364: AzureBlobSystemProducer: Enable adding of number of records in blob as metadata of the blob

cameronlee314 commented on a change in pull request #1364: URL: https://github.com/apache/samza/pull/1364#discussion_r429424131 ## File path: samza-azure/src/main/java/org/apache/samza/system/azureblob/avro/AzureBlobOutputStream.java ## @@ -230,6 +231,10 @@ public synchronized

[jira] [Created] (SAMZA-2530) Split out processing logic from TaskSideInputStorageManager

Brett Konold created SAMZA-2530: --- Summary: Split out processing logic from TaskSideInputStorageManager Key: SAMZA-2530 URL: https://issues.apache.org/jira/browse/SAMZA-2530 Project: Samza Issu

[GitHub] [samza] cameronlee314 commented on pull request #1366: SAMZA-2529: Extract interface from TaskInstance for reuse of RunLoop

cameronlee314 commented on pull request #1366: URL: https://github.com/apache/samza/pull/1366#issuecomment-632907550 What would be an example use case for `RunLoopTask`, other than `TaskInstance`? This is an automated messag

[GitHub] [samza] mynameborat commented on a change in pull request #1366: SAMZA-2529: Extract interface from TaskInstance for reuse of RunLoop

mynameborat commented on a change in pull request #1366: URL: https://github.com/apache/samza/pull/1366#discussion_r429451120 ## File path: samza-core/src/main/java/org/apache/samza/container/RunLoopTask.java ## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundatio

[GitHub] [samza] bkonold edited a comment on pull request #1366: SAMZA-2529: Extract interface from TaskInstance for reuse of RunLoop

bkonold edited a comment on pull request #1366: URL: https://github.com/apache/samza/pull/1366#issuecomment-632934829 > What would be an example use case for `RunLoopTask`, other than `TaskInstance`? @cameronlee314 This will be used as an entry point for side input processing to

[GitHub] [samza] bkonold commented on pull request #1366: SAMZA-2529: Extract interface from TaskInstance for reuse of RunLoop

bkonold commented on pull request #1366: URL: https://github.com/apache/samza/pull/1366#issuecomment-632934829 > What would be an example use case for `RunLoopTask`, other than `TaskInstance`? This will be used as an entry point for side input processing to leverage RunLoop.