[GitHub] WillemJiang commented on issue #226: SCB-741 change payloads database type from varbinary(10240) to blob

2018-07-18 Thread GitBox
WillemJiang commented on issue #226: SCB-741 change payloads database type from varbinary(10240) to blob URL: https://github.com/apache/incubator-servicecomb-saga/pull/226#issuecomment-406098697 @SingleX Thanks for the PR, We need to keep the stack trace size below 10240 at the same

[GitHub] yhs0092 opened a new pull request #820: [SCB-759] fix ServiceComb version

2018-07-18 Thread GitBox
yhs0092 opened a new pull request #820: [SCB-759] fix ServiceComb version URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/820 Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA

[GitHub] WillemJiang closed pull request #224: [SCB-750] Add missing dependency management

2018-07-18 Thread GitBox
WillemJiang closed pull request #224: [SCB-750] Add missing dependency management URL: https://github.com/apache/incubator-servicecomb-saga/pull/224 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[incubator-servicecomb-java-chassis] 02/02: [SCB-754] add an IT to test bug trigger situation

2018-07-18 Thread liubao
This is an automated email from the ASF dual-hosted git repository. liubao pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-servicecomb-java-chassis.git commit f722a00da0677c0135d2de5c3fec9de0e898bf5f Author: yaohaishi AuthorDate: Wed Jul 18 17:59:41

[GitHub] liubao68 closed pull request #817: [SCB-754] add null pointer check on AbstractRestInvocation.invocation

2018-07-18 Thread GitBox
liubao68 closed pull request #817: [SCB-754] add null pointer check on AbstractRestInvocation.invocation URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/817 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed

[incubator-servicecomb-java-chassis] branch master updated (a230404 -> f722a00)

2018-07-18 Thread liubao
This is an automated email from the ASF dual-hosted git repository. liubao pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-servicecomb-java-chassis.git. from a230404 [SCB-753]NPE when query not exists service new 8ade261 [SCB-754] add

[GitHub] coveralls edited a comment on issue #819: [SCB-755] 755 Duplicate copy cse config to Servicecomb config

2018-07-18 Thread GitBox
coveralls edited a comment on issue #819: [SCB-755] 755 Duplicate copy cse config to Servicecomb config URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/819#issuecomment-405923609 [![Coverage

[GitHub] yangbor opened a new pull request #224: [SCB-750] Add missing dependency management

2018-07-18 Thread GitBox
yangbor opened a new pull request #224: [SCB-750] Add missing dependency management URL: https://github.com/apache/incubator-servicecomb-saga/pull/224 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA

[GitHub] coveralls edited a comment on issue #224: [SCB-750] Add missing dependency management

2018-07-18 Thread GitBox
coveralls edited a comment on issue #224: [SCB-750] Add missing dependency management URL: https://github.com/apache/incubator-servicecomb-saga/pull/224#issuecomment-405516076 [![Coverage Status](https://coveralls.io/builds/18038192/badge)](https://coveralls.io/builds/18038192)

[GitHub] coveralls commented on issue #817: [SCB-754] add null pointer check on AbstractRestInvocation.invocation

2018-07-18 Thread GitBox
coveralls commented on issue #817: [SCB-754] add null pointer check on AbstractRestInvocation.invocation URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/817#issuecomment-405836488 [![Coverage

[GitHub] heyile opened a new pull request #818: [SCB-755] 755 Duplicate copy cse config to Servicecomb config

2018-07-18 Thread GitBox
heyile opened a new pull request #818: [SCB-755] 755 Duplicate copy cse config to Servicecomb config URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/818 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there

[GitHub] coveralls edited a comment on issue #224: [SCB-750] Add missing dependency management

2018-07-18 Thread GitBox
coveralls edited a comment on issue #224: [SCB-750] Add missing dependency management URL: https://github.com/apache/incubator-servicecomb-saga/pull/224#issuecomment-405516076 [![Coverage Status](https://coveralls.io/builds/18038072/badge)](https://coveralls.io/builds/18038072)

[GitHub] yhs0092 opened a new pull request #817: [SCB-754] add null pointer check on AbstractRestInvocation.invocation

2018-07-18 Thread GitBox
yhs0092 opened a new pull request #817: [SCB-754] add null pointer check on AbstractRestInvocation.invocation URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/817 Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make

[GitHub] coveralls edited a comment on issue #817: [SCB-754] add null pointer check on AbstractRestInvocation.invocation

2018-07-18 Thread GitBox
coveralls edited a comment on issue #817: [SCB-754] add null pointer check on AbstractRestInvocation.invocation URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/817#issuecomment-405836488 [![Coverage

[GitHub] yangbor closed pull request #224: [SCB-750] Add missing dependency management

2018-07-18 Thread GitBox
yangbor closed pull request #224: [SCB-750] Add missing dependency management URL: https://github.com/apache/incubator-servicecomb-saga/pull/224 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] Gannalyo opened a new issue #227: Doesn't Saga support the compensation when the value of retries is greater than naught?

2018-07-18 Thread GitBox
Gannalyo opened a new issue #227: Doesn't Saga support the compensation when the value of retries is greater than naught? URL: https://github.com/apache/incubator-servicecomb-saga/issues/227 I wrote a compensable method (**retries = 2**), its rollback method would not be called when the

[GitHub] yangbor closed pull request #224: [SCB-750] Add missing dependency management

2018-07-18 Thread GitBox
yangbor closed pull request #224: [SCB-750] Add missing dependency management URL: https://github.com/apache/incubator-servicecomb-saga/pull/224 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] yangbor opened a new pull request #224: [SCB-750] Add missing dependency management

2018-07-18 Thread GitBox
yangbor opened a new pull request #224: [SCB-750] Add missing dependency management URL: https://github.com/apache/incubator-servicecomb-saga/pull/224 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA

[GitHub] coveralls edited a comment on issue #815: [SCB-708] Aggregate simple query params into object param in spring mvc style

2018-07-18 Thread GitBox
coveralls edited a comment on issue #815: [SCB-708] Aggregate simple query params into object param in spring mvc style URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/815#issuecomment-405600040 [![Coverage

[GitHub] Gannalyo commented on issue #221: Saga executes compensation, but excludes interface which throws exception.

2018-07-18 Thread GitBox
Gannalyo commented on issue #221: Saga executes compensation, but excludes interface which throws exception. URL: https://github.com/apache/incubator-servicecomb-saga/issues/221#issuecomment-405831552 Right, it indeed save a call for the compensation of Service A. I have added the spring

[GitHub] Gannalyo closed issue #221: Saga executes compensation, but excludes interface which throws exception.

2018-07-18 Thread GitBox
Gannalyo closed issue #221: Saga executes compensation, but excludes interface which throws exception. URL: https://github.com/apache/incubator-servicecomb-saga/issues/221 This is an automated message from the Apache Git

[GitHub] liubao68 commented on a change in pull request #818: [SCB-755] 755 Duplicate copy cse config to Servicecomb config

2018-07-18 Thread GitBox
liubao68 commented on a change in pull request #818: [SCB-755] 755 Duplicate copy cse config to Servicecomb config URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/818#discussion_r203287735 ## File path:

[GitHub] heyile closed pull request #818: [SCB-755] 755 Duplicate copy cse config to Servicecomb config

2018-07-18 Thread GitBox
heyile closed pull request #818: [SCB-755] 755 Duplicate copy cse config to Servicecomb config URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/818 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for

[GitHub] liubao68 commented on a change in pull request #818: [SCB-755] 755 Duplicate copy cse config to Servicecomb config

2018-07-18 Thread GitBox
liubao68 commented on a change in pull request #818: [SCB-755] 755 Duplicate copy cse config to Servicecomb config URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/818#discussion_r203286854 ## File path:

[incubator-servicecomb-java-chassis] branch master updated: [SCB-753]NPE when query not exists service

2018-07-18 Thread liubao
This is an automated email from the ASF dual-hosted git repository. liubao pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-servicecomb-java-chassis.git The following commit(s) were added to refs/heads/master by this push: new a230404

[GitHub] liubao68 commented on a change in pull request #818: [SCB-755] 755 Duplicate copy cse config to Servicecomb config

2018-07-18 Thread GitBox
liubao68 commented on a change in pull request #818: [SCB-755] 755 Duplicate copy cse config to Servicecomb config URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/818#discussion_r203287198 ## File path:

[GitHub] liubao68 commented on a change in pull request #817: [SCB-754] add null pointer check on AbstractRestInvocation.invocation

2018-07-18 Thread GitBox
liubao68 commented on a change in pull request #817: [SCB-754] add null pointer check on AbstractRestInvocation.invocation URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/817#discussion_r203289391 ## File path:

[GitHub] liubao68 commented on a change in pull request #817: [SCB-754] add null pointer check on AbstractRestInvocation.invocation

2018-07-18 Thread GitBox
liubao68 commented on a change in pull request #817: [SCB-754] add null pointer check on AbstractRestInvocation.invocation URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/817#discussion_r203289391 ## File path:

[GitHub] liubao68 closed pull request #813: [SCB-752] provide a configuration to determine whether to output merged.log4j.properties

2018-07-18 Thread GitBox
liubao68 closed pull request #813: [SCB-752] provide a configuration to determine whether to output merged.log4j.properties URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/813 This is a PR merged from a forked repository. As GitHub hides the original diff on merge,

[incubator-servicecomb-java-chassis] branch master updated: [SCB-752] provide a configuration to determine whether to output merged.log4j.properties

2018-07-18 Thread liubao
This is an automated email from the ASF dual-hosted git repository. liubao pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-servicecomb-java-chassis.git The following commit(s) were added to refs/heads/master by this push: new 8621d7f [SCB-752]

[incubator-servicecomb-java-chassis] 01/04: [SCB-728] enhance HttpServletRequestEx to support adjust form data

2018-07-18 Thread liubao
This is an automated email from the ASF dual-hosted git repository. liubao pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-servicecomb-java-chassis.git commit 218f6e9cc82caff3f16219fd211865aaae3fd85a Author: wujimin AuthorDate: Wed Jul 11 09:28:44

[GitHub] yhs0092 commented on a change in pull request #815: [SCB-708] Aggregate simple query params into object param in spring mvc style

2018-07-18 Thread GitBox
yhs0092 commented on a change in pull request #815: [SCB-708] Aggregate simple query params into object param in spring mvc style URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/815#discussion_r203294613 ## File path:

[GitHub] liubao68 closed pull request #814: [SCB-753]NPE when query not exists service

2018-07-18 Thread GitBox
liubao68 closed pull request #814: [SCB-753]NPE when query not exists service URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/814 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] yhs0092 commented on a change in pull request #815: [SCB-708] Aggregate simple query params into object param in spring mvc style

2018-07-18 Thread GitBox
yhs0092 commented on a change in pull request #815: [SCB-708] Aggregate simple query params into object param in spring mvc style URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/815#discussion_r203294554 ## File path:

[GitHub] kkrgwbj commented on issue #811: sb版本还是1.5.x何时升级2.x

2018-07-18 Thread GitBox
kkrgwbj commented on issue #811: sb版本还是1.5.x何时升级2.x URL: https://github.com/apache/incubator-servicecomb-java-chassis/issues/811#issuecomment-406106191 但是,springboot2.x最低要求spring核心库版本为5.x 但是,你们的组件很多底层依赖的spring核心版本是4.x,这就造成了问题。

[incubator-servicecomb-java-chassis] 01/02: [SCB-754] add null pointer check on AbstractRestInvocation.invocation

2018-07-18 Thread liubao
This is an automated email from the ASF dual-hosted git repository. liubao pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-servicecomb-java-chassis.git commit 8ade261bbb519c549f6ba35dbbbf3b84d5feadab Author: yaohaishi AuthorDate: Wed Jul 18 14:51:37

[GitHub] heyile opened a new pull request #819: [SCB-755] 755 Duplicate copy cse config to Servicecomb config

2018-07-18 Thread GitBox
heyile opened a new pull request #819: [SCB-755] 755 Duplicate copy cse config to Servicecomb config URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/819 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there

[GitHub] coveralls commented on issue #819: [SCB-755] 755 Duplicate copy cse config to Servicecomb config

2018-07-18 Thread GitBox
coveralls commented on issue #819: [SCB-755] 755 Duplicate copy cse config to Servicecomb config URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/819#issuecomment-405923609 [![Coverage

[GitHub] coveralls edited a comment on issue #817: [SCB-754] add null pointer check on AbstractRestInvocation.invocation

2018-07-18 Thread GitBox
coveralls edited a comment on issue #817: [SCB-754] add null pointer check on AbstractRestInvocation.invocation URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/817#issuecomment-405836488 [![Coverage