[GitHub] [servicecomb-java-chassis] liubao68 commented on a diff in pull request #3942: [SCB-2810]support nacos discovery and registration

liubao68 commented on code in PR #3942: URL: https://github.com/apache/servicecomb-java-chassis/pull/3942#discussion_r1326683412 ## service-registry/registry-nacos/src/main/java/org/apache/servicecomb/registry/nacos/NacosDiscovery.java: ## @@ -0,0 +1,117 @@ +/* + * Licensed to

[GitHub] [servicecomb-java-chassis] chengyouling commented on a diff in pull request #3942: [SCB-2810]support nacos discovery and registration

chengyouling commented on code in PR #3942: URL: https://github.com/apache/servicecomb-java-chassis/pull/3942#discussion_r1326686815 ## service-registry/registry-nacos/src/main/java/org/apache/servicecomb/registry/nacos/NacosDiscoveryInstance.java: ## @@ -0,0 +1,133 @@ +/* + *

[GitHub] [servicecomb-java-chassis] chengyouling commented on a diff in pull request #3942: [SCB-2810]support nacos discovery and registration

chengyouling commented on code in PR #3942: URL: https://github.com/apache/servicecomb-java-chassis/pull/3942#discussion_r1326689648 ## service-registry/registry-nacos/src/main/java/org/apache/servicecomb/registry/nacos/NacosDiscoveryInstance.java: ## @@ -0,0 +1,133 @@ +/* + *

[GitHub] [servicecomb-java-chassis] liubao68 commented on a diff in pull request #3942: [SCB-2810]support nacos discovery and registration

liubao68 commented on code in PR #3942: URL: https://github.com/apache/servicecomb-java-chassis/pull/3942#discussion_r1326683998 ## service-registry/registry-nacos/src/main/java/org/apache/servicecomb/registry/nacos/NacosDiscoveryInstance.java: ## @@ -0,0 +1,133 @@ +/* + *

[GitHub] [servicecomb-java-chassis] liubao68 commented on a diff in pull request #3942: [SCB-2810]support nacos discovery and registration

liubao68 commented on code in PR #3942: URL: https://github.com/apache/servicecomb-java-chassis/pull/3942#discussion_r1326684433 ## service-registry/registry-nacos/src/main/java/org/apache/servicecomb/registry/nacos/NacosDiscoveryInstance.java: ## @@ -0,0 +1,133 @@ +/* + *

[GitHub] [servicecomb-java-chassis] liubao68 commented on a diff in pull request #3942: [SCB-2810]support nacos discovery and registration

liubao68 commented on code in PR #3942: URL: https://github.com/apache/servicecomb-java-chassis/pull/3942#discussion_r1326688133 ## demo/demo-nacos/test-client/pom.xml: ## @@ -0,0 +1,55 @@ + + + +http://maven.apache.org/POM/4.0.0;

[GitHub] [servicecomb-java-chassis] codecov-commenter commented on pull request #3942: [SCB-2810]support nacos discovery and registration

codecov-commenter commented on PR #3942: URL: https://github.com/apache/servicecomb-java-chassis/pull/3942#issuecomment-1720386630 ##

[GitHub] [servicecomb-java-chassis] chengyouling commented on a diff in pull request #3942: [SCB-2810]support nacos discovery and registration

chengyouling commented on code in PR #3942: URL: https://github.com/apache/servicecomb-java-chassis/pull/3942#discussion_r1326688661 ## service-registry/registry-nacos/src/main/java/org/apache/servicecomb/registry/nacos/NacosDiscovery.java: ## @@ -0,0 +1,117 @@ +/* + *