[GitHub] [servicecomb-toolkit] WillemJiang commented on a change in pull request #45: SCB-1570 Translate javadocs of oas-validator
WillemJiang commented on a change in pull request #45: SCB-1570 Translate javadocs of oas-validator URL: https://github.com/apache/servicecomb-toolkit/pull/45#discussion_r344532474 ## File path: oas-validator/oas-validator-compatibility/src/main/java/org/apache/servicecomb/toolkit/oasv/compatibility/validators/mediatype/MediaTypeDelInParameterNotAllowedDiffValidator.java ## @@ -28,7 +28,7 @@ import static java.util.Collections.singletonList; /** - * 不允许在Parameter.content下删除MediaType + * Delete MediaType Object under Parameter.content is not allowed Review comment: Delete -> Deleting. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-toolkit] WillemJiang commented on a change in pull request #45: SCB-1570 Translate javadocs of oas-validator
WillemJiang commented on a change in pull request #45: SCB-1570 Translate javadocs of oas-validator URL: https://github.com/apache/servicecomb-toolkit/pull/45#discussion_r344532743 ## File path: oas-validator/oas-validator-core/src/main/java/org/apache/servicecomb/toolkit/oasv/diffvalidation/api/OasObjectDiffValidatorTemplate.java ## @@ -42,7 +42,7 @@ } /** - * 处理左边没有，右边有，即新增的情况。 + * validate the adding situation, left side not exist but right side exists Review comment: There are some grammar errors. left side does not exist but right side exists This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-toolkit] WillemJiang commented on a change in pull request #45: SCB-1570 Translate javadocs of oas-validator
WillemJiang commented on a change in pull request #45: SCB-1570 Translate javadocs of oas-validator URL: https://github.com/apache/servicecomb-toolkit/pull/45#discussion_r344532535 ## File path: oas-validator/oas-validator-compatibility/src/main/java/org/apache/servicecomb/toolkit/oasv/compatibility/validators/response/ResponseAddNotAllowedDiffValidator.java ## @@ -27,7 +27,7 @@ import static java.util.Collections.singletonList; /** - * 不允许在responses.'http status code'.下新增 Response Object + * Add Response Object under responses.'http status code' is not allowed Review comment: Add-> Adding. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-toolkit] WillemJiang commented on a change in pull request #45: SCB-1570 Translate javadocs of oas-validator
WillemJiang commented on a change in pull request #45: SCB-1570 Translate javadocs of oas-validator URL: https://github.com/apache/servicecomb-toolkit/pull/45#discussion_r344532454 ## File path: oas-validator/oas-validator-compatibility/src/main/java/org/apache/servicecomb/toolkit/oasv/compatibility/validators/mediatype/MediaTypeAddInParameterNotAllowedDiffValidator.java ## @@ -28,7 +28,7 @@ import static java.util.Collections.singletonList; /** - * 不允许在Parameter.content下添加MediaType + * Add MediaType Object under Parameter.content is not allowed Review comment: Add->Adding This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
