[GitHub] liubao68 commented on a change in pull request #704: [SCB-582]Provide a way to protect instance removal
liubao68 commented on a change in pull request #704: [SCB-582]Provide a way to protect instance removal URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/704#discussion_r189175946 ## File path: demo/demo-pojo/pojo-client/src/main/resources/microservice.yaml ## @@ -23,6 +23,12 @@ servicecomb: service: registry: address: http://127.0.0.1:30100 + instance: +healthCheck: + interval: 2 +watch: false +empty: Review comment: Currently there are a lot of configurations not documented. I create a new issue to tracker this and will add docs after we have merged documents as [VOTE] done in email. https://issues.apache.org/jira/browse/SCB-594 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] liubao68 commented on a change in pull request #704: [SCB-582]Provide a way to protect instance removal
liubao68 commented on a change in pull request #704: [SCB-582]Provide a way to
protect instance removal
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/704#discussion_r189175400
##
File path:
service-registry/src/main/java/org/apache/servicecomb/serviceregistry/consumer/MicroserviceVersions.java
##
@@ -169,6 +166,28 @@ private void setInstances(List
pulledInstances, String rev
}
}
+ private List mergeInstances(List
pulledInstances,
+ List inUseInstances) {
+List upInstances = pulledInstances
+.stream()
+.filter(instance -> {
+ return MicroserviceInstanceStatus.UP.equals(instance.getStatus());
+})
+.collect(Collectors.toList());
+if (upInstances.isEmpty() && inUseInstances != null &&
ServiceRegistryConfig.INSTANCE.isEmptyInstanceProtectionEnabled()) {
+ MicroserviceInstancePing ping =
SPIServiceUtils.getPriorityHighestService(MicroserviceInstancePing.class);
+ inUseInstances.stream()
+ .forEach(instance -> {
+if (!upInstances.contains(instance)) {
+ if (ping.ping(instance)) {
Review comment:
This scenario is rarely as I explained above, mostly because of service
center bugs. And this health check run a separate background thread, will not
influence normal performance.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] liubao68 commented on a change in pull request #704: [SCB-582]Provide a way to protect instance removal
liubao68 commented on a change in pull request #704: [SCB-582]Provide a way to
protect instance removal
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/704#discussion_r188826558
##
File path:
service-registry/src/main/java/org/apache/servicecomb/serviceregistry/consumer/SimpleMicroserviceInstancePing.java
##
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.servicecomb.serviceregistry.consumer;
+
+import java.io.IOException;
+import java.net.Socket;
+
+import org.apache.servicecomb.foundation.common.net.IpPort;
+import org.apache.servicecomb.foundation.common.net.NetUtils;
+import
org.apache.servicecomb.serviceregistry.api.registry.MicroserviceInstance;
+
+/**
+ * Simple implementation of .MicroserviceInstancePing using telnet
+ */
+public class SimpleMicroserviceInstancePing implements
MicroserviceInstancePing {
+ @Override
+ public int getOrder() {
+return 100;
+ }
+
+ @Override
+ public boolean ping(MicroserviceInstance instance) {
+if (instance.getEndpoints() != null && instance.getEndpoints().size() > 0)
{
+ IpPort ipPort =
NetUtils.parseIpPortFromURI(instance.getEndpoints().get(0));
+ try (Socket s = new Socket(ipPort.getHostOrIp(), ipPort.getPort())) {
Review comment:
I have think this problem very carefully. This mechanism only work when
client get empty instances list, and we face this problem due to service center
bugs, unexpected start/stop of microservices and service center, and other
network failures not properly handled. In theory, these problems should be
properly handled and SDK do not need to care about it, but It happens very
frequently.
So we add this mechanism to make SDK itself more stable in bad
circumstances. Since SDK will query instances periodically, after there are
instances, no problem for your mentioned scenario. And if even your scenario
happens(rarely), this time, to consumer both of them are failures(no instance
vs send to wrong destination). This time is very short and acceptable. And ping
logic is extensible by users, they may cover the problem too.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] liubao68 commented on a change in pull request #704: [SCB-582]Provide a way to protect instance removal
liubao68 commented on a change in pull request #704: [SCB-582]Provide a way to
protect instance removal
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/704#discussion_r188826558
##
File path:
service-registry/src/main/java/org/apache/servicecomb/serviceregistry/consumer/SimpleMicroserviceInstancePing.java
##
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.servicecomb.serviceregistry.consumer;
+
+import java.io.IOException;
+import java.net.Socket;
+
+import org.apache.servicecomb.foundation.common.net.IpPort;
+import org.apache.servicecomb.foundation.common.net.NetUtils;
+import
org.apache.servicecomb.serviceregistry.api.registry.MicroserviceInstance;
+
+/**
+ * Simple implementation of .MicroserviceInstancePing using telnet
+ */
+public class SimpleMicroserviceInstancePing implements
MicroserviceInstancePing {
+ @Override
+ public int getOrder() {
+return 100;
+ }
+
+ @Override
+ public boolean ping(MicroserviceInstance instance) {
+if (instance.getEndpoints() != null && instance.getEndpoints().size() > 0)
{
+ IpPort ipPort =
NetUtils.parseIpPortFromURI(instance.getEndpoints().get(0));
+ try (Socket s = new Socket(ipPort.getHostOrIp(), ipPort.getPort())) {
Review comment:
I have think this problem very carefully. This mechanism only work when
client get empty instances list, and we face this problem due to service center
bugs, unexpected start/stop of microservices and service center, and other
network failures not properly handled. In theory, these problems should be
properly handled and SDK do not need to care about it, but It happens very
frequently.
So we add this mechanism to make SDK itself more stable in bad
circumstances. Since SDK will query instances periodically, after there are
instances, no problem for your mentioned scenario. And if even your scenario
happens(rarely), this time, to consumer both of them are failures(no instance
vs send to wrong destination). This time is very short and acceptable.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
