Re: [PR] [#5061] fixed service upgrade caused memory leak problem [servicecomb-java-chassis]
chengyouling closed pull request #5062: [#5061] fixed service upgrade caused memory leak problem URL: https://github.com/apache/servicecomb-java-chassis/pull/5062 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [#5061] fixed service upgrade caused memory leak problem. [servicecomb-java-chassis]
chengyouling closed pull request #5064: [#5061] fixed service upgrade caused memory leak problem. URL: https://github.com/apache/servicecomb-java-chassis/pull/5064 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [#5061] fixed service upgrade caused memory leak problem. [servicecomb-java-chassis]
chengyouling commented on code in PR #5064:
URL:
https://github.com/apache/servicecomb-java-chassis/pull/5064#discussion_r274520
##
foundations/foundation-registry/src/main/java/org/apache/servicecomb/registry/swagger/SwaggerLoader.java:
##
@@ -212,4 +214,15 @@ private Swagger loadFromRemote(Microservice microservice,
Collection instances) {
+if (CollectionUtils.isEmpty(instances)) {
+ return;
+}
+String serviceId = instances.get(0).getServiceId();
+int originSize = remoteSwagger.size();
+remoteSwagger.remove(serviceId);
Review Comment:
应该不会，这个删除是每次注册中心的实例变化之后刷的
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] [#5061] fixed service upgrade caused memory leak problem [servicecomb-java-chassis]
chengyouling commented on code in PR #5062:
URL:
https://github.com/apache/servicecomb-java-chassis/pull/5062#discussion_r2745288265
##
foundations/foundation-registry/src/main/java/org/apache/servicecomb/registry/swagger/SwaggerLoader.java:
##
@@ -181,7 +181,9 @@ private Swagger loadFromResource(String path) {
private Swagger loadFromRemote(Microservice microservice,
Collection instances,
String schemaId) {
-String key = microservice.getServiceId() + "." + schemaId;
+// The client does not restart, the serviceId changes after the provider
is upgraded. As a result,
+// the same schema is loaded repeatedly.
+String key = microservice.getServiceName() + "." + schemaId;
Review Comment:
应该不会，这个删除是每次注册中心的实例变化之后刷的
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] [#5061] fixed service upgrade caused memory leak problem. [servicecomb-java-chassis]
yanghao605 commented on code in PR #5064:
URL:
https://github.com/apache/servicecomb-java-chassis/pull/5064#discussion_r2739751398
##
foundations/foundation-registry/src/main/java/org/apache/servicecomb/registry/swagger/SwaggerLoader.java:
##
@@ -212,4 +214,15 @@ private Swagger loadFromRemote(Microservice microservice,
Collection instances) {
+if (CollectionUtils.isEmpty(instances)) {
+ return;
+}
+String serviceId = instances.get(0).getServiceId();
+int originSize = remoteSwagger.size();
+remoteSwagger.remove(serviceId);
Review Comment:
这种移除方法应该只能移除一个吧
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] [#5061] fixed service upgrade caused memory leak problem [servicecomb-java-chassis]
yanghao605 commented on code in PR #5062:
URL:
https://github.com/apache/servicecomb-java-chassis/pull/5062#discussion_r2739792802
##
foundations/foundation-registry/src/main/java/org/apache/servicecomb/registry/swagger/SwaggerLoader.java:
##
@@ -181,7 +181,9 @@ private Swagger loadFromResource(String path) {
private Swagger loadFromRemote(Microservice microservice,
Collection instances,
String schemaId) {
-String key = microservice.getServiceId() + "." + schemaId;
+// The client does not restart, the serviceId changes after the provider
is upgraded. As a result,
+// the same schema is loaded repeatedly.
+String key = microservice.getServiceName() + "." + schemaId;
Review Comment:
这个修改会不会导致丢失最新的契约数据
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] [#5061] fixed service upgrade caused memory leak problem. [servicecomb-java-chassis]
yanghao605 commented on PR #5064: URL: https://github.com/apache/servicecomb-java-chassis/pull/5064#issuecomment-3815254307 这个修改能修复这个问题吗？DestroyMicroserviceEvent 事件看着是微服务信息被删除或者是更新实例时出现异常才会删除，如果只是频繁变更版本号应该不会触发吧 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
[PR] [#5061] fixed service upgrade caused memory leak problem. [servicecomb-java-chassis]
chengyouling opened a new pull request, #5064: URL: https://github.com/apache/servicecomb-java-chassis/pull/5064 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install -Pit` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
[PR] [#5061] fixed service upgrade caused memory leak problem [servicecomb-java-chassis]
chengyouling opened a new pull request, #5062: URL: https://github.com/apache/servicecomb-java-chassis/pull/5062 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install -Pit` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
