This is an automated email from the ASF dual-hosted git repository. tianxiaoliang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/servicecomb-kie.git
The following commit(s) were added to refs/heads/master by this push: new feeacdf fix status don't update (#125) feeacdf is described below commit feeacdfa33c65de0a2830f07e72f42a90e930c84 Author: GuoYL <53255576+guoyl...@users.noreply.github.com> AuthorDate: Thu Mar 26 09:21:38 2020 +0800 fix status don't update (#125) * fix status/value_type don't update * modify unit test * delete value_type --- server/resource/v1/history_resource_test.go | 7 +++---- server/service/mongo/kv/kv_dao.go | 1 + 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/server/resource/v1/history_resource_test.go b/server/resource/v1/history_resource_test.go index 82d6d2b..63614a9 100644 --- a/server/resource/v1/history_resource_test.go +++ b/server/resource/v1/history_resource_test.go @@ -90,8 +90,8 @@ func TestHistoryResource_GetPollingData(t *testing.T) { t.Run("list kv by service label, to create a polling data", func(t *testing.T) { r, _ := http.NewRequest("GET", "/v1/test/kie/kv", nil) noopH := &handler2.NoopAuthHandler{} - noopH2 := &handler2.TrackHandler{} - chain, _ := handler.CreateChain(common.Provider, "testchain3", noopH.Name(), noopH2.Name()) + trackH := &handler2.TrackHandler{} + chain, _ := handler.CreateChain(common.Provider, "testchain3", noopH.Name(), trackH.Name()) r.Header.Set("Content-Type", "application/json") r.Header.Set("X-Session-Id", "test") kvr := &v1.KVResource{} @@ -108,8 +108,7 @@ func TestHistoryResource_GetPollingData(t *testing.T) { t.Run("get polling data", func(t *testing.T) { r, _ := http.NewRequest("GET", "/v1/test/kie/track?sessionId=test", nil) noopH := &handler2.NoopAuthHandler{} - track := handler2.TrackHandler{} - chain, _ := handler.CreateChain(common.Provider, "testchain3", noopH.Name(), track.Name()) + chain, _ := handler.CreateChain(common.Provider, "testchain3", noopH.Name()) r.Header.Set("Content-Type", "application/json") revision := &v1.HistoryResource{} c, err := restfultest.New(revision, chain) diff --git a/server/service/mongo/kv/kv_dao.go b/server/service/mongo/kv/kv_dao.go index 059264c..0b3a49c 100644 --- a/server/service/mongo/kv/kv_dao.go +++ b/server/service/mongo/kv/kv_dao.go @@ -82,6 +82,7 @@ func updateKeyValue(ctx context.Context, kv *model.KVDoc) error { ur, err := collection.UpdateOne(ctx, bson.M{"key": kv.Key, "label_id": kv.LabelID}, bson.D{ {"$set", bson.D{ {"value", kv.Value}, + {"status", kv.Status}, {"checker", kv.Checker}, {"update_revision", kv.UpdateRevision}, }},