Re: [PR] [#3960]fix vertx close may block shutdown [servicecomb-java-chassis]
liubao68 merged PR #3965: URL: https://github.com/apache/servicecomb-java-chassis/pull/3965 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@servicecomb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [#3960]fix vertx close may block shutdown [servicecomb-java-chassis]
codecov-commenter commented on PR #3965: URL: https://github.com/apache/servicecomb-java-chassis/pull/3965#issuecomment-1754266612 ## [Codecov](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/3965?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report > Merging [#3965](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/3965?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) (8c88c18) into [2.8.x](https://app.codecov.io/gh/apache/servicecomb-java-chassis/commit/863e8871a71d5a6250dd756cc7b8558976735608?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) (863e887) will **decrease** coverage by `0.02%`. > The diff coverage is `66.66%`. > :exclamation: Current head 8c88c18 differs from pull request most recent head 0be5c46. Consider uploading reports for the commit 0be5c46 to get more accurate results ```diff @@ Coverage Diff @@ ## 2.8.x#3965 +/- ## - Coverage 74.23% 74.21% -0.02% Complexity 703 703 Files 1597 1597 Lines 4017040170 Branches 3669 3669 - Hits 2982029814 -6 - Misses 8860 8864 +4 - Partials 1490 1492 +2 ``` | [Files](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/3965?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Coverage Δ | | |---|---|---| | [...pache/servicecomb/foundation/vertx/VertxUtils.java](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/3965?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi12ZXJ0eC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvZm91bmRhdGlvbi92ZXJ0eC9WZXJ0eFV0aWxzLmphdmE=) | `78.75% <66.66%> (ø)` | | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/3965/indirect-changes?src=pr=tree-more_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@servicecomb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [#3960]fix vertx close may block shutdown [servicecomb-java-chassis]
liubao68 merged PR #3964: URL: https://github.com/apache/servicecomb-java-chassis/pull/3964 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@servicecomb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [#3960]fix vertx close may block shutdown [servicecomb-java-chassis]
codecov-commenter commented on PR #3964: URL: https://github.com/apache/servicecomb-java-chassis/pull/3964#issuecomment-1754232957 ## [Codecov](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/3964?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report > Merging [#3964](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/3964?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) (3d36937) into [master](https://app.codecov.io/gh/apache/servicecomb-java-chassis/commit/a72776737e794d8e0c76b2a62647197b0d7952e3?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) (a727767) will **decrease** coverage by `0.04%`. > The diff coverage is `0.00%`. > :exclamation: Current head 3d36937 differs from pull request most recent head d965ae2. Consider uploading reports for the commit d965ae2 to get more accurate results ```diff @@ Coverage Diff @@ ## master#3964 +/- ## - Coverage 43.34% 43.31% -0.04% + Complexity 5282 5277 -5 Files 1397 1397 Lines 3411634116 Branches 3339 3339 - Hits 1478914776 -13 - Misses1813918154 +15 + Partials 1188 1186 -2 ``` | [Files](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/3964?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Coverage Δ | | |---|---|---| | [...pache/servicecomb/foundation/vertx/VertxUtils.java](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/3964?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi12ZXJ0eC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvZm91bmRhdGlvbi92ZXJ0eC9WZXJ0eFV0aWxzLmphdmE=) | `40.00% <0.00%> (ø)` | | ... and [7 files with indirect coverage changes](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/3964/indirect-changes?src=pr=tree-more_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@servicecomb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
