> -----Original Message-----
> From: s...@apache.org [mailto:s...@apache.org]
> Sent: donderdag 11 augustus 2011 21:29
> To: commits@subversion.apache.org
> Subject: svn commit: r1156756 -
> /subversion/trunk/subversion/libsvn_client/patch.c
> 
> Author: stsp
> Date: Thu Aug 11 19:29:25 2011
> New Revision: 1156756
> 
> URL: http://svn.apache.org/viewvc?rev=1156756&view=rev
> Log:
> * subversion/libsvn_client/patch.c
>   (resolve_target_path): Rename LOCAL_ABSPATH parameter to the more
> obvious
>    WCROOT_ABSPATH. It is the absolute path of the working copy root.
>   (choose_target_filename): Rename BASE_DIR parameter to
> WCROOT_ABSPATH for
>    the same reason.

Looking at the callers this argument is not necessary the real wcroot, but just 
the directory where the path is applied to. 
(svn_client_patch performs baton.abs_wc_path = wc_dir_abspath which is then 
used for wcroot_abspath for this function).

As I don't think the working copy root is the only valid patch target, I think 
this argument should have a different name.

        Bert

Reply via email to