This is an automated email from the ASF dual-hosted git repository. graceguo pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-superset.git
The following commit(s) were added to refs/heads/master by this push: new 5768a1f for 48 columns layout, adjust default size and layout for newly added slices (#4446) 5768a1f is described below commit 5768a1fe5e17f036a9c2f48afd91753e2ab6668d Author: Grace Guo <grace....@airbnb.com> AuthorDate: Mon Feb 19 00:05:57 2018 -0800 for 48 columns layout, adjust default size and layout for newly added slices (#4446) --- superset/assets/javascripts/dashboard/reducers.js | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/superset/assets/javascripts/dashboard/reducers.js b/superset/assets/javascripts/dashboard/reducers.js index 1e37aca..cbbb263 100644 --- a/superset/assets/javascripts/dashboard/reducers.js +++ b/superset/assets/javascripts/dashboard/reducers.js @@ -39,16 +39,21 @@ export function getInitialState(bootstrapData) { dashboard.posDict[position.slice_id] = position; }); } - dashboard.slices.forEach((slice, index) => { + const lastRowId = Math.max.apply(null, + dashboard.position_json.map(pos => (pos.row + pos.size_y))); + let newSliceCounter = 0; + dashboard.slices.forEach((slice) => { const sliceId = slice.slice_id; let pos = dashboard.posDict[sliceId]; if (!pos) { + // append new slices to dashboard bottom, 3 slices per row pos = { - col: (index * 4 + 1) % 12, - row: Math.floor((index) / 3) * 4, - size_x: 4, - size_y: 4, + col: (newSliceCounter % 3) * 16 + 1, + row: lastRowId + Math.floor(newSliceCounter / 3) * 16, + size_x: 16, + size_y: 16, }; + newSliceCounter++; } dashboard.layout.push({ -- To stop receiving notification emails like this one, please contact grace...@apache.org.