[GitHub] robertdale commented on issue #1062: TINKERPOP-2163 Improved performance of JavaTranslator method selection

2019-02-20 Thread GitBox
robertdale commented on issue #1062: TINKERPOP-2163 Improved performance of JavaTranslator method selection URL: https://github.com/apache/tinkerpop/pull/1062#issuecomment-465828676 `docker/build.sh -i -t` success VOTE +1

[GitHub] robertdale commented on issue #1066: Bump dependencies for httpclient, commons-codec, slf4j

2019-02-20 Thread GitBox
robertdale commented on issue #1066: Bump dependencies for httpclient, commons-codec, slf4j URL: https://github.com/apache/tinkerpop/pull/1066#issuecomment-465833842 dep tree looks good packages look good VOTE +1 This

[GitHub] spmallette commented on issue #1064: TINKERPOP-2159 EventStrategy doesn't handle multi-valued properties

2019-02-20 Thread GitBox
spmallette commented on issue #1064: TINKERPOP-2159 EventStrategy doesn't handle multi-valued properties URL: https://github.com/apache/tinkerpop/pull/1064#issuecomment-465604811 hmm - not sure what to do with this one. it doesn't appear to be fixable without a breaking change. also, if

[GitHub] robertdale commented on issue #1061: TINKERPOP-2134 Bump to Groovy 2.5.6

2019-02-20 Thread GitBox
robertdale commented on issue #1061: TINKERPOP-2134 Bump to Groovy 2.5.6 URL: https://github.com/apache/tinkerpop/pull/1061#issuecomment-465646130 Building... This is an automated message from the Apache Git Service. To

[GitHub] dkuppitz commented on issue #1064: TINKERPOP-2159 EventStrategy doesn't handle multi-valued properties

2019-02-20 Thread GitBox
dkuppitz commented on issue #1064: TINKERPOP-2159 EventStrategy doesn't handle multi-valued properties URL: https://github.com/apache/tinkerpop/pull/1064#issuecomment-465651139 Well, the way it works now (in this PR) kinda makes sense. The current behavior has not been changed, new code

[tinkerpop] branch TINKERPOP-2165 updated (960ef4d -> a559632)

2019-02-20 Thread spmallette
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a change to branch TINKERPOP-2165 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git. discard 960ef4d TINKERPOP-2165 Preferred commons-lang3 to commons-lang new a559632 TINKERPOP-2165

[tinkerpop] branch TINKERPOP-2165 updated (832d1a7 -> 44bfc7f)

2019-02-20 Thread spmallette
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a change to branch TINKERPOP-2165 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git. discard 832d1a7 TINKERPOP-2165 Preferred commons-lang3 to commons-lang new 44bfc7f TINKERPOP-2165

[GitHub] spmallette opened a new pull request #1068: TINKERPOP-2165 Preferred commons-lang3 to commons-lang

2019-02-20 Thread GitBox
spmallette opened a new pull request #1068: TINKERPOP-2165 Preferred commons-lang3 to commons-lang URL: https://github.com/apache/tinkerpop/pull/1068 https://issues.apache.org/jira/browse/TINKERPOP-2165 `commons-lang` is still part of TinkerPop because of `commons-configuration`

[tinkerpop] branch TINKERPOP-2165 updated (a559632 -> 832d1a7)

2019-02-20 Thread spmallette
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a change to branch TINKERPOP-2165 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git. discard a559632 TINKERPOP-2165 Preferred commons-lang3 to commons-lang new 832d1a7 TINKERPOP-2165

[GitHub] robertdale edited a comment on issue #1061: TINKERPOP-2134 Bump to Groovy 2.5.6

2019-02-20 Thread GitBox
robertdale edited a comment on issue #1061: TINKERPOP-2134 Bump to Groovy 2.5.6 URL: https://github.com/apache/tinkerpop/pull/1061#issuecomment-465646130 Building... `sh docker/build.sh -i -t` SUCCESS This is an

[GitHub] robertdale edited a comment on issue #1061: TINKERPOP-2134 Bump to Groovy 2.5.6

2019-02-20 Thread GitBox
robertdale edited a comment on issue #1061: TINKERPOP-2134 Bump to Groovy 2.5.6 URL: https://github.com/apache/tinkerpop/pull/1061#issuecomment-465646130 Building... `sh docker/build.sh -i -t` SUCCESS VOTE +1

[GitHub] jorgebay commented on issue #1067: TINKERPOP-2164: Reduce chance of hash collisions in Bytecode and its inner classes

2019-02-20 Thread GitBox
jorgebay commented on issue #1067: TINKERPOP-2164: Reduce chance of hash collisions in Bytecode and its inner classes URL: https://github.com/apache/tinkerpop/pull/1067#issuecomment-465490694 Can we add some unit tests around this? For example: - assert that different instances with