Merge branch 'TINKERPOP-1410'
Project: http://git-wip-us.apache.org/repos/asf/tinkerpop/repo Commit: http://git-wip-us.apache.org/repos/asf/tinkerpop/commit/4e5c30e2 Tree: http://git-wip-us.apache.org/repos/asf/tinkerpop/tree/4e5c30e2 Diff: http://git-wip-us.apache.org/repos/asf/tinkerpop/diff/4e5c30e2 Branch: refs/heads/master Commit: 4e5c30e20efc4b7f0f3107097a810632f4c81776 Parents: 108b236 7eec250 Author: Stephen Mallette <sp...@genoprime.com> Authored: Mon Apr 16 07:56:13 2018 -0400 Committer: Stephen Mallette <sp...@genoprime.com> Committed: Mon Apr 16 07:56:13 2018 -0400 ---------------------------------------------------------------------- CHANGELOG.asciidoc | 1 + docs/src/upgrade/release-3.4.x.asciidoc | 22 +++ .../gremlin/AbstractFileGraphProvider.java | 110 +++++++++++ .../structure/io/gryo/ToyIoRegistry.java | 69 +++++++ .../gremlin/structure/io/gryo/ToyPoint.java | 109 +++++++++++ .../gremlin/structure/io/gryo/ToyTriangle.java | 119 ++++++++++++ hadoop-gremlin/pom.xml | 8 - .../gremlin/hadoop/HadoopGraphProvider.java | 85 +-------- .../gremlin/hadoop/HadoopGremlinSuite.java | 35 ---- .../structure/io/AbstractIoRegistryCheck.java | 137 ------------- .../structure/io/AbstractStorageCheck.java | 190 ------------------- .../structure/io/FileSystemStorageCheck.java | 104 ---------- .../hadoop/structure/io/gryo/ToyIoRegistry.java | 70 ------- .../hadoop/structure/io/gryo/ToyPoint.java | 113 ----------- .../hadoop/structure/io/gryo/ToyTriangle.java | 120 ------------ spark-gremlin/pom.xml | 57 ------ .../gremlin/hadoop/HadoopGremlinSuite.java | 35 ++++ .../structure/io/AbstractIoRegistryCheck.java | 136 +++++++++++++ .../structure/io/AbstractStorageCheck.java | 190 +++++++++++++++++++ .../structure/io/FileSystemStorageCheck.java | 104 ++++++++++ .../computer/SparkHadoopGraphProvider.java | 59 +++++- .../gremlin/spark/util/SugarTestHelper.java | 4 +- 22 files changed, 955 insertions(+), 922 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/4e5c30e2/CHANGELOG.asciidoc ---------------------------------------------------------------------- diff --cc CHANGELOG.asciidoc index 234d456,c577eea..d63e91a --- a/CHANGELOG.asciidoc +++ b/CHANGELOG.asciidoc @@@ -25,8 -25,8 +25,9 @@@ NEED AND IMAG This release also includes changes from <<release-3-3-2, 3.3.2>>. +* `min()` and `max()` now support all types implementing `Comparable`. * Change the `toString()` of `Path` to be standardized as other graph elements are. + * `hadoop-gremlin` no longer generates a test artifact. * Fixed a bug in `ReducingBarrierStep`, that returned the provided seed value despite no elements being available. * Changed the order of `select()` scopes. The order is now: maps, side-effects, paths. * Removed support for Giraph. http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/4e5c30e2/docs/src/upgrade/release-3.4.x.asciidoc ---------------------------------------------------------------------- diff --cc docs/src/upgrade/release-3.4.x.asciidoc index 57a6fdb,bdf443e..f29df13 --- a/docs/src/upgrade/release-3.4.x.asciidoc +++ b/docs/src/upgrade/release-3.4.x.asciidoc @@@ -155,3 -122,25 +155,25 @@@ gremlin> g.V(1) ---- See: link:https://issues.apache.org/jira/browse/TINKERPOP-1522[TINKERPOP-1522] + + === Upgrading for Providers + + ==== Graph Providers + + ===== Removed hadoop-gremlin Test Artifact + + The `hadoop-gremlin` module no longer generates a test jar that can be used as a test dependency in other modules. + Generally speaking, that approach tends to be a bad practice and can cause build problems with Maven that aren't always + obvious to troubleshoot. With the removal of `giraph-gremlin` for 3.4.0, it seemed even less useful to have this + test artifact present. All tests are still present. The follow provides a basic summary of how this refactoring + occurred: + + * A new `AbstractFileGraphProvider` was created in `gremlin-test` which provided a lot of the features that + `HadoopGraphProvider` was exposing. Both `HadoopGraphProvider` and `SparkHadoopGraphProvider` extend from that class + now. + * `ToyIoRegistry` and related classes were moved to `gremlin-test`. + * The various tests that validated capabilities of `Storage` have been moved to `spark-gremlin` and are part of those + tests now. Obviously, that makes those tests specific to Spark testing now. If that location creates a problem for some + reason, that decision can be revisited at some point. + -See: link:https://issues.apache.org/jira/browse/TINKERPOP-1410[TINKERPOP-1410] ++See: link:https://issues.apache.org/jira/browse/TINKERPOP-1410[TINKERPOP-1410]