[GitHub] thefliik commented on issue #1056: fix: Path#toString() variable reference bug
thefliik commented on issue #1056: fix: Path#toString() variable reference bug URL: https://github.com/apache/tinkerpop/pull/1056#issuecomment-461289124 The code in question on `tp33`: https://github.com/apache/tinkerpop/blob/tp33/gremlin-javascript/src/main/javascript/gremlin-javascript/lib/structure/graph.js#L118-L139 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] thefliik commented on issue #1056: fix: Path#toString() variable reference bug
thefliik commented on issue #1056: fix: Path#toString() variable reference bug URL: https://github.com/apache/tinkerpop/pull/1056#issuecomment-461259403 @jorgebay in the `tp33` branch it looks like the Path#toString() method has been removed entirely, so when/if that branch is merged into master this PR will be unnecessary. Feel free to close. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] thefliik commented on issue #1056: fix: Path#toString() variable reference bug
thefliik commented on issue #1056: fix: Path#toString() variable reference bug URL: https://github.com/apache/tinkerpop/pull/1056#issuecomment-460794039 Seperately, would you be interested in a PR to port the whole javascript library over to typescript? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
