[GitHub] [incubator-tvm] zhiics edited a comment on pull request #5932: [Frontend][Relay] Add Parser 2.0

2020-06-29 Thread GitBox
zhiics edited a comment on pull request #5932: URL: https://github.com/apache/incubator-tvm/pull/5932#issuecomment-651437762 I agree we should incrementally add the support of these language features to make review smoother.

[GitHub] [incubator-tvm] kazum commented on pull request #5857: [OpenCL] Fix OpenCL get_valid_counts errors due to intrinsic atomic_add

2020-06-29 Thread GitBox
kazum commented on pull request #5857: URL: https://github.com/apache/incubator-tvm/pull/5857#issuecomment-651451372 Thanks @trevor-m @wpan11nv ! This is an automated message from the Apache Git Service. To respond to the

[incubator-tvm] branch master updated (ef804b7 -> b3d3ff2)

2020-06-29 Thread kazum
This is an automated email from the ASF dual-hosted git repository. kazum pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from ef804b7 [TIR][ANALYSIS] Refine side effect analysis. (#5954) add b3d3ff2 [OpenCL] Fix OpenCL

[GitHub] [incubator-tvm] kazum merged pull request #5857: [OpenCL] Fix OpenCL get_valid_counts errors due to intrinsic atomic_add

2020-06-29 Thread GitBox
kazum merged pull request #5857: URL: https://github.com/apache/incubator-tvm/pull/5857 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-tvm] MarisaKirisame commented on a change in pull request #5941: Amendments for gradients

2020-06-29 Thread GitBox
MarisaKirisame commented on a change in pull request #5941: URL: https://github.com/apache/incubator-tvm/pull/5941#discussion_r447318960 ## File path: src/relay/op/tensor/transform.cc ## @@ -1713,6 +1713,54 @@ RELAY_REGISTER_OP("collapse_sum_like")

[GitHub] [incubator-tvm] jroesch commented on pull request #5932: [Frontend][Relay] Add Parser 2.0

2020-06-29 Thread GitBox
jroesch commented on pull request #5932: URL: https://github.com/apache/incubator-tvm/pull/5932#issuecomment-651433312 cc @antinucleon and @jwfromm This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-tvm] MarisaKirisame commented on pull request #5941: Amendments for gradients

2020-06-29 Thread GitBox
MarisaKirisame commented on pull request #5941: URL: https://github.com/apache/incubator-tvm/pull/5941#issuecomment-651426510 > We add a collapse_sum_to instruction mirroring the collapse_sum_like. While for general definitions (potentially dynamic shapes), collapse_sum_like is the

[GitHub] [incubator-tvm] zhiics commented on pull request #5932: [Frontend][Relay] Add Parser 2.0

2020-06-29 Thread GitBox
zhiics commented on pull request #5932: URL: https://github.com/apache/incubator-tvm/pull/5932#issuecomment-651437762 I agree we should incrementally add the support of these language features to make review more smooth.

[GitHub] [incubator-tvm] jroesch commented on pull request #5932: [Frontend][Relay] Add Parser 2.0

2020-06-29 Thread GitBox
jroesch commented on pull request #5932: URL: https://github.com/apache/incubator-tvm/pull/5932#issuecomment-651432640 I just marked this as ready for review, my suggestion is that we review the existing code and land it in an experimental state. I will finish the metadata parsing and

[GitHub] [incubator-tvm] leonwanghui commented on pull request #5892: Add TVM application extension with WASM runtime

2020-06-29 Thread GitBox
leonwanghui commented on pull request #5892: URL: https://github.com/apache/incubator-tvm/pull/5892#issuecomment-651463246 Thanks @tqchen, it seems promising to me. I will finish the PoC and update this PR later. This is an

[GitHub] [incubator-tvm] FrozenGene commented on pull request #5914: [clflush] Enable x86 cpu cache flush

2020-06-29 Thread GitBox
FrozenGene commented on pull request #5914: URL: https://github.com/apache/incubator-tvm/pull/5914#issuecomment-651477619 > How about we go with A1 for now, @FrozenGene can you update this PR to A1? OK. I will implement this PR to A1 next.

[GitHub] [incubator-tvm] jroesch commented on pull request #5932: [Frontend][Relay] Add Parser 2.0

2020-06-29 Thread GitBox
jroesch commented on pull request #5932: URL: https://github.com/apache/incubator-tvm/pull/5932#issuecomment-651432041 cc @MarisaKirisame @joshpoll @wweic @zhiics This is an automated message from the Apache Git Service. To

[incubator-tvm] branch master updated (b3d3ff2 -> 5d445ca)

2020-06-29 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from b3d3ff2 [OpenCL] Fix OpenCL get_valid_counts errors due to intrinsic atomic_add (#5857) add 5d445ca

[GitHub] [incubator-tvm] tqchen merged pull request #5956: Fix some typo errors in license header

2020-06-29 Thread GitBox
tqchen merged pull request #5956: URL: https://github.com/apache/incubator-tvm/pull/5956 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[incubator-tvm] branch master updated: Amendments for gradients (#5941)

2020-06-29 Thread marisa
This is an automated email from the ASF dual-hosted git repository. marisa pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git The following commit(s) were added to refs/heads/master by this push: new 2e04393 Amendments for gradients

[GitHub] [incubator-tvm] MarisaKirisame merged pull request #5941: Amendments for gradients

2020-06-29 Thread GitBox
MarisaKirisame merged pull request #5941: URL: https://github.com/apache/incubator-tvm/pull/5941 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-tvm] MarisaKirisame commented on pull request #5959: Make first order gradient graphs more efficient

2020-06-29 Thread GitBox
MarisaKirisame commented on pull request #5959: URL: https://github.com/apache/incubator-tvm/pull/5959#issuecomment-651507650 @t-vi please rebase. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-tvm] MarisaKirisame merged pull request #5946: [RELAY][GRAD] handle Tuple/TupleGetItem in first order gradient

2020-06-29 Thread GitBox
MarisaKirisame merged pull request #5946: URL: https://github.com/apache/incubator-tvm/pull/5946 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[incubator-tvm] branch master updated (5d445ca -> 957aefb)

2020-06-29 Thread marisa
This is an automated email from the ASF dual-hosted git repository. marisa pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 5d445ca Fix some typo errors in license header (#5956) add 957aefb [RELAY][GRAD] handle

[GitHub] [incubator-tvm] trevor-m opened a new pull request #5961: [Relay/TOPI][OP] Add meshgrid op in Relay, TOPI, Pytorch frontend

2020-06-29 Thread GitBox
trevor-m opened a new pull request #5961: URL: https://github.com/apache/incubator-tvm/pull/5961 This PR adds the `meshgrid` op to relay. It matches the results of Pytorch's meshgrid: https://pytorch.org/docs/master/generated/torch.meshgrid.html And numpy's meshgrid with `ij`

[GitHub] [incubator-tvm] zhiics commented on pull request #5961: [Relay/TOPI][OP] Add meshgrid op in Relay, TOPI, Pytorch frontend

2020-06-29 Thread GitBox
zhiics commented on pull request #5961: URL: https://github.com/apache/incubator-tvm/pull/5961#issuecomment-651406131 @trevor-m please fix the linting issue. @siju-samuel @masahi @alexwong please help review the PR. Thanks.

[GitHub] [incubator-tvm] trevor-m commented on pull request #5857: [OpenCL] Fix OpenCL get_valid_counts errors due to intrinsic atomic_add

2020-06-29 Thread GitBox
trevor-m commented on pull request #5857: URL: https://github.com/apache/incubator-tvm/pull/5857#issuecomment-651368469 @kazum @tqchen Rebased and CI passed. Thanks! This is an automated message from the Apache Git Service.

[GitHub] [incubator-tvm] t-vi commented on a change in pull request #5946: [RELAY][GRAD] handle Tuple/TupleGetItem in first order gradient

2020-06-29 Thread GitBox
t-vi commented on a change in pull request #5946: URL: https://github.com/apache/incubator-tvm/pull/5946#discussion_r447259517 ## File path: src/relay/transforms/gradient.cc ## @@ -106,14 +106,67 @@ struct ADValueNode { } }; +Expr MultiZerosType(const Type& t) { + if

[GitHub] [incubator-tvm] zhiics commented on pull request #5958: [REFACTOR][RELAY] Move invoke_tvm_op and shape_func to vm dialect

2020-06-29 Thread GitBox
zhiics commented on pull request #5958: URL: https://github.com/apache/incubator-tvm/pull/5958#issuecomment-651371399 @jroesch aah, I am just separating them into memory and vm namespaces. For example, `AllocTensor` and `AllocStorage` are memory dialects (relay.op.memory.alloc_tensor),

[GitHub] [incubator-tvm] t-vi commented on a change in pull request #5946: [RELAY][GRAD] handle Tuple/TupleGetItem in first order gradient

2020-06-29 Thread GitBox
t-vi commented on a change in pull request #5946: URL: https://github.com/apache/incubator-tvm/pull/5946#discussion_r447260492 ## File path: src/relay/transforms/gradient.cc ## @@ -106,14 +106,67 @@ struct ADValueNode { } }; +Expr MultiZerosType(const Type& t) { Review

[GitHub] [incubator-tvm] junrushao1994 opened a new pull request #5960: [Target] Migrate data structure of TargetNode

2020-06-29 Thread GitBox
junrushao1994 opened a new pull request #5960: URL: https://github.com/apache/incubator-tvm/pull/5960 Per RFC: [TVM Target Specification](https://discuss.tvm.ai/t/rfc-tvm-target-specification/6844?u=junrushao1994)

[GitHub] [incubator-tvm] t-vi commented on a change in pull request #5959: Make first order gradient graphs more efficient

2020-06-29 Thread GitBox
t-vi commented on a change in pull request #5959: URL: https://github.com/apache/incubator-tvm/pull/5959#discussion_r447271340 ## File path: tests/python/relay/test_pass_gradient.py ## @@ -27,6 +29,20 @@ import tvm.relay.op as op +def count_ops(expr): Review comment:

[GitHub] [incubator-tvm] kevinthesun commented on pull request #5844: [Relay] symbolic max_output_size

2020-06-29 Thread GitBox
kevinthesun commented on pull request #5844: URL: https://github.com/apache/incubator-tvm/pull/5844#issuecomment-650945939 Thanks @yongwww This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-tvm] kevinthesun merged pull request #5844: [Relay] symbolic max_output_size

2020-06-29 Thread GitBox
kevinthesun merged pull request #5844: URL: https://github.com/apache/incubator-tvm/pull/5844 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[incubator-tvm] branch master updated: [Relay] symbolic max_output_size (#5844)

2020-06-29 Thread kevinthesun
This is an automated email from the ASF dual-hosted git repository. kevinthesun pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git The following commit(s) were added to refs/heads/master by this push: new 78d7992 [Relay] symbolic

[GitHub] [incubator-tvm] t-vi commented on a change in pull request #5941: Amendments for gradients

2020-06-29 Thread GitBox
t-vi commented on a change in pull request #5941: URL: https://github.com/apache/incubator-tvm/pull/5941#discussion_r446799560 ## File path: src/relay/op/tensor/transform.cc ## @@ -1713,6 +1713,54 @@ RELAY_REGISTER_OP("collapse_sum_like") .set_attr("FTVMCompute",

[GitHub] [incubator-tvm] kevinthesun commented on a change in pull request #5938: [TOPI] Fix x86 conv2d template when tuning with unpacked layout

2020-06-29 Thread GitBox
kevinthesun commented on a change in pull request #5938: URL: https://github.com/apache/incubator-tvm/pull/5938#discussion_r446796739 ## File path: topi/python/topi/x86/conv2d_avx_1x1.py ## @@ -89,6 +89,8 @@ def _schedule_conv_NCHWc(s, cfg, data_vec, kernel_vec, conv_out,

[GitHub] [incubator-tvm] kevinthesun commented on a change in pull request #5938: [TOPI] Fix x86 conv2d template when tuning with unpacked layout

2020-06-29 Thread GitBox
kevinthesun commented on a change in pull request #5938: URL: https://github.com/apache/incubator-tvm/pull/5938#discussion_r446796815 ## File path: topi/python/topi/x86/conv2d_avx_common.py ## @@ -111,6 +111,8 @@ def _schedule_conv_NCHWc(s, cfg, data_vec, kernel_vec,

[GitHub] [incubator-tvm] lhutton1 commented on a change in pull request #5919: [BYOC] JSON Runtime with DNNL End-to-End Flow

2020-06-29 Thread GitBox
lhutton1 commented on a change in pull request #5919: URL: https://github.com/apache/incubator-tvm/pull/5919#discussion_r446875561 ## File path: src/runtime/contrib/json/json_node.h ## @@ -0,0 +1,358 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

[GitHub] [incubator-tvm] leonwanghui opened a new pull request #5956: Fix some typo errors in license header

2020-06-29 Thread GitBox
leonwanghui opened a new pull request #5956: URL: https://github.com/apache/incubator-tvm/pull/5956 This PR is proposed to fix typo errors in some python files, so as to make the license header in the same style. Besides, the change of blank lines seems to be caused from auto-formating in

[GitHub] [incubator-tvm] t-vi commented on a change in pull request #5941: Amendments for gradients

2020-06-29 Thread GitBox
t-vi commented on a change in pull request #5941: URL: https://github.com/apache/incubator-tvm/pull/5941#discussion_r446799560 ## File path: src/relay/op/tensor/transform.cc ## @@ -1713,6 +1713,54 @@ RELAY_REGISTER_OP("collapse_sum_like") .set_attr("FTVMCompute",

[GitHub] [incubator-tvm] kazum commented on pull request #5052: [TARGET] ONNX codegen

2020-06-29 Thread GitBox
kazum commented on pull request #5052: URL: https://github.com/apache/incubator-tvm/pull/5052#issuecomment-651002585 @maheshambule Can you rebase this PR onto the latest master? I think you need to update your code to address the changes in #5770.

[GitHub] [incubator-tvm] lsy643 opened a new pull request #5955: Register Shape Func for Floor Operator

2020-06-29 Thread GitBox
lsy643 opened a new pull request #5955: URL: https://github.com/apache/incubator-tvm/pull/5955 Register the shape function for `floor` operator. Otherwise, a bug will happen when input of floor is any. Thanks for contributing to TVM! Please refer to guideline

[GitHub] [incubator-tvm] giuseros edited a comment on pull request #5925: Fix small typo in nn.conv2d_gemm_weight_transform

2020-06-29 Thread GitBox
giuseros edited a comment on pull request #5925: URL: https://github.com/apache/incubator-tvm/pull/5925#issuecomment-651082114 Hi @tqchen , I followed the same approach for the other conv2ds. I added a `test_conv2d_nhwc` in the `test_topi_conv2d_int8.py`. This would have caught the

[GitHub] [incubator-tvm] giuseros commented on pull request #5925: Fix small typo in nn.conv2d_gemm_weight_transform

2020-06-29 Thread GitBox
giuseros commented on pull request #5925: URL: https://github.com/apache/incubator-tvm/pull/5925#issuecomment-651082114 Hi @tqchen , I followed the same approach for the other conv2ds. I added a `test_conv2d_nhwc` in the `test_topi_conv2d_int8.py`. This would have caught the typo we

[GitHub] [incubator-tvm] mbrookhart commented on a change in pull request #5826: [DYNAMIC] Add Dynamic reshape to a dynamic namespace and add DynamicToStatic Pass

2020-06-29 Thread GitBox
mbrookhart commented on a change in pull request #5826: URL: https://github.com/apache/incubator-tvm/pull/5826#discussion_r447056086 ## File path: python/tvm/relay/op/dyn/transform.py ## @@ -0,0 +1,74 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [incubator-tvm] tqchen merged pull request #5954: [TIR][ANALYSIS] Refine side effect analysis.

2020-06-29 Thread GitBox
tqchen merged pull request #5954: URL: https://github.com/apache/incubator-tvm/pull/5954 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[incubator-tvm] branch master updated (78d7992 -> ef804b7)

2020-06-29 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 78d7992 [Relay] symbolic max_output_size (#5844) add ef804b7 [TIR][ANALYSIS] Refine side effect

[GitHub] [incubator-tvm] tqchen edited a comment on pull request #5956: Fix some typo errors in license header

2020-06-29 Thread GitBox
tqchen edited a comment on pull request #5956: URL: https://github.com/apache/incubator-tvm/pull/5956#issuecomment-651205280 cc @yzhliu Thanks @leonwanghui This is an automated message from the Apache Git Service. To

[GitHub] [incubator-tvm] tqchen closed issue #5373: [REFACTOR][TIR] Migrate HoistIfThenElse to the unified pass manager

2020-06-29 Thread GitBox
tqchen closed issue #5373: URL: https://github.com/apache/incubator-tvm/issues/5373 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [incubator-tvm] anijain2305 commented on pull request #5848: [TFLite] QNN support for TFLite 2.1.0 quantized models

2020-06-29 Thread GitBox
anijain2305 commented on pull request #5848: URL: https://github.com/apache/incubator-tvm/pull/5848#issuecomment-651205434 @u99127 @siju-samuel CI passes now. Can you please take another look? There were more changes, mostly to add unit level tests.

[GitHub] [incubator-tvm] tqchen commented on pull request #5956: Fix some typo errors in license header

2020-06-29 Thread GitBox
tqchen commented on pull request #5956: URL: https://github.com/apache/incubator-tvm/pull/5956#issuecomment-651205280 cc @yzhliu This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-tvm] tqchen commented on pull request #5914: [clflush] Enable x86 cpu cache flush

2020-06-29 Thread GitBox
tqchen commented on pull request #5914: URL: https://github.com/apache/incubator-tvm/pull/5914#issuecomment-651200012 How about we go with A1 for now, @FrozenGene can you update this PR to A1? This is an automated message

[GitHub] [incubator-tvm] lhutton1 commented on pull request #5919: [BYOC] JSON Runtime with DNNL End-to-End Flow

2020-06-29 Thread GitBox
lhutton1 commented on pull request #5919: URL: https://github.com/apache/incubator-tvm/pull/5919#issuecomment-651268600 Possibly out of scope for this PR but is there a plan to support multiple functions/sub-graphs? Currently it looks like there is only support for a single dnnl

[incubator-tvm] branch v0.6 updated: Fix some typo errors in license header (#5957)

2020-06-29 Thread liuyizhi
This is an automated email from the ASF dual-hosted git repository. liuyizhi pushed a commit to branch v0.6 in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git The following commit(s) were added to refs/heads/v0.6 by this push: new 0d0d515 Fix some typo errors in license

[GitHub] [incubator-tvm] yzhliu merged pull request #5957: Fix some typo errors in license header

2020-06-29 Thread GitBox
yzhliu merged pull request #5957: URL: https://github.com/apache/incubator-tvm/pull/5957 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-tvm] lhutton1 edited a comment on pull request #5919: [BYOC] JSON Runtime with DNNL End-to-End Flow

2020-06-29 Thread GitBox
lhutton1 edited a comment on pull request #5919: URL: https://github.com/apache/incubator-tvm/pull/5919#issuecomment-651268600 Possibly out of scope for this PR but is there a plan to support multiple functions/sub-graphs? Currently it looks like there is only support for a single dnnl

[incubator-tvm] tag v0.6.1.rc1 updated (6fa80ad -> 0d0d515)

2020-06-29 Thread liuyizhi
This is an automated email from the ASF dual-hosted git repository. liuyizhi pushed a change to tag v0.6.1.rc1 in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. *** WARNING: tag v0.6.1.rc1 was modified! *** from 6fa80ad (commit) to 0d0d515 (commit) from

[GitHub] [incubator-tvm] mbrookhart commented on a change in pull request #5826: [DYNAMIC] Add Dynamic reshape to a dynamic namespace and add DynamicToStatic Pass

2020-06-29 Thread GitBox
mbrookhart commented on a change in pull request #5826: URL: https://github.com/apache/incubator-tvm/pull/5826#discussion_r447103476 ## File path: python/tvm/relay/op/dyn/transform.py ## @@ -0,0 +1,74 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [incubator-tvm] lhutton1 commented on pull request #5919: [BYOC] JSON Runtime with DNNL End-to-End Flow

2020-06-29 Thread GitBox
lhutton1 commented on pull request #5919: URL: https://github.com/apache/incubator-tvm/pull/5919#issuecomment-651272256 > > Possibly out of scope for this PR but is there a plan to support multiple functions/sub-graphs? Currently it looks like there is only support for a single dnnl

[GitHub] [incubator-tvm] zhiics opened a new pull request #5958: [REFACTOR][RELAY] Move invoke_tvm_op and shape_func to vm dialect

2020-06-29 Thread GitBox
zhiics opened a new pull request #5958: URL: https://github.com/apache/incubator-tvm/pull/5958 This PR moves invoke_tvm_op and shape_func from memory dialect to vm dialect. @icemelon9 @jroesch @wweic This is an

[GitHub] [incubator-tvm] abergeron commented on pull request #5758: Fix the meaning of conv{1,2}d_transpose output_padding parameter.

2020-06-29 Thread GitBox
abergeron commented on pull request #5758: URL: https://github.com/apache/incubator-tvm/pull/5758#issuecomment-651238029 Sorry about the delay, I was distracted by another project. This is an automated message from the

[GitHub] [incubator-tvm] comaniac commented on pull request #5936: [CI] Install DNNL (OneDNN) to CI Environment

2020-06-29 Thread GitBox
comaniac commented on pull request #5936: URL: https://github.com/apache/incubator-tvm/pull/5936#issuecomment-651243646 HI @tqchen have you got a chance to update docker hub? Thanks. This is an automated message from the

[GitHub] [incubator-tvm] yzhliu opened a new pull request #5957: Fix some typo errors in license header

2020-06-29 Thread GitBox
yzhliu opened a new pull request #5957: URL: https://github.com/apache/incubator-tvm/pull/5957 Signed-off-by: leonwanghui This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-tvm] comaniac commented on pull request #5919: [BYOC] JSON Runtime with DNNL End-to-End Flow

2020-06-29 Thread GitBox
comaniac commented on pull request #5919: URL: https://github.com/apache/incubator-tvm/pull/5919#issuecomment-651270339 > Possibly out of scope for this PR but is there a plan to support multiple functions/sub-graphs? Currently it looks like there is only support for a single dnnl

[GitHub] [incubator-tvm] jroesch commented on issue #5947: [VOTE] Release Apache TVM (incubating) v0.6.1.rc1

2020-06-29 Thread GitBox
jroesch commented on issue #5947: URL: https://github.com/apache/incubator-tvm/issues/5947#issuecomment-651300572 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-tvm] merrymercy commented on issue #5947: [VOTE] Release Apache TVM (incubating) v0.6.1.rc1

2020-06-29 Thread GitBox
merrymercy commented on issue #5947: URL: https://github.com/apache/incubator-tvm/issues/5947#issuecomment-651300467 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-tvm] tmoreau89 commented on issue #5947: [VOTE] Release Apache TVM (incubating) v0.6.1.rc1

2020-06-29 Thread GitBox
tmoreau89 commented on issue #5947: URL: https://github.com/apache/incubator-tvm/issues/5947#issuecomment-651301091 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-tvm] ZihengJiang commented on issue #5947: [VOTE] Release Apache TVM (incubating) v0.6.1.rc1

2020-06-29 Thread GitBox
ZihengJiang commented on issue #5947: URL: https://github.com/apache/incubator-tvm/issues/5947#issuecomment-651301867 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-tvm] jroesch commented on pull request #5958: [REFACTOR][RELAY] Move invoke_tvm_op and shape_func to vm dialect

2020-06-29 Thread GitBox
jroesch commented on pull request #5958: URL: https://github.com/apache/incubator-tvm/pull/5958#issuecomment-651304866 Why change dialects? all of this machinery is probably needed for future work people want to do such as ahead of time compilation. cc @tqchen

[GitHub] [incubator-tvm] kazum commented on issue #5947: [VOTE] Release Apache TVM (incubating) v0.6.1.rc1

2020-06-29 Thread GitBox
kazum commented on issue #5947: URL: https://github.com/apache/incubator-tvm/issues/5947#issuecomment-651304553 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-tvm] comaniac commented on issue #5947: [VOTE] Release Apache TVM (incubating) v0.6.1.rc1

2020-06-29 Thread GitBox
comaniac commented on issue #5947: URL: https://github.com/apache/incubator-tvm/issues/5947#issuecomment-651326848 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-tvm] MarisaKirisame commented on a change in pull request #5946: [RELAY][GRAD] handle Tuple/TupleGetItem in first order gradient

2020-06-29 Thread GitBox
MarisaKirisame commented on a change in pull request #5946: URL: https://github.com/apache/incubator-tvm/pull/5946#discussion_r447226104 ## File path: src/relay/transforms/gradient.cc ## @@ -106,14 +106,67 @@ struct ADValueNode { } }; +Expr MultiZerosType(const Type& t)

[GitHub] [incubator-tvm] MarisaKirisame commented on a change in pull request #5959: Make first order gradient graphs more efficient

2020-06-29 Thread GitBox
MarisaKirisame commented on a change in pull request #5959: URL: https://github.com/apache/incubator-tvm/pull/5959#discussion_r447226640 ## File path: tests/python/relay/test_pass_gradient.py ## @@ -27,6 +29,20 @@ import tvm.relay.op as op +def count_ops(expr): Review

[GitHub] [incubator-tvm] tvm-archiver commented on issue #5947: [VOTE] Release Apache TVM (incubating) v0.6.1.rc1

2020-06-29 Thread GitBox
tvm-archiver commented on issue #5947: URL: https://github.com/apache/incubator-tvm/issues/5947#issuecomment-651344297 +1 (binding) I checked hashes and performed a default build on Ubuntu 20.04 on Windows 2004. Markus On Mon, Jun 29, 2020 at 12:57 PM Cody Yu wrote:

[GitHub] [incubator-tvm] tqchen commented on pull request #5753: [Draft] Support Module based interface runtime

2020-06-29 Thread GitBox
tqchen commented on pull request #5753: URL: https://github.com/apache/incubator-tvm/pull/5753#issuecomment-651292785 I will spend sometime to review the PR this week This is an automated message from the Apache Git Service.

[GitHub] [incubator-tvm] t-vi opened a new pull request #5959: Make first order gradient graphs more efficient

2020-06-29 Thread GitBox
t-vi opened a new pull request #5959: URL: https://github.com/apache/incubator-tvm/pull/5959 Previously, nodes are visited as often as they are used and each time a derivative is computed. Only at the leaves were the contributions of everything added. This patch changes this to add at

[GitHub] [incubator-tvm] t-vi commented on pull request #5959: Make first order gradient graphs more efficient

2020-06-29 Thread GitBox
t-vi commented on pull request #5959: URL: https://github.com/apache/incubator-tvm/pull/5959#issuecomment-651298087 This pull request is only about the second commit, the first is #5946 . I noticed that my gradient had many more O^3 (matmul etc.) operations than it should have and

svn commit: r40227 - in /dev/incubator/tvm/tvm-v0.6.1-rc1: apache-tvm-src-v0.6.1.rc1-incubating.tar.gz apache-tvm-src-v0.6.1.rc1-incubating.tar.gz.asc apache-tvm-src-v0.6.1.rc1-incubating.tar.gz.sha51

2020-06-29 Thread liuyizhi
Author: liuyizhi Date: Mon Jun 29 18:52:19 2020 New Revision: 40227 Log: Add v0.6.1.rc1 Modified: dev/incubator/tvm/tvm-v0.6.1-rc1/apache-tvm-src-v0.6.1.rc1-incubating.tar.gz dev/incubator/tvm/tvm-v0.6.1-rc1/apache-tvm-src-v0.6.1.rc1-incubating.tar.gz.asc

[GitHub] [incubator-tvm] jroesch commented on pull request #5932: [Frontend][Relay] Add Parser 2.0

2020-06-29 Thread GitBox
jroesch commented on pull request #5932: URL: https://github.com/apache/incubator-tvm/pull/5932#issuecomment-651316682 @weberlo I think ANTLR only provides those benefits if you assume the people working on the project actually know ANTLR, which in so far as I can tell is not true. Josh

[GitHub] [incubator-tvm] abergeron commented on pull request #5758: Fix the meaning of conv{1,2}d_transpose output_padding parameter.

2020-06-29 Thread GitBox
abergeron commented on pull request #5758: URL: https://github.com/apache/incubator-tvm/pull/5758#issuecomment-651331355 I saw that @siju-samuel added the conv3d_transpose op but with the wrong definition for output_padding. I would rather make a follow-up PR to fix that since I

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #5919: [BYOC] JSON Runtime with DNNL End-to-End Flow

2020-06-29 Thread GitBox
comaniac commented on a change in pull request #5919: URL: https://github.com/apache/incubator-tvm/pull/5919#discussion_r447230679 ## File path: src/runtime/contrib/dnnl/dnnl_json_runtime.cc ## @@ -0,0 +1,456 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [incubator-tvm] junrushao1994 commented on issue #5947: [VOTE] Release Apache TVM (incubating) v0.6.1.rc1

2020-06-29 Thread GitBox
junrushao1994 commented on issue #5947: URL: https://github.com/apache/incubator-tvm/issues/5947#issuecomment-651307711 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-tvm] MarisaKirisame commented on pull request #5959: Make first order gradient graphs more efficient

2020-06-29 Thread GitBox
MarisaKirisame commented on pull request #5959: URL: https://github.com/apache/incubator-tvm/pull/5959#issuecomment-651341474 We was thinking of using ANF then AD. But this also work. This is an automated message from the