[GitHub] [incubator-tvm] FrozenGene commented on a change in pull request #6946: [Relay] Add DefuseOps pass

FrozenGene commented on a change in pull request #6946: URL: https://github.com/apache/incubator-tvm/pull/6946#discussion_r528296240 ## File path: src/relay/transforms/defuse_ops.cc ## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

[GitHub] [incubator-tvm] tqchen edited a comment on pull request #6946: [Relay] Add DefuseOps pass

tqchen edited a comment on pull request #6946: URL: https://github.com/apache/incubator-tvm/pull/6946#issuecomment-731756031 cc @zhiics @mbrookhart it would be great if you can also take a look at it This is an automated

[GitHub] [incubator-tvm] tqchen commented on pull request #6946: [Relay] Add DefuseOps pass

tqchen commented on pull request #6946: URL: https://github.com/apache/incubator-tvm/pull/6946#issuecomment-731756031 cc @zhiics @comaniac @mbrookhart it would be great if you can also take a look at it This is an automated

[GitHub] [incubator-tvm] FrozenGene commented on a change in pull request #6945: [AutoScheduler] Task scheduler callbacks

FrozenGene commented on a change in pull request #6945: URL: https://github.com/apache/incubator-tvm/pull/6945#discussion_r528310540 ## File path: tutorials/auto_scheduler/tune_network_cuda.py ## @@ -186,7 +189,9 @@ def run_tuning(): print("Begin tuning...")

[GitHub] [incubator-tvm] tqchen commented on pull request #6917: Add Relay option to link parameters into runtime Modules

tqchen commented on pull request #6917: URL: https://github.com/apache/incubator-tvm/pull/6917#issuecomment-731762607 I did a pass on the C++ side(didn't get a chance to look at c module) the main thing to pay attentions are: - NDArray's deleter handling, need to delete the

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #6945: [AutoScheduler] Task scheduler callbacks

comaniac commented on a change in pull request #6945: URL: https://github.com/apache/incubator-tvm/pull/6945#discussion_r528309917 ## File path: tutorials/auto_scheduler/tune_network_cuda.py ## @@ -186,7 +189,9 @@ def run_tuning(): print("Begin tuning...")

[GitHub] [incubator-tvm] FrozenGene commented on a change in pull request #6945: [AutoScheduler] Task scheduler callbacks

FrozenGene commented on a change in pull request #6945: URL: https://github.com/apache/incubator-tvm/pull/6945#discussion_r528305417 ## File path: tutorials/auto_scheduler/tune_network_cuda.py ## @@ -186,7 +189,9 @@ def run_tuning(): print("Begin tuning...")

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #6917: Add Relay option to link parameters into runtime Modules

tqchen commented on a change in pull request #6917: URL: https://github.com/apache/incubator-tvm/pull/6917#discussion_r528343180 ## File path: include/tvm/tir/function.h ## @@ -150,6 +151,31 @@ class PrimFunc : public BaseFunc {

[GitHub] [incubator-tvm] tqchen commented on pull request #6917: Add Relay option to link parameters into runtime Modules

tqchen commented on pull request #6917: URL: https://github.com/apache/incubator-tvm/pull/6917#issuecomment-731762206 cc @ZihengJiang would be great if you can also take a look as the change relates to tir and PackedFunc codegen

[GitHub] [incubator-tvm] areusch commented on pull request #6917: Add Relay option to link parameters into runtime Modules

areusch commented on pull request #6917: URL: https://github.com/apache/incubator-tvm/pull/6917#issuecomment-731897300 I found a fairly serious bug, now fixed, on more complex networks. we weren't quite pulling the storage_id for each param; it just typically happens to match the

[GitHub] [incubator-tvm] areusch opened a new pull request #6947: [µTVM] Remove binutils module, no longer needed after microTVM refactor.

areusch opened a new pull request #6947: URL: https://github.com/apache/incubator-tvm/pull/6947 binutils previously implemented a bunch of stuff required because we were effectively manually linking µTVM binaries. we no longer do that, so we can delete these hooks. Moved the one run_cmd

[GitHub] [incubator-tvm] areusch commented on a change in pull request #6917: Add Relay option to link parameters into runtime Modules

areusch commented on a change in pull request #6917: URL: https://github.com/apache/incubator-tvm/pull/6917#discussion_r528398255 ## File path: src/target/llvm/codegen_params.cc ## @@ -0,0 +1,151 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] [incubator-tvm] areusch commented on a change in pull request #6917: Add Relay option to link parameters into runtime Modules

areusch commented on a change in pull request #6917: URL: https://github.com/apache/incubator-tvm/pull/6917#discussion_r528399831 ## File path: include/tvm/tir/function.h ## @@ -150,6 +151,31 @@ class PrimFunc : public BaseFunc {

[GitHub] [incubator-tvm] areusch commented on a change in pull request #6917: Add Relay option to link parameters into runtime Modules

areusch commented on a change in pull request #6917: URL: https://github.com/apache/incubator-tvm/pull/6917#discussion_r528402954 ## File path: src/runtime/rpc/rpc_module.cc ## @@ -36,6 +37,44 @@ namespace tvm { namespace runtime { +// deleter of RPC remote array +static

[GitHub] [incubator-tvm] areusch commented on a change in pull request #6917: Add Relay option to link parameters into runtime Modules

areusch commented on a change in pull request #6917: URL: https://github.com/apache/incubator-tvm/pull/6917#discussion_r528404674 ## File path: src/target/llvm/codegen_llvm.cc ## @@ -184,6 +188,104 @@ void CodeGenLLVM::AddFunctionInternal(const PrimFunc& f, bool ret_void) {

[GitHub] [incubator-tvm] areusch commented on a change in pull request #6917: Add Relay option to link parameters into runtime Modules

areusch commented on a change in pull request #6917: URL: https://github.com/apache/incubator-tvm/pull/6917#discussion_r528404724 ## File path: src/target/llvm/codegen_llvm.cc ## @@ -184,6 +188,104 @@ void CodeGenLLVM::AddFunctionInternal(const PrimFunc& f, bool ret_void) {

[GitHub] [incubator-tvm] areusch commented on a change in pull request #6917: Add Relay option to link parameters into runtime Modules

areusch commented on a change in pull request #6917: URL: https://github.com/apache/incubator-tvm/pull/6917#discussion_r528404631 ## File path: src/target/llvm/codegen_llvm.cc ## @@ -184,6 +188,104 @@ void CodeGenLLVM::AddFunctionInternal(const PrimFunc& f, bool ret_void) {

[GitHub] [incubator-tvm] areusch commented on a change in pull request #6917: Add Relay option to link parameters into runtime Modules

areusch commented on a change in pull request #6917: URL: https://github.com/apache/incubator-tvm/pull/6917#discussion_r528404842 ## File path: src/target/llvm/codegen_llvm.cc ## @@ -184,6 +188,104 @@ void CodeGenLLVM::AddFunctionInternal(const PrimFunc& f, bool ret_void) {

[GitHub] [incubator-tvm] areusch commented on a change in pull request #6917: Add Relay option to link parameters into runtime Modules

areusch commented on a change in pull request #6917: URL: https://github.com/apache/incubator-tvm/pull/6917#discussion_r528405903 ## File path: src/target/llvm/codegen_params.cc ## @@ -0,0 +1,151 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] [incubator-tvm] areusch commented on a change in pull request #6917: Add Relay option to link parameters into runtime Modules

areusch commented on a change in pull request #6917: URL: https://github.com/apache/incubator-tvm/pull/6917#discussion_r528399190 ## File path: include/tvm/tir/function.h ## @@ -150,6 +151,31 @@ class PrimFunc : public BaseFunc {

[GitHub] [incubator-tvm] areusch commented on a change in pull request #6917: Add Relay option to link parameters into runtime Modules

areusch commented on a change in pull request #6917: URL: https://github.com/apache/incubator-tvm/pull/6917#discussion_r528399151 ## File path: include/tvm/tir/function.h ## @@ -150,6 +151,31 @@ class PrimFunc : public BaseFunc {

[GitHub] [incubator-tvm] areusch commented on a change in pull request #6917: Add Relay option to link parameters into runtime Modules

areusch commented on a change in pull request #6917: URL: https://github.com/apache/incubator-tvm/pull/6917#discussion_r528400060 ## File path: src/relay/backend/graph_runtime_codegen.cc ## @@ -582,7 +596,13 @@ class GraphRuntimeCodegenModule : public runtime::ModuleNode {

[GitHub] [incubator-tvm] areusch commented on a change in pull request #6917: Add Relay option to link parameters into runtime Modules

areusch commented on a change in pull request #6917: URL: https://github.com/apache/incubator-tvm/pull/6917#discussion_r528402290 ## File path: src/runtime/graph/graph_runtime.cc ## @@ -244,6 +249,39 @@ void GraphRuntime::ShareParams(const GraphRuntime& other, dmlc::Stream*

[GitHub] [incubator-tvm] areusch commented on a change in pull request #6917: Add Relay option to link parameters into runtime Modules

areusch commented on a change in pull request #6917: URL: https://github.com/apache/incubator-tvm/pull/6917#discussion_r528403048 ## File path: src/target/llvm/codegen_llvm.cc ## @@ -184,6 +188,104 @@ void CodeGenLLVM::AddFunctionInternal(const PrimFunc& f, bool ret_void) {

[GitHub] [incubator-tvm] areusch commented on a change in pull request #6917: Add Relay option to link parameters into runtime Modules

areusch commented on a change in pull request #6917: URL: https://github.com/apache/incubator-tvm/pull/6917#discussion_r528405036 ## File path: src/target/llvm/codegen_llvm.cc ## @@ -184,6 +188,104 @@ void CodeGenLLVM::AddFunctionInternal(const PrimFunc& f, bool ret_void) {

[GitHub] [incubator-tvm] areusch commented on a change in pull request #6917: Add Relay option to link parameters into runtime Modules

areusch commented on a change in pull request #6917: URL: https://github.com/apache/incubator-tvm/pull/6917#discussion_r528398974 ## File path: include/tvm/runtime/crt/platform.h ## @@ -39,6 +41,21 @@ extern "C" { */ void __attribute__((noreturn))

[GitHub] [incubator-tvm] areusch commented on a change in pull request #6917: Add Relay option to link parameters into runtime Modules

areusch commented on a change in pull request #6917: URL: https://github.com/apache/incubator-tvm/pull/6917#discussion_r528400499 ## File path: src/runtime/graph/graph_runtime.cc ## @@ -64,14 +64,19 @@ void GraphRuntime::Run() { * processor. * \param ctxs The context of

[GitHub] [incubator-tvm] areusch commented on a change in pull request #6917: Add Relay option to link parameters into runtime Modules

areusch commented on a change in pull request #6917: URL: https://github.com/apache/incubator-tvm/pull/6917#discussion_r528400453 ## File path: src/runtime/graph/graph_runtime.cc ## @@ -64,14 +64,19 @@ void GraphRuntime::Run() { * processor. * \param ctxs The context of

[GitHub] [incubator-tvm] areusch commented on a change in pull request #6917: Add Relay option to link parameters into runtime Modules

areusch commented on a change in pull request #6917: URL: https://github.com/apache/incubator-tvm/pull/6917#discussion_r528400440 ## File path: src/runtime/graph/graph_runtime.cc ## @@ -244,6 +249,39 @@ void GraphRuntime::ShareParams(const GraphRuntime& other, dmlc::Stream*

[GitHub] [incubator-tvm] areusch commented on a change in pull request #6917: Add Relay option to link parameters into runtime Modules

areusch commented on a change in pull request #6917: URL: https://github.com/apache/incubator-tvm/pull/6917#discussion_r528404351 ## File path: src/runtime/rpc/rpc_module.cc ## @@ -36,6 +37,44 @@ namespace tvm { namespace runtime { +// deleter of RPC remote array +static

[GitHub] [incubator-tvm] areusch commented on a change in pull request #6917: Add Relay option to link parameters into runtime Modules

areusch commented on a change in pull request #6917: URL: https://github.com/apache/incubator-tvm/pull/6917#discussion_r528405505 ## File path: src/target/llvm/codegen_params.cc ## @@ -0,0 +1,151 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] [incubator-tvm] merrymercy commented on pull request #6946: [Relay] Add DefuseOps pass

merrymercy commented on pull request #6946: URL: https://github.com/apache/incubator-tvm/pull/6946#issuecomment-731827304 @FrozenGene comments are addressed This is an automated message from the Apache Git Service. To

[GitHub] [incubator-tvm] ZihengJiang commented on a change in pull request #6917: Add Relay option to link parameters into runtime Modules

ZihengJiang commented on a change in pull request #6917: URL: https://github.com/apache/incubator-tvm/pull/6917#discussion_r528394791 ## File path: src/target/llvm/codegen_llvm.cc ## @@ -184,6 +188,104 @@ void CodeGenLLVM::AddFunctionInternal(const PrimFunc& f, bool ret_void)

[GitHub] [incubator-tvm] areusch commented on a change in pull request #6917: Add Relay option to link parameters into runtime Modules

areusch commented on a change in pull request #6917: URL: https://github.com/apache/incubator-tvm/pull/6917#discussion_r528398528 ## File path: include/tvm/runtime/crt/graph_runtime.h ## @@ -61,14 +61,20 @@ typedef struct TVMGraphRuntime TVMGraphRuntime; * \brief Allocate a

[GitHub] [incubator-tvm] areusch commented on a change in pull request #6917: Add Relay option to link parameters into runtime Modules

areusch commented on a change in pull request #6917: URL: https://github.com/apache/incubator-tvm/pull/6917#discussion_r528405714 ## File path: src/target/llvm/codegen_params.cc ## @@ -0,0 +1,151 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] [incubator-tvm] areusch commented on pull request #6948: [µTVM] Allow for platform-specific malloc in runtime

areusch commented on pull request #6948: URL: https://github.com/apache/incubator-tvm/pull/6948#issuecomment-731924113 @manupa-arm @u99127 @leandron @liangfu FYI; still WIP. This is an automated message from the Apache Git

[GitHub] [incubator-tvm] alter-xp edited a comment on pull request #6928: [TF frontend] add some "Segment" and "UnsortedSegment" ops

alter-xp edited a comment on pull request #6928: URL: https://github.com/apache/incubator-tvm/pull/6928#issuecomment-731956750 when testing for unsorted_segment_mean, a single constant data will as input for strideslice op in tf graph. But tf frontend in tvm not support this situation.

[GitHub] [incubator-tvm] alter-xp commented on pull request #6928: [TF frontend] add some "Segment" and "UnsortedSegment" ops

alter-xp commented on pull request #6928: URL: https://github.com/apache/incubator-tvm/pull/6928#issuecomment-731956750 when testing for unstored_segmnet_mean, a single constant data will as input for strideslice op in tf graph. But tf frontend in tvm not support this situation. fix this

[GitHub] [incubator-tvm] merrymercy merged pull request #6946: [Relay] Add DefuseOps pass

merrymercy merged pull request #6946: URL: https://github.com/apache/incubator-tvm/pull/6946 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[incubator-tvm] branch main updated (5697440 -> dc72204)

This is an automated email from the ASF dual-hosted git repository. lmzheng pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 5697440 [DOCS] Improve windows build instruction via conda (#6944) add dc72204 [Relay] Add DefuseOps

[GitHub] [incubator-tvm] areusch opened a new pull request #6948: [µTVM] Allow for platform-specific malloc in runtime

areusch opened a new pull request #6948: URL: https://github.com/apache/incubator-tvm/pull/6948 The µTVM runtime has previously been fixed to use the builtin memory allocator. To avoid code duplication if an internal malloc is already linked, and as we look to a future where memory may

[GitHub] [incubator-tvm] alter-xp opened a new pull request #6949: [TF frontend] add support for StridedSlice to input a single constant

alter-xp opened a new pull request #6949: URL: https://github.com/apache/incubator-tvm/pull/6949 @giuseros @siju-samuel This is an automated message from the Apache Git Service. To respond to the message, please