[GitHub] [tvm] jwfromm commented on issue #7203: [Bug] [Relay] Error when compiling a simple ONNX model with Abs and PRelu

2021-01-04 Thread GitBox
jwfromm commented on issue #7203: URL: https://github.com/apache/tvm/issues/7203#issuecomment-754380843 This bug is also fixed in #7208 and was caused by the same issue as #7202. This is an automated message from the Apache

[GitHub] [tvm] insop commented on issue #7186: [Frontend][MXNet] Importer Missing Operators

2021-01-04 Thread GitBox
insop commented on issue #7186: URL: https://github.com/apache/tvm/issues/7186#issuecomment-754387174 For `_npi_stack ` : https://github.com/apache/tvm/pull/7209 is submitted. This is an automated message from the Apache Git

[GitHub] [tvm] luyaor edited a comment on pull request #7208: [Relay][Frontend][Onnx] Fix mismatch between Onnx Prelu definition and importer.

2021-01-04 Thread GitBox
luyaor edited a comment on pull request #7208: URL: https://github.com/apache/tvm/pull/7208#issuecomment-754398110 Hi @jwfromm @mbrookhart , thanks for the response and effort on this case. The PR looks good to me. I am currently working on a research project related to TVM, would

[GitHub] [tvm] luyaor commented on pull request #7208: [Relay][Frontend][Onnx] Fix mismatch between Onnx Prelu definition and importer.

2021-01-04 Thread GitBox
luyaor commented on pull request #7208: URL: https://github.com/apache/tvm/pull/7208#issuecomment-754398110 Hi @jwfromm @mbrookhart , thanks for the response and effort on this case. The PR looks good to me. I am currently working on the research project related to TVM, would like

[tvm] branch main updated (d052752 -> 23bd825)

2021-01-04 Thread zhaowu
This is an automated email from the ASF dual-hosted git repository. zhaowu pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git. from d052752 [ConvertLayout] slice_like support (#7184) add 23bd825 [AutoScheduler] Add custom build function (#7185)

[GitHub] [tvm] FrozenGene commented on pull request #7185: [AutoScheduler] Add custom build function

2021-01-04 Thread GitBox
FrozenGene commented on pull request #7185: URL: https://github.com/apache/tvm/pull/7185#issuecomment-754430231 Thanks for the great work @leowang1225 and thanks for the reviewing @jcf94 , it is merged now. This is an

[GitHub] [tvm] insop commented on a change in pull request #7164: [µTVM] Add documentation

2021-01-04 Thread GitBox
insop commented on a change in pull request #7164: URL: https://github.com/apache/tvm/pull/7164#discussion_r551695870 ## File path: docs/dev/index.rst ## @@ -396,3 +396,11 @@ Security :maxdepth: 1 security + + +microTVM +- +.. toctree:: Review comment:

[GitHub] [tvm] merrymercy commented on a change in pull request #7197: [Fix][Autoscheduler] Costmodel enhancement & bug fix for graph debug runtime

2021-01-04 Thread GitBox
merrymercy commented on a change in pull request #7197: URL: https://github.com/apache/tvm/pull/7197#discussion_r551763767 ## File path: python/tvm/auto_scheduler/cost_model/xgb_model.py ## @@ -116,12 +117,17 @@ def __init__(self, verbose_eval=25, num_warmup_sample=100,

[GitHub] [tvm] jwfromm commented on issue #7202: [Bug] [Relay] Error when compiling a simple ONNX model

2021-01-04 Thread GitBox
jwfromm commented on issue #7202: URL: https://github.com/apache/tvm/issues/7202#issuecomment-754372403 Thanks for finding this bug, it's due to a bad assumption made in Prelu conversion about the input layout. The issue is fixed in https://github.com/apache/tvm/pull/7208 and I've

[GitHub] [tvm] fantasyRqg opened a new pull request #7211: Build multi models into one system-lib

2021-01-04 Thread GitBox
fantasyRqg opened a new pull request #7211: URL: https://github.com/apache/tvm/pull/7211 Deploy models on Android & iOS platform must use system-lib. Avoid usage of `dlopen`. [bundle_deploy](https://github.com/apache/tvm/tree/main/apps/bundle_deploy) demonstrated how to deploy a

[GitHub] [tvm] insop opened a new pull request #7209: [Frontend][MXNet] add _npi_stack, issue #7186

2021-01-04 Thread GitBox
insop opened a new pull request #7209: URL: https://github.com/apache/tvm/pull/7209 - https://github.com/apache/tvm/issues/7186 - add MxNet stack, `_npi_stack` - https://mxnet.apache.org/versions/master/api/python/docs/api/np/generated/mxnet.np.stack.html?highlight=stack

[GitHub] [tvm] jwfromm commented on pull request #7208: [Relay][Frontend][Onnx] Fix mismatch between Onnx Prelu definition and importer.

2021-01-04 Thread GitBox
jwfromm commented on pull request #7208: URL: https://github.com/apache/tvm/pull/7208#issuecomment-754372193 @luyaor @mbrookhart @masahi can you guys take a look at this tiny PR? This is an automated message from the Apache

[GitHub] [tvm] jwfromm opened a new pull request #7208: [Relay][Frontend][Onnx] Fix mismatch between Onnx Prelu definition and importer.

2021-01-04 Thread GitBox
jwfromm opened a new pull request #7208: URL: https://github.com/apache/tvm/pull/7208 Our current prelu converter assumes that incoming data is in NCHW format and that the slope will have C total elements. Neither of these are actual requirements for ONNX PreLu. As pointed out in

[GitHub] [tvm] masahi opened a new pull request #7210: [VM] Per-input, data dependence speficiation for shape func

2021-01-04 Thread GitBox
masahi opened a new pull request #7210: URL: https://github.com/apache/tvm/pull/7210 Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from

[GitHub] [tvm] masahi edited a comment on pull request #7208: [Relay][Frontend][Onnx] Fix mismatch between Onnx Prelu definition and importer.

2021-01-04 Thread GitBox
masahi edited a comment on pull request #7208: URL: https://github.com/apache/tvm/pull/7208#issuecomment-754410295 Hi @luyaor you are welcome to poke at pytorch frontend too, I hope it is more robust than onnx frontend :)

[GitHub] [tvm] masahi commented on pull request #7208: [Relay][Frontend][Onnx] Fix mismatch between Onnx Prelu definition and importer.

2021-01-04 Thread GitBox
masahi commented on pull request #7208: URL: https://github.com/apache/tvm/pull/7208#issuecomment-754410295 Hi @luyaor you are welcome to poke at pytorch frontend too, I hope it is more robust then onnx frontend :) This is

[GitHub] [tvm] fantasyRqg commented on pull request #7211: Build multi models into one system-lib

2021-01-04 Thread GitBox
fantasyRqg commented on pull request #7211: URL: https://github.com/apache/tvm/pull/7211#issuecomment-754468357 ```log enabled targets: llvm -device=arm_cpu; llvm pytest marker: == test session starts

[GitHub] [tvm] jwfromm commented on pull request #7208: [Relay][Frontend][Onnx] Fix mismatch between Onnx Prelu definition and importer.

2021-01-04 Thread GitBox
jwfromm commented on pull request #7208: URL: https://github.com/apache/tvm/pull/7208#issuecomment-754406762 These two errors that you generated were excellent real bugs with the importer and were very easy to understand and replicate with your post. If they're being auto-generated they

[GitHub] [tvm] FrozenGene merged pull request #7185: [AutoScheduler] Add custom build function

2021-01-04 Thread GitBox
FrozenGene merged pull request #7185: URL: https://github.com/apache/tvm/pull/7185 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [tvm] merrymercy commented on a change in pull request #7197: [Fix][Autoscheduler] Costmodel enhancement & bug fix for graph debug runtime

2021-01-04 Thread GitBox
merrymercy commented on a change in pull request #7197: URL: https://github.com/apache/tvm/pull/7197#discussion_r551763123 ## File path: python/tvm/auto_scheduler/task_scheduler.py ## @@ -82,11 +82,12 @@ def make_search_policies( if isinstance(search_policy, str):

[tvm-site] branch asf-site updated: Build at Mon Jan 4 16:23:05 EST 2021

2021-01-04 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/tvm-site.git The following commit(s) were added to refs/heads/asf-site by this push: new 5581d5b Build at Mon Jan 4 16:23:05 EST

[GitHub] [tvm] mbrookhart commented on pull request #7172: [TOPI] Parallelize GPU NMS inner loop

2021-01-04 Thread GitBox
mbrookhart commented on pull request #7172: URL: https://github.com/apache/tvm/pull/7172#issuecomment-754276271 Kudos! This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [tvm] comaniac merged pull request #7205: [BYOC][TRT] Fix TRT conversion for reshape op - ReshapeAttrs no longer has reverse

2021-01-04 Thread GitBox
comaniac merged pull request #7205: URL: https://github.com/apache/tvm/pull/7205 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[tvm] branch main updated: ReshapeAttrs no longer has reverse (#7205)

2021-01-04 Thread comaniac
This is an automated email from the ASF dual-hosted git repository. comaniac pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git The following commit(s) were added to refs/heads/main by this push: new 7163b5c ReshapeAttrs no longer has reverse (#7205)

[GitHub] [tvm] comaniac commented on pull request #7205: [BYOC][TRT] Fix TRT conversion for reshape op - ReshapeAttrs no longer has reverse

2021-01-04 Thread GitBox
comaniac commented on pull request #7205: URL: https://github.com/apache/tvm/pull/7205#issuecomment-754249830 Thanks @trevor-m @junrushao1994 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [tvm] lhutton1 commented on a change in pull request #7206: [BYOC][ACL] Depthwise convolution support

2021-01-04 Thread GitBox
lhutton1 commented on a change in pull request #7206: URL: https://github.com/apache/tvm/pull/7206#discussion_r551595603 ## File path: python/tvm/relay/op/contrib/arm_compute_lib.py ## @@ -19,12 +19,15 @@ import numpy as np import tvm +import tvm._ffi Review comment:

[GitHub] [tvm] jcf94 commented on a change in pull request #7197: [Fix][Autoscheduler] Costmodel enhancement & bug fix for graph debug runtime

2021-01-04 Thread GitBox
jcf94 commented on a change in pull request #7197: URL: https://github.com/apache/tvm/pull/7197#discussion_r551211822 ## File path: python/tvm/auto_scheduler/cost_model/xgb_model.py ## @@ -141,6 +146,12 @@ def update(self, inputs, results): self.inputs.extend(inputs)

[GitHub] [tvm] jcf94 commented on a change in pull request #7197: [Fix][Autoscheduler] Costmodel enhancement & bug fix for graph debug runtime

2021-01-04 Thread GitBox
jcf94 commented on a change in pull request #7197: URL: https://github.com/apache/tvm/pull/7197#discussion_r551211822 ## File path: python/tvm/auto_scheduler/cost_model/xgb_model.py ## @@ -141,6 +146,12 @@ def update(self, inputs, results): self.inputs.extend(inputs)

[GitHub] [tvm] kalman5 opened a new pull request #7199: Fixed temporary lock_guard instances.

2021-01-04 Thread GitBox
kalman5 opened a new pull request #7199: URL: https://github.com/apache/tvm/pull/7199 This diff fixes the temporary lock_guard instances giving those a name. This is an automated message from the Apache Git Service. To

[GitHub] [tvm] aaltonenzhang opened a new issue #7198: some confusions when import official tensorflow models

2021-01-04 Thread GitBox
aaltonenzhang opened a new issue #7198: URL: https://github.com/apache/tvm/issues/7198 When testing tensorflow models from tfhub at [https://tfhub.dev/](url), I found issues when import tensorflow IRs. 1. When I import saved model using TFParser.parse() and from_tensorflow(), I found

[GitHub] [tvm] comaniac commented on a change in pull request #7197: [Fix][Autoscheduler] Costmodel enhancement & bug fix for graph debug runtime

2021-01-04 Thread GitBox
comaniac commented on a change in pull request #7197: URL: https://github.com/apache/tvm/pull/7197#discussion_r551199732 ## File path: python/tvm/auto_scheduler/task_scheduler.py ## @@ -82,11 +82,12 @@ def make_search_policies( if isinstance(search_policy, str):

[GitHub] [tvm] luyaor opened a new issue #7203: [Bug] [Relay] Error when compiling a simple ONNX model

2021-01-04 Thread GitBox
luyaor opened a new issue #7203: URL: https://github.com/apache/tvm/issues/7203 ## Description When compiling following model with TVM, it will error. The model(with ONNX as frontend) with error is as follows, check bug.onnx in

[GitHub] [tvm] leowang1225 commented on a change in pull request #7185: [AutoScheduler] Add custom build function

2021-01-04 Thread GitBox
leowang1225 commented on a change in pull request #7185: URL: https://github.com/apache/tvm/pull/7185#discussion_r551195931 ## File path: python/tvm/auto_scheduler/measure.py ## @@ -624,12 +652,10 @@ def local_build_worker(args): The build result of this Builder

[tvm] branch main updated: Fix ICHECK_NOTNULL in logging.g (#7193)

2021-01-04 Thread comaniac
This is an automated email from the ASF dual-hosted git repository. comaniac pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git The following commit(s) were added to refs/heads/main by this push: new eb64e25 Fix ICHECK_NOTNULL in logging.g (#7193)

[GitHub] [tvm] comaniac commented on pull request #7193: Fix ICHECK_NOTNULL in logging.h

2021-01-04 Thread GitBox
comaniac commented on pull request #7193: URL: https://github.com/apache/tvm/pull/7193#issuecomment-753861130 Thanks @codeislife99 @junrushao1994 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [tvm] comaniac merged pull request #7193: Fix ICHECK_NOTNULL in logging.h

2021-01-04 Thread GitBox
comaniac merged pull request #7193: URL: https://github.com/apache/tvm/pull/7193 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [tvm] insop commented on issue #7196: unsupported operators from tensorflow model garden models

2021-01-04 Thread GitBox
insop commented on issue #7196: URL: https://github.com/apache/tvm/issues/7196#issuecomment-753866375 @aaltonenzhang Nit, it seems the embedded url (https://github.com/tensorflow/models/tree/master/community) in the above post is not the actual url shown, i.e. if you click the link

[GitHub] [tvm] jcf94 commented on a change in pull request #7197: [Fix][Autoscheduler] Costmodel enhancement & bug fix for graph debug runtime

2021-01-04 Thread GitBox
jcf94 commented on a change in pull request #7197: URL: https://github.com/apache/tvm/pull/7197#discussion_r551206249 ## File path: src/auto_scheduler/feature.cc ## @@ -1462,12 +1462,18 @@ void GetPerStoreFeaturesFromMeasurePairs(const Array& inputs, if (find_res ==

[GitHub] [tvm] luyaor opened a new issue #7200: [Bug] Error when compiling a simple ONNX model with MatMul operator for opt_level=2

2021-01-04 Thread GitBox
luyaor opened a new issue #7200: URL: https://github.com/apache/tvm/issues/7200 ## Description When compiling following model with opt_level=2, TVM will crash. While if turn opt_level to 3, it will run normally. The model(with ONNX as frontend) with error is as follows, check

[GitHub] [tvm] jcf94 opened a new pull request #7197: [Fix][Autoscheduler] Costmodel enhancement & bug fix for graph debug runtime

2021-01-04 Thread GitBox
jcf94 opened a new pull request #7197: URL: https://github.com/apache/tvm/pull/7197 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [tvm] leowang1225 commented on a change in pull request #7185: [AutoScheduler] Add custom build function

2021-01-04 Thread GitBox
leowang1225 commented on a change in pull request #7185: URL: https://github.com/apache/tvm/pull/7185#discussion_r551207425 ## File path: python/tvm/auto_scheduler/measure.py ## @@ -624,12 +652,10 @@ def local_build_worker(args): The build result of this Builder

[GitHub] [tvm] jcf94 commented on a change in pull request #7197: [Fix][Autoscheduler] Costmodel enhancement & bug fix for graph debug runtime

2021-01-04 Thread GitBox
jcf94 commented on a change in pull request #7197: URL: https://github.com/apache/tvm/pull/7197#discussion_r551211822 ## File path: python/tvm/auto_scheduler/cost_model/xgb_model.py ## @@ -141,6 +146,12 @@ def update(self, inputs, results): self.inputs.extend(inputs)

[GitHub] [tvm] jcf94 commented on a change in pull request #7197: [Fix][Autoscheduler] Costmodel enhancement & bug fix for graph debug runtime

2021-01-04 Thread GitBox
jcf94 commented on a change in pull request #7197: URL: https://github.com/apache/tvm/pull/7197#discussion_r551211822 ## File path: python/tvm/auto_scheduler/cost_model/xgb_model.py ## @@ -141,6 +146,12 @@ def update(self, inputs, results): self.inputs.extend(inputs)

[GitHub] [tvm] jcf94 commented on a change in pull request #7197: [Fix][Autoscheduler] Costmodel enhancement & bug fix for graph debug runtime

2021-01-04 Thread GitBox
jcf94 commented on a change in pull request #7197: URL: https://github.com/apache/tvm/pull/7197#discussion_r551211822 ## File path: python/tvm/auto_scheduler/cost_model/xgb_model.py ## @@ -141,6 +146,12 @@ def update(self, inputs, results): self.inputs.extend(inputs)

[GitHub] [tvm] rhzhang1995 opened a new issue #7204: mesg: ttyname failed: Inappropriate ioctl for device

2021-01-04 Thread GitBox
rhzhang1995 opened a new issue #7204: URL: https://github.com/apache/tvm/issues/7204 When I was using Alveo U50 to configure TVM, I entered command “./tvm/docker/build.sh demo_vitis_ai bash”, and finally 2“mesg: ttyname failed: Inappropriate ioctl for device” appeared. Is TVM incompatible

[GitHub] [tvm] jcf94 commented on a change in pull request #7185: [AutoScheduler] Add custom build function

2021-01-04 Thread GitBox
jcf94 commented on a change in pull request #7185: URL: https://github.com/apache/tvm/pull/7185#discussion_r551179115 ## File path: python/tvm/auto_scheduler/measure.py ## @@ -624,12 +652,10 @@ def local_build_worker(args): The build result of this Builder thread.

[GitHub] [tvm] jcf94 commented on pull request #7197: [Fix][Autoscheduler] Costmodel enhancement & bug fix for graph debug runtime

2021-01-04 Thread GitBox
jcf94 commented on pull request #7197: URL: https://github.com/apache/tvm/pull/7197#issuecomment-753862836 Thanks! @junrushao1994 Also cc @merrymercy @comaniac This is an automated message from the Apache Git Service.

[GitHub] [tvm] jcf94 commented on a change in pull request #7197: [Fix][Autoscheduler] Costmodel enhancement & bug fix for graph debug runtime

2021-01-04 Thread GitBox
jcf94 commented on a change in pull request #7197: URL: https://github.com/apache/tvm/pull/7197#discussion_r551206249 ## File path: src/auto_scheduler/feature.cc ## @@ -1462,12 +1462,18 @@ void GetPerStoreFeaturesFromMeasurePairs(const Array& inputs, if (find_res ==

[GitHub] [tvm] leowang1225 commented on a change in pull request #7185: [AutoScheduler] Add custom build function

2021-01-04 Thread GitBox
leowang1225 commented on a change in pull request #7185: URL: https://github.com/apache/tvm/pull/7185#discussion_r551207425 ## File path: python/tvm/auto_scheduler/measure.py ## @@ -624,12 +652,10 @@ def local_build_worker(args): The build result of this Builder

[GitHub] [tvm] leowang1225 commented on a change in pull request #7185: [AutoScheduler] Add custom build function

2021-01-04 Thread GitBox
leowang1225 commented on a change in pull request #7185: URL: https://github.com/apache/tvm/pull/7185#discussion_r551207425 ## File path: python/tvm/auto_scheduler/measure.py ## @@ -624,12 +652,10 @@ def local_build_worker(args): The build result of this Builder

[GitHub] [tvm] FrozenGene commented on a change in pull request #7185: [AutoScheduler] Add custom build function

2021-01-04 Thread GitBox
FrozenGene commented on a change in pull request #7185: URL: https://github.com/apache/tvm/pull/7185#discussion_r551215468 ## File path: python/tvm/auto_scheduler/measure.py ## @@ -624,12 +652,10 @@ def local_build_worker(args): The build result of this Builder

[GitHub] [tvm] jcf94 commented on a change in pull request #7197: [Fix][Autoscheduler] Costmodel enhancement & bug fix for graph debug runtime

2021-01-04 Thread GitBox
jcf94 commented on a change in pull request #7197: URL: https://github.com/apache/tvm/pull/7197#discussion_r551211822 ## File path: python/tvm/auto_scheduler/cost_model/xgb_model.py ## @@ -141,6 +146,12 @@ def update(self, inputs, results): self.inputs.extend(inputs)

[GitHub] [tvm] kalman5 commented on pull request #7199: Fixed temporary lock_guard instances.

2021-01-04 Thread GitBox
kalman5 commented on pull request #7199: URL: https://github.com/apache/tvm/pull/7199#issuecomment-753911981 @jcf94 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [tvm] luyaor opened a new issue #7201: [Bug] Error when compiling a simple ONNX model for opt_level=3

2021-01-04 Thread GitBox
luyaor opened a new issue #7201: URL: https://github.com/apache/tvm/issues/7201 ## Description When compiling following model with opt_level=3, TVM will crash. While if turn opt_level to 2, it will run normally. The model(with ONNX as frontend) with error is as follows, check

[GitHub] [tvm] kalman5 edited a comment on pull request #7199: Fixed temporary lock_guard instances.

2021-01-04 Thread GitBox
kalman5 edited a comment on pull request #7199: URL: https://github.com/apache/tvm/pull/7199#issuecomment-753911981 For reviewers @jcf94 @ZihengJiang This is an automated message from the Apache Git Service. To respond to

[GitHub] [tvm] luyaor opened a new issue #7202: [Bug] [Relay] Error when compiling a simple ONNX model

2021-01-04 Thread GitBox
luyaor opened a new issue #7202: URL: https://github.com/apache/tvm/issues/7202 ## Description When compiling following model with TVM, it will error. The model(with ONNX as frontend) with error is as follows, check bug.onnx in bug2.zip.

[GitHub] [tvm] FrozenGene commented on a change in pull request #7185: [AutoScheduler] Add custom build function

2021-01-04 Thread GitBox
FrozenGene commented on a change in pull request #7185: URL: https://github.com/apache/tvm/pull/7185#discussion_r551167353 ## File path: python/tvm/auto_scheduler/measure.py ## @@ -624,12 +652,10 @@ def local_build_worker(args): The build result of this Builder

[GitHub] [tvm] leowang1225 commented on a change in pull request #7185: [AutoScheduler] Add custom build function

2021-01-04 Thread GitBox
leowang1225 commented on a change in pull request #7185: URL: https://github.com/apache/tvm/pull/7185#discussion_r551170406 ## File path: python/tvm/auto_scheduler/measure.py ## @@ -624,12 +652,10 @@ def local_build_worker(args): The build result of this Builder

[GitHub] [tvm] leowang1225 commented on a change in pull request #7185: [AutoScheduler] Add custom build function

2021-01-04 Thread GitBox
leowang1225 commented on a change in pull request #7185: URL: https://github.com/apache/tvm/pull/7185#discussion_r551170406 ## File path: python/tvm/auto_scheduler/measure.py ## @@ -624,12 +652,10 @@ def local_build_worker(args): The build result of this Builder

[GitHub] [tvm] jcf94 commented on pull request #7185: [AutoScheduler] Add custom build function

2021-01-04 Thread GitBox
jcf94 commented on pull request #7185: URL: https://github.com/apache/tvm/pull/7185#issuecomment-753822379 > @jcf94 could you have another one round of review? Sorry for I'm a little busy this afternoon. This is an

[GitHub] [tvm] leowang1225 commented on a change in pull request #7185: [AutoScheduler] Add custom build function

2021-01-04 Thread GitBox
leowang1225 commented on a change in pull request #7185: URL: https://github.com/apache/tvm/pull/7185#discussion_r551170406 ## File path: python/tvm/auto_scheduler/measure.py ## @@ -624,12 +652,10 @@ def local_build_worker(args): The build result of this Builder

[GitHub] [tvm] leowang1225 commented on a change in pull request #7185: [AutoScheduler] Add custom build function

2021-01-04 Thread GitBox
leowang1225 commented on a change in pull request #7185: URL: https://github.com/apache/tvm/pull/7185#discussion_r551170406 ## File path: python/tvm/auto_scheduler/measure.py ## @@ -624,12 +652,10 @@ def local_build_worker(args): The build result of this Builder

[tvm] branch main updated (86a8504 -> 25f0252)

2021-01-04 Thread liangfu
This is an automated email from the ASF dual-hosted git repository. liangfu pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git. from 86a8504 [Frontend][MXNet] add _npi_subtract_scalar (#7191) add 25f0252 Makes sure g_last_error is null

[GitHub] [tvm] liangfu merged pull request #7190: Makes sure g_last_error is null terminated.

2021-01-04 Thread GitBox
liangfu merged pull request #7190: URL: https://github.com/apache/tvm/pull/7190 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [tvm] liangfu commented on pull request #7190: Makes sure g_last_error is null terminated.

2021-01-04 Thread GitBox
liangfu commented on pull request #7190: URL: https://github.com/apache/tvm/pull/7190#issuecomment-753837813 Thanks @cxcxcxcx for the proposed change. This is now merged. This is an automated message from the Apache Git

[GitHub] [tvm] jcf94 commented on a change in pull request #7185: [AutoScheduler] Add custom build function

2021-01-04 Thread GitBox
jcf94 commented on a change in pull request #7185: URL: https://github.com/apache/tvm/pull/7185#discussion_r551163552 ## File path: python/tvm/auto_scheduler/measure.py ## @@ -624,12 +652,10 @@ def local_build_worker(args): The build result of this Builder thread.

[GitHub] [tvm] jcf94 commented on a change in pull request #7185: [AutoScheduler] Add custom build function

2021-01-04 Thread GitBox
jcf94 commented on a change in pull request #7185: URL: https://github.com/apache/tvm/pull/7185#discussion_r551163552 ## File path: python/tvm/auto_scheduler/measure.py ## @@ -624,12 +652,10 @@ def local_build_worker(args): The build result of this Builder thread.

[GitHub] [tvm] liangfu commented on a change in pull request #7190: Makes sure g_last_error is null terminated.

2021-01-04 Thread GitBox
liangfu commented on a change in pull request #7190: URL: https://github.com/apache/tvm/pull/7190#discussion_r551175687 ## File path: src/runtime/crt/common/crt_runtime_api.c ## @@ -38,7 +38,10 @@ static char g_last_error[1024]; -void TVMAPISetLastError(const char* msg) {

[GitHub] [tvm] jcf94 commented on a change in pull request #7185: [AutoScheduler] Add custom build function

2021-01-04 Thread GitBox
jcf94 commented on a change in pull request #7185: URL: https://github.com/apache/tvm/pull/7185#discussion_r551179115 ## File path: python/tvm/auto_scheduler/measure.py ## @@ -624,12 +652,10 @@ def local_build_worker(args): The build result of this Builder thread.

[GitHub] [tvm] aaltonenzhang opened a new issue #7196: unsupported operators from tensorflow model garden models

2021-01-04 Thread GitBox
aaltonenzhang opened a new issue #7196: URL: https://github.com/apache/tvm/issues/7196 I'm checking tensorflow models from tensorflow models garden at [https://github.com/tensorflow/models/tree/master/community](url). For community models, there are types and operators which tvm doesn't

[GitHub] [tvm] tqchen merged pull request #7199: Fixed temporary lock_guard instances.

2021-01-04 Thread GitBox
tqchen merged pull request #7199: URL: https://github.com/apache/tvm/pull/7199 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[tvm] branch main updated: Fixed temporary lock_guard instances. (#7199)

2021-01-04 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git The following commit(s) were added to refs/heads/main by this push: new 7053235 Fixed temporary lock_guard instances. (#7199)

[GitHub] [tvm] junrushao1994 commented on issue #7204: mesg: ttyname failed: Inappropriate ioctl for device

2021-01-04 Thread GitBox
junrushao1994 commented on issue #7204: URL: https://github.com/apache/tvm/issues/7204#issuecomment-754021201 It is not an error actually. In our CI pipeline, we can see this message on the beginning of every stage... This

[GitHub] [tvm] mbrookhart commented on a change in pull request #7125: Sparse reshape op

2021-01-04 Thread GitBox
mbrookhart commented on a change in pull request #7125: URL: https://github.com/apache/tvm/pull/7125#discussion_r551422829 ## File path: include/tvm/topi/transform.h ## @@ -1386,6 +1386,88 @@ inline Array meshgrid(const Array& inputs, const std::string& in return result;

[GitHub] [tvm] mbrookhart commented on pull request #7195: [THRUST] Faster multi dimensional argsort by segmented sort

2021-01-04 Thread GitBox
mbrookhart commented on pull request #7195: URL: https://github.com/apache/tvm/pull/7195#issuecomment-754095011 This looks great. My only concern would possibly be that some object detection models (I'm thinking gluon SSD) have a very large number of boxes they sort before NMS. Could you

[GitHub] [tvm] mbrookhart commented on pull request #7195: [THRUST] Faster multi dimensional argsort by segmented sort

2021-01-04 Thread GitBox
mbrookhart commented on pull request #7195: URL: https://github.com/apache/tvm/pull/7195#issuecomment-754096681 Also, I think you and I are using different versions of CUDA for the same GPU, that might explain the difference in the numbers I posted in #7099 and you posted here.

[GitHub] [tvm] trevor-m opened a new pull request #7205: [BYOC][TRT] Fix TRT conversion for reshape op - ReshapeAttrs no longer has reverse

2021-01-04 Thread GitBox
trevor-m opened a new pull request #7205: URL: https://github.com/apache/tvm/pull/7205 Updates TRT converter for Reshape op after https://github.com/apache/tvm/pull/7086 removed `reverse` attr. This is an automated message

[GitHub] [tvm] areusch commented on a change in pull request #7197: [Fix][Autoscheduler] Costmodel enhancement & bug fix for graph debug runtime

2021-01-04 Thread GitBox
areusch commented on a change in pull request #7197: URL: https://github.com/apache/tvm/pull/7197#discussion_r551452806 ## File path: src/runtime/graph/debug/graph_runtime_debug.cc ## @@ -153,9 +153,10 @@ class GraphRuntimeDebug : public GraphRuntime { const TVMContext&

[GitHub] [tvm] comaniac commented on a change in pull request #7197: [Fix][Autoscheduler] Costmodel enhancement & bug fix for graph debug runtime

2021-01-04 Thread GitBox
comaniac commented on a change in pull request #7197: URL: https://github.com/apache/tvm/pull/7197#discussion_r551479201 ## File path: src/auto_scheduler/feature.cc ## @@ -1462,12 +1462,18 @@ void GetPerStoreFeaturesFromMeasurePairs(const Array& inputs, if (find_res ==

[GitHub] [tvm] d-smirnov commented on pull request #6998: [TFLite] Strided slice handling of shrink_axis_mask improved

2021-01-04 Thread GitBox
d-smirnov commented on pull request #6998: URL: https://github.com/apache/tvm/pull/6998#issuecomment-754128584 bump cc @siju-samuel @FrozenGene Please, also advise on extra check to _assert_allclose_ This is an automated

[GitHub] [tvm] comaniac merged pull request #7194: [CUBLAS, CUDNN] Support dynamic batch size

2021-01-04 Thread GitBox
comaniac merged pull request #7194: URL: https://github.com/apache/tvm/pull/7194 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[tvm] branch main updated (7053235 -> 361f508)

2021-01-04 Thread comaniac
This is an automated email from the ASF dual-hosted git repository. comaniac pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git. from 7053235 Fixed temporary lock_guard instances. (#7199) add 361f508 [CUBLAS, CUDNN] Support dynamic batch size

[GitHub] [tvm] comaniac commented on pull request #7194: [CUBLAS, CUDNN] Support dynamic batch size

2021-01-04 Thread GitBox
comaniac commented on pull request #7194: URL: https://github.com/apache/tvm/pull/7194#issuecomment-754218139 Thanks @masahi @kevinthesun This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [tvm] d-smirnov opened a new pull request #7206: [BYOC][ACL] Depthwise convolution support

2021-01-04 Thread GitBox
d-smirnov opened a new pull request #7206: URL: https://github.com/apache/tvm/pull/7206 Added support for depthwise convolution. ACL only supports depth-wise convolution when kernel size is 3x3 and 5x5 and strides are (1, 1) or (2, 2), if this is not the case then fallback to TVM.

[GitHub] [tvm] masahi edited a comment on pull request #7195: [THRUST] Faster multi dimensional argsort by segmented sort

2021-01-04 Thread GitBox
masahi edited a comment on pull request #7195: URL: https://github.com/apache/tvm/pull/7195#issuecomment-754199021 @mbrookhart I have a fast-path for one segment case, so the perf is the same between current / new. I'll update the condition to work for dimension other than two.

[GitHub] [tvm] masahi commented on pull request #7195: [THRUST] Faster multi dimensional argsort by segmented sort

2021-01-04 Thread GitBox
masahi commented on pull request #7195: URL: https://github.com/apache/tvm/pull/7195#issuecomment-754199021 @mbrookhart I have a fast-path for one segment case, so the perf is the same between current / new. I'll update the condition to work for dimension other then two.

[GitHub] [tvm] trevor-m commented on pull request #7195: [THRUST] Faster multi dimensional argsort by segmented sort

2021-01-04 Thread GitBox
trevor-m commented on pull request #7195: URL: https://github.com/apache/tvm/pull/7195#issuecomment-754151980 Nice! Have you also looked at CUB's

[GitHub] [tvm] icemelon9 commented on a change in pull request #7120: [PatternLang] Add Syntatic Sugar to the C++ pattern API and support DataType Attribute Matching

2021-01-04 Thread GitBox
icemelon9 commented on a change in pull request #7120: URL: https://github.com/apache/tvm/pull/7120#discussion_r551668826 ## File path: include/tvm/relay/dataflow_pattern.h ## @@ -46,6 +48,29 @@ class DFPatternNode : public Object { */ class DFPattern : public ObjectRef {

[GitHub] [tvm] jcf94 opened a new issue #7207: [BUG] Get wrong measure time in graph debug runtime

2021-01-04 Thread GitBox
jcf94 opened a new issue #7207: URL: https://github.com/apache/tvm/issues/7207 This bug was introduced in #6964 . Currently, use graph debug runtime will get wrong time result. Cause:

[GitHub] [tvm] jcf94 commented on a change in pull request #7197: [Fix][Autoscheduler] Costmodel enhancement & bug fix for graph debug runtime

2021-01-04 Thread GitBox
jcf94 commented on a change in pull request #7197: URL: https://github.com/apache/tvm/pull/7197#discussion_r551675372 ## File path: src/runtime/graph/debug/graph_runtime_debug.cc ## @@ -153,9 +153,10 @@ class GraphRuntimeDebug : public GraphRuntime { const TVMContext& ctx

[GitHub] [tvm] FrozenGene commented on a change in pull request #7185: [AutoScheduler] Add custom build function

2021-01-04 Thread GitBox
FrozenGene commented on a change in pull request #7185: URL: https://github.com/apache/tvm/pull/7185#discussion_r551678095 ## File path: python/tvm/auto_scheduler/measure.py ## @@ -303,12 +315,28 @@ class LocalBuilder(ProgramBuilder): This is used in a wrapper of the

[GitHub] [tvm] leowang1225 commented on a change in pull request #7185: [AutoScheduler] Add custom build function

2021-01-04 Thread GitBox
leowang1225 commented on a change in pull request #7185: URL: https://github.com/apache/tvm/pull/7185#discussion_r551682259 ## File path: python/tvm/auto_scheduler/measure.py ## @@ -303,12 +315,28 @@ class LocalBuilder(ProgramBuilder): This is used in a wrapper of the

[GitHub] [tvm] aaltonenzhang removed a comment on issue #7196: unsupported operators from tensorflow model garden models

2021-01-04 Thread GitBox
aaltonenzhang removed a comment on issue #7196: URL: https://github.com/apache/tvm/issues/7196#issuecomment-754320776 @insop It seems that there are something wrong when you click the url, but you can copy and paste it to your browser. And for the issue #7198, it's also created by me,

[GitHub] [tvm] aaltonenzhang commented on issue #7196: unsupported operators from tensorflow model garden models

2021-01-04 Thread GitBox
aaltonenzhang commented on issue #7196: URL: https://github.com/apache/tvm/issues/7196#issuecomment-754362026 @insop reedited the url link for both of the two issues. This is an automated message from the Apache Git Service.

[GitHub] [tvm] aaltonenzhang edited a comment on issue #7196: unsupported operators from tensorflow model garden models

2021-01-04 Thread GitBox
aaltonenzhang edited a comment on issue #7196: URL: https://github.com/apache/tvm/issues/7196#issuecomment-754362026 @insop reedited the url links for both of the two issues. This is an automated message from the Apache Git

[GitHub] [tvm] comaniac commented on pull request #7184: [ConvertLayout] slice_like support

2021-01-04 Thread GitBox
comaniac commented on pull request #7184: URL: https://github.com/apache/tvm/pull/7184#issuecomment-754279843 Kindly remind @anijain2305 @yzhliu for reviewing this PR :) This is an automated message from the Apache Git

[GitHub] [tvm] areusch commented on a change in pull request #7164: [µTVM] Add documentation

2021-01-04 Thread GitBox
areusch commented on a change in pull request #7164: URL: https://github.com/apache/tvm/pull/7164#discussion_r551656029 ## File path: docs/dev/microtvm_design.rst ## @@ -0,0 +1,340 @@ +.. Licensed to the Apache Software Foundation (ASF) under one +or more contributor

[GitHub] [tvm] areusch commented on a change in pull request #7164: [µTVM] Add documentation

2021-01-04 Thread GitBox
areusch commented on a change in pull request #7164: URL: https://github.com/apache/tvm/pull/7164#discussion_r551658680 ## File path: docs/dev/microtvm_design.rst ## @@ -0,0 +1,340 @@ +.. Licensed to the Apache Software Foundation (ASF) under one +or more contributor

[GitHub] [tvm] comaniac merged pull request #7184: [ConvertLayout] slice_like support

2021-01-04 Thread GitBox
comaniac merged pull request #7184: URL: https://github.com/apache/tvm/pull/7184 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[tvm] branch main updated: [ConvertLayout] slice_like support (#7184)

2021-01-04 Thread comaniac
This is an automated email from the ASF dual-hosted git repository. comaniac pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git The following commit(s) were added to refs/heads/main by this push: new d052752 [ConvertLayout] slice_like support (#7184)

  1   2   >