[GitHub] [incubator-tvm] shoubhik commented on issue #4714: Mxnet parser for Qnn dialect
shoubhik commented on issue #4714: Mxnet parser for Qnn dialect URL: https://github.com/apache/incubator-tvm/pull/4714#issuecomment-582138102 @tqchen @yzhliu I think the code can be merged now. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-tvm] shoubhik commented on issue #4714: Mxnet parser for Qnn dialect
shoubhik commented on issue #4714: Mxnet parser for Qnn dialect URL: https://github.com/apache/incubator-tvm/pull/4714#issuecomment-581672885 @tmoreau89 @yzhliu @tqchen @jackwish @FrozenGene @liangfu @vinx13 @anijain2305 I want to discuss this PR from testability POV. Mxnet suggests to use MKLDNN as backend for quantization. The operators for MKLDNN quantization in Mxnet is different from stock Mxnet quantization operators. Also, for some ops the implementation of these ops are also different. Due to this PR #4753 and #4764, it is not possible to merge the Mxnet-MKLDNN installation in TVM docker. One potential solution is to test stock quantization operators but that would be extra work that may not be too useful in future. All the testing we have done and the edge cases we have covered are for the MKLDNN operators. My suggestion is at this point we check in the parser code along with the the test scripts we have for benchmarking the QNN networks. When MKLDNN issues are fixed and we can safely upgrade we can add test cases at that point. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-tvm] shoubhik commented on issue #4714: Mxnet parser for Qnn dialect
shoubhik commented on issue #4714: Mxnet parser for Qnn dialect URL: https://github.com/apache/incubator-tvm/pull/4714#issuecomment-576458551 > it would be great if you could add an test case on end to end network translation like in our tflite test case. I have created a post on discuss on how we can do this - https://discuss.tvm.ai/t/use-mxnet-mkldnn-distribution-in-ci-instead-of-stock-mxnet-distribution/5474 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-tvm] shoubhik commented on issue #4714: Mxnet parser for Qnn dialect
shoubhik commented on issue #4714: Mxnet parser for Qnn dialect URL: https://github.com/apache/incubator-tvm/pull/4714#issuecomment-574790244 @anijain2305 , @jackwish can you take a look at this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
