[GitHub] [incubator-tvm] tqchen commented on pull request #5423: [RUNTIME][OBJECT] Introduce static slots for common objects.

2020-04-24 Thread GitBox


tqchen commented on pull request #5423:
URL: https://github.com/apache/incubator-tvm/pull/5423#issuecomment-619192968


   ping @jroesch 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-tvm] tqchen commented on pull request #5423: [RUNTIME][OBJECT] Introduce static slots for common objects.

2020-04-24 Thread GitBox


tqchen commented on pull request #5423:
URL: https://github.com/apache/incubator-tvm/pull/5423#issuecomment-619153621


   The code still works, the overflow children will need to go through the 
overflow path, and call 
https://github.com/apache/incubator-tvm/blob/master/include/tvm/runtime/object.h#L889(which
 is slightly slower than bound checking).
   
   Note that the original code set all the child_slots to 0, so everything 
overflows.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-tvm] tqchen commented on pull request #5423: [RUNTIME][OBJECT] Introduce static slots for common objects.

2020-04-23 Thread GitBox


tqchen commented on pull request #5423:
URL: https://github.com/apache/incubator-tvm/pull/5423#issuecomment-618627418


   The inhertitance will still work for 3rdparty, because overflow is enabled 
in all these cases, the support path will be like the same before this PR. we 
could discuss whether or not we want to reserve some slots when we have a good 
idea of potential additional inheritence.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org