[GitHub] [incubator-tvm] zhiics commented on issue #4879: [Relay][Pass] Fix bug in re-processing call node in MergeComposite pass

zhiics commented on issue #4879: [Relay][Pass] Fix bug in re-processing call node in MergeComposite pass URL: https://github.com/apache/incubator-tvm/pull/4879#issuecomment-587144682 Thanks @soiferj @mbaret @cbalint13 This

[GitHub] [incubator-tvm] zhiics commented on issue #4879: [Relay][Pass] Fix bug in re-processing call node in MergeComposite pass

zhiics commented on issue #4879: [Relay][Pass] Fix bug in re-processing call node in MergeComposite pass URL: https://github.com/apache/incubator-tvm/pull/4879#issuecomment-587125329 @mbaret PTAL. Let's land this if it looks good to you as well.

[GitHub] [incubator-tvm] zhiics commented on issue #4879: [Relay][Pass] Fix bug in re-processing call node in MergeComposite pass

zhiics commented on issue #4879: [Relay][Pass] Fix bug in re-processing call node in MergeComposite pass URL: https://github.com/apache/incubator-tvm/pull/4879#issuecomment-586541570 Thanks for the effort. I will take a look later. So, do we still need to flip the args? If so, we still

[GitHub] [incubator-tvm] zhiics commented on issue #4879: [Relay][Pass] Fix bug in re-processing call node in MergeComposite pass

zhiics commented on issue #4879: [Relay][Pass] Fix bug in re-processing call node in MergeComposite pass URL: https://github.com/apache/incubator-tvm/pull/4879#issuecomment-586527810 @soiferj Can you also try to create a minimal example? Thanks.

[GitHub] [incubator-tvm] zhiics commented on issue #4879: [Relay][Pass] Fix bug in re-processing call node in MergeComposite pass

zhiics commented on issue #4879: [Relay][Pass] Fix bug in re-processing call node in MergeComposite pass URL: https://github.com/apache/incubator-tvm/pull/4879#issuecomment-586526565 I am okay with it as the failure should be separate issue from `alpha_equal`. But I would suggest we

[GitHub] [incubator-tvm] zhiics commented on issue #4879: [Relay][Pass] Fix bug in re-processing call node in MergeComposite pass

zhiics commented on issue #4879: [Relay][Pass] Fix bug in re-processing call node in MergeComposite pass URL: https://github.com/apache/incubator-tvm/pull/4879#issuecomment-586514793 I though you provided ``` v0.0.4 fn (%a: Tensor[(10, 10), float32], %b: Tensor[(10, 10), float32])

[GitHub] [incubator-tvm] zhiics commented on issue #4879: [Relay][Pass] Fix bug in re-processing call node in MergeComposite pass

zhiics commented on issue #4879: [Relay][Pass] Fix bug in re-processing call node in MergeComposite pass URL: https://github.com/apache/incubator-tvm/pull/4879#issuecomment-586509927 I can give it a try over the weekend, but why do you feed the expected with an unexpected expression?

[GitHub] [incubator-tvm] zhiics commented on issue #4879: [Relay][Pass] Fix bug in re-processing call node in MergeComposite pass

zhiics commented on issue #4879: [Relay][Pass] Fix bug in re-processing call node in MergeComposite pass URL: https://github.com/apache/incubator-tvm/pull/4879#issuecomment-586474522 graph equal would not make a difference here as it checks free vars. I might not have time today. I can

[GitHub] [incubator-tvm] zhiics commented on issue #4879: [Relay][Pass] Fix bug in re-processing call node in MergeComposite pass

zhiics commented on issue #4879: [Relay][Pass] Fix bug in re-processing call node in MergeComposite pass URL: https://github.com/apache/incubator-tvm/pull/4879#issuecomment-586428873 @soiferj hmm, this looks a bit wired to me, I will take a look at it. Thanks.

[GitHub] [incubator-tvm] zhiics commented on issue #4879: [Relay][Pass] Fix bug in re-processing call node in MergeComposite pass

zhiics commented on issue #4879: [Relay][Pass] Fix bug in re-processing call node in MergeComposite pass URL: https://github.com/apache/incubator-tvm/pull/4879#issuecomment-586426900 @soiferj Sorry. I don't quite understand the problem. Do you mean that these two expressions can pass