[GitHub] [tvm] comaniac commented on pull request #7317: [AutoScheduler] Separate shapes from DAG hash and enable schedule sharing

2021-01-23 Thread GitBox 


comaniac commented on pull request #7317:
URL: https://github.com/apache/tvm/pull/7317#issuecomment-766280534


   > The added warning message is too general. There are a lot of other reasons 
to hit this warning message. So I prefer not having it.
   > I don't have a good place to put this warning message either. Let us 
delete it and merge this.
   
   I agreed that the added warning message was too general so I reverted it. 
Meanwhile, I came up with another idea that adds the warning message when 
loading the records. Now users will see the following message when loading the 
logs with old format:
   
   ```
   MeasureInput with old format workload key 
["b32ed43fb351136894c322ee49097a1a"] should be updated using the script from 
https://github.com/apache/tvm/pull/7317.
   ```



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [tvm] comaniac commented on pull request #7317: [AutoScheduler] Separate shapes from DAG hash and enable schedule sharing

2021-01-22 Thread GitBox 


comaniac commented on pull request #7317:
URL: https://github.com/apache/tvm/pull/7317#issuecomment-765793632


   > Because this PR breaks compatibility, should we add some warning messages 
and point users to this PR?
   
   How about adding the message to the exsiting schedule not found warning and 
point to this PR?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org