[GitHub] incubator-weex issue #1051: + [iOS] add WXVideoComponent "poster" attribute.

2018-03-07 Thread xuyouyang 
Github user xuyouyang commented on the issue:

https://github.com/apache/incubator-weex/pull/1051
  
OK. Thank you very much! @acton393 


---

[GitHub] incubator-weex issue #1051: + [iOS] add WXVideoComponent "poster" attribute.

2018-03-07 Thread acton393 
Github user acton393 commented on the issue:

https://github.com/apache/incubator-weex/pull/1051
  
@xuyouyang   as the [development 
process](http://weex.apache.org/development-process.html) shows, we need create 
a jira issue in apache, and format your pull request title and commit log.

   I have created a jira issue for this feature, and the issue id is 
WEEX-241, the issue address is https://issues.apache.org/jira/browse/WEEX-241

what you need to do next is to update the title as the following format 
 `[WEEX-jiraId][iOS/Android] summary`

thanks


---

[GitHub] incubator-weex issue #1051: + [iOS] add WXVideoComponent "poster" attribute.

2018-03-07 Thread acton393 
Github user acton393 commented on the issue:

https://github.com/apache/incubator-weex/pull/1051
  
@xuyouyang  I got it and find the w3c rules about it : 
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/video

thanks, we can make it more standard by add more attributes and styles, 
what about Android?


---

[GitHub] incubator-weex issue #1051: + [iOS] add WXVideoComponent "poster" attribute.

2018-03-06 Thread xuyouyang 
Github user xuyouyang commented on the issue:

https://github.com/apache/incubator-weex/pull/1051
  
NO.
The poster attribute specifies an image to be shown while the video is 
downloading, or until the user hits the play button. If this is not included, 
the first frame of the video will be used instead.
You can see this "https://www.w3schools.com/tags/att_video_poster.asp";
It is a attribute in HTML  tag


---

[GitHub] incubator-weex issue #1051: + [iOS] add WXVideoComponent "poster" attribute.

2018-03-06 Thread acton393 
Github user acton393 commented on the issue:

https://github.com/apache/incubator-weex/pull/1051
  
hi,  @xuyouyang   what's the "poster"  feature，  is it  the paused 
picture about  player display?


---

[GitHub] incubator-weex issue #1051: + [iOS] add WXVideoComponent "poster" attribute.

2018-03-06 Thread weex-bot 
Github user weex-bot commented on the issue:

https://github.com/apache/incubator-weex/pull/1051
  





  

  
  Warnings

  
  
  :warning:
  No Changelog changes!

  




  

  
  Messages

  
  
  :book:
  danger test finished.

  




  Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS




---