[GitHub] incubator-weex issue #518: + [ios] update input number type; change nsassert...

2017-08-08 Thread mlcldh 
Github user mlcldh commented on the issue:

https://github.com/apache/incubator-weex/pull/518
  
@acton393 我们公司web前端写的weex页面，往往打开一次，内
存增长一次，改变weex页面后内
存并没有减少，我们的viewcontroller已经释放了，我们的weex 
viewcontroller 
dealloc时让instance执行了destroyInstance方法。崩溃日志统计可以弄成可选的，ä½
 ä»¬å¯ä»¥åªç»Ÿè®¡weex相关的崩溃。


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-weex issue #518: + [ios] update input number type; change nsassert...

2017-07-24 Thread acton393 
Github user acton393 commented on the issue:

https://github.com/apache/incubator-weex/pull/518
  
@mlcldh   内存占用的问题， 可以跑一下instrument， 
看下在什么地方吃内存比较多，另外， 
crash统计设计到数据安全的问题，建议开发者自己集成


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-weex issue #518: + [ios] update input number type; change nsassert...

2017-07-19 Thread mlcldh 
Github user mlcldh commented on the issue:

https://github.com/apache/incubator-weex/pull/518
  
@kfeagle 我建议你们在weex 
sdk里集成崩溃日志统计，统计后台用你们的。


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-weex issue #518: + [ios] update input number type; change nsassert...

2017-07-19 Thread mlcldh 
Github user mlcldh commented on the issue:

https://github.com/apache/incubator-weex/pull/518
  
我们使用的iOS weex版本是0.12.0。
还有一个问题，打开weex页面，然后返回在打开，内
存会越来越大，最后收到内
存警告，然后再是一两次就崩溃了。估计是因为内存占
用太大，被系统杀死了。iOS weex SDK里应该是有内存泄漏。

我们里面dealloc方法走了，我们在dealloc里调用了WXSDKInstance的destroyInstance方法。


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-weex issue #518: + [ios] update input number type; change nsassert...

2017-07-19 Thread kfeagle 
Github user kfeagle commented on the issue:

https://github.com/apache/incubator-weex/pull/518
  
@mlcldh please provide one simple demo:-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-weex issue #518: + [ios] update input number type; change nsassert...

2017-07-19 Thread mlcldh 
Github user mlcldh commented on the issue:

https://github.com/apache/incubator-weex/pull/518
  
iOS weex版本是0.12.0，你们封装
使用的使用的是多线程，针对_animationInfo.target的保护可能无
效，不一定啥时候_animationInfo.target为空了。反正我们每次这里崩溃都是å›
 ä¸º_animationInfo.target为空，并且->_transform。


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-weex issue #518: + [ios] update input number type; change nsassert...

2017-07-19 Thread kfeagle 
Github user kfeagle commented on the issue:

https://github.com/apache/incubator-weex/pull/518
  
@mlcldh can you provide your demo and weexsdk version?
I find weexsdk judge _animationInfo.target in the code

https://github.com/apache/incubator-weex/blob/0.15-dev/ios/sdk/WeexSDK/Sources/Module/WXAnimationModule.m#L88
  weex sdk 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-weex issue #518: + [ios] update input number type; change nsassert...

2017-07-19 Thread mlcldh 
Github user mlcldh commented on the issue:

https://github.com/apache/incubator-weex/pull/518
  

WXAnimationDelegate里面_animationInfo.target如果为空时，调用_animationInfo.target->_transform会导致崩溃！不知道为什么访问_transform非要写成这种形式，这种形式很容易导致崩溃……最近我们å
…¬å¸web前端写的weex只要使用动画，就非常容易崩溃！


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-weex issue #518: + [ios] update input number type; change nsassert...

2017-07-19 Thread weex-bot 
Github user weex-bot commented on the issue:

https://github.com/apache/incubator-weex/pull/518
  





  

  
  Warnings

  
  
  :warning:
  No Changelog changes!

  

  :warning:
  This PR modify SDK code without add/modify testcases.

  

  :warning:
  This PR should update related documents as well. 

  




  

  
  Messages

  
  
  :book:
  According to the blame info, we recommended @Jinjiang to be the 
reviewers.

  




  Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-weex issue #518: + [ios] update input number type; change nsassert...

2017-07-19 Thread mlcldh 
Github user mlcldh commented on the issue:

https://github.com/apache/incubator-weex/pull/518
  

WXAnimationDelegate里面_animationInfo.target如果为空时，调用_animationInfo.target->_transform会导致崩溃！不知道为什么访问_transform非要写成这种形式，这种形式很容易导致崩溃……最近我们å
…¬å¸web前端写的weex只要使用动画，就非常容易崩溃！


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---