[04/12] zeppelin git commit: [ZEPPELIN-3245] checkstyle/eslintrc for zeppelin-web (JavaScript)
http://git-wip-us.apache.org/repos/asf/zeppelin/blob/ed517a20/zeppelin-web/src/app/tabledata/advanced-transformation.js -- diff --git a/zeppelin-web/src/app/tabledata/advanced-transformation.js b/zeppelin-web/src/app/tabledata/advanced-transformation.js index 8650de5..7420bed 100644 --- a/zeppelin-web/src/app/tabledata/advanced-transformation.js +++ b/zeppelin-web/src/app/tabledata/advanced-transformation.js @@ -12,7 +12,7 @@ * limitations under the License. */ -import Transformation from './transformation' +import Transformation from './transformation'; import { getCurrentChart, getCurrentChartAxis, getCurrentChartParam, @@ -23,46 +23,46 @@ import { removeDuplicatedColumnsInMultiDimensionAxis, applyMaxAxisCount, isInputWidget, isOptionWidget, isCheckboxWidget, isTextareaWidget, parseParameter, getTransformer, -} from './advanced-transformation-util' +} from './advanced-transformation-util'; -const SETTING_TEMPLATE = 'app/tabledata/advanced-transformation-setting.html' +const SETTING_TEMPLATE = 'app/tabledata/advanced-transformation-setting.html'; export default class AdvancedTransformation extends Transformation { constructor(config, spec) { -super(config) +super(config); -this.columns = [] /** [{ name, index, comment }] */ -this.props = {} -this.spec = spec +this.columns = []; /** [{ name, index, comment }] */ +this.props = {}; +this.spec = spec; -initializeConfig(config, spec) +initializeConfig(config, spec); } emitConfigChange(conf) { -conf.chartChanged = false -conf.parameterChanged = false -this.emitConfig(conf) +conf.chartChanged = false; +conf.parameterChanged = false; +this.emitConfig(conf); } emitChartChange(conf) { -conf.chartChanged = true -conf.parameterChanged = false -this.emitConfig(conf) +conf.chartChanged = true; +conf.parameterChanged = false; +this.emitConfig(conf); } emitParameterChange(conf) { -conf.chartChanged = false -conf.parameterChanged = true -this.emitConfig(conf) +conf.chartChanged = false; +conf.parameterChanged = true; +this.emitConfig(conf); } getSetting() { -const self = this /** for closure */ -const configInstance = self.config /** for closure */ +const self = this; /** for closure */ +const configInstance = self.config; /** for closure */ if (self.spec.initialized) { - self.spec.initialized = false - self.emitConfig(configInstance) + self.spec.initialized = false; + self.emitConfig(configInstance); } return { @@ -71,148 +71,174 @@ export default class AdvancedTransformation extends Transformation { config: configInstance, columns: self.columns, resetAxisConfig: () => { - resetAxisConfig(configInstance) - self.emitChartChange(configInstance) + resetAxisConfig(configInstance); + self.emitChartChange(configInstance); }, resetParameterConfig: () => { - resetParameterConfig(configInstance) - self.emitParameterChange(configInstance) + resetParameterConfig(configInstance); + self.emitParameterChange(configInstance); }, toggleColumnPanel: () => { - configInstance.panel.columnPanelOpened = !configInstance.panel.columnPanelOpened - self.emitConfigChange(configInstance) + configInstance.panel.columnPanelOpened = !configInstance.panel.columnPanelOpened; + self.emitConfigChange(configInstance); }, toggleParameterPanel: () => { - configInstance.panel.parameterPanelOpened = !configInstance.panel.parameterPanelOpened - self.emitConfigChange(configInstance) + configInstance.panel.parameterPanelOpened = !configInstance.panel.parameterPanelOpened; + self.emitConfigChange(configInstance); }, getAxisAnnotation: (axisSpec) => { - let anno = `${axisSpec.name}` + let anno = `${axisSpec.name}`; if (axisSpec.valueType) { -anno = `${anno} (${axisSpec.valueType})` +anno = `${anno} (${axisSpec.valueType})`; } - return anno + return anno; }, getAxisTypeAnnotation: (axisSpec) => { - let anno = '' + let anno = ''; - let minAxisCount = axisSpec.minAxisCount - let maxAxisCount = axisSpec.maxAxisCount + let minAxisCount = axisSpec.minAxisCount; + let maxAxisCount = axisSpec.maxAxisCount; if (isSingleDimensionAxis(axisSpec)) { -maxAxisCount = 1 +maxAxisCount = 1; } - let comment = '' - if (minAxisCount) { comment = `min: ${minAxisCount}` } - if (minAxisCount && maxAxisCount) { comment = `${comment}, ` } - if (maxAxi
[04/12] zeppelin git commit: [ZEPPELIN-3245] checkstyle/eslintrc for zeppelin-web (JavaScript)
http://git-wip-us.apache.org/repos/asf/zeppelin/blob/ea2c9447/zeppelin-web/src/app/tabledata/advanced-transformation.js -- diff --git a/zeppelin-web/src/app/tabledata/advanced-transformation.js b/zeppelin-web/src/app/tabledata/advanced-transformation.js index 8650de5..7420bed 100644 --- a/zeppelin-web/src/app/tabledata/advanced-transformation.js +++ b/zeppelin-web/src/app/tabledata/advanced-transformation.js @@ -12,7 +12,7 @@ * limitations under the License. */ -import Transformation from './transformation' +import Transformation from './transformation'; import { getCurrentChart, getCurrentChartAxis, getCurrentChartParam, @@ -23,46 +23,46 @@ import { removeDuplicatedColumnsInMultiDimensionAxis, applyMaxAxisCount, isInputWidget, isOptionWidget, isCheckboxWidget, isTextareaWidget, parseParameter, getTransformer, -} from './advanced-transformation-util' +} from './advanced-transformation-util'; -const SETTING_TEMPLATE = 'app/tabledata/advanced-transformation-setting.html' +const SETTING_TEMPLATE = 'app/tabledata/advanced-transformation-setting.html'; export default class AdvancedTransformation extends Transformation { constructor(config, spec) { -super(config) +super(config); -this.columns = [] /** [{ name, index, comment }] */ -this.props = {} -this.spec = spec +this.columns = []; /** [{ name, index, comment }] */ +this.props = {}; +this.spec = spec; -initializeConfig(config, spec) +initializeConfig(config, spec); } emitConfigChange(conf) { -conf.chartChanged = false -conf.parameterChanged = false -this.emitConfig(conf) +conf.chartChanged = false; +conf.parameterChanged = false; +this.emitConfig(conf); } emitChartChange(conf) { -conf.chartChanged = true -conf.parameterChanged = false -this.emitConfig(conf) +conf.chartChanged = true; +conf.parameterChanged = false; +this.emitConfig(conf); } emitParameterChange(conf) { -conf.chartChanged = false -conf.parameterChanged = true -this.emitConfig(conf) +conf.chartChanged = false; +conf.parameterChanged = true; +this.emitConfig(conf); } getSetting() { -const self = this /** for closure */ -const configInstance = self.config /** for closure */ +const self = this; /** for closure */ +const configInstance = self.config; /** for closure */ if (self.spec.initialized) { - self.spec.initialized = false - self.emitConfig(configInstance) + self.spec.initialized = false; + self.emitConfig(configInstance); } return { @@ -71,148 +71,174 @@ export default class AdvancedTransformation extends Transformation { config: configInstance, columns: self.columns, resetAxisConfig: () => { - resetAxisConfig(configInstance) - self.emitChartChange(configInstance) + resetAxisConfig(configInstance); + self.emitChartChange(configInstance); }, resetParameterConfig: () => { - resetParameterConfig(configInstance) - self.emitParameterChange(configInstance) + resetParameterConfig(configInstance); + self.emitParameterChange(configInstance); }, toggleColumnPanel: () => { - configInstance.panel.columnPanelOpened = !configInstance.panel.columnPanelOpened - self.emitConfigChange(configInstance) + configInstance.panel.columnPanelOpened = !configInstance.panel.columnPanelOpened; + self.emitConfigChange(configInstance); }, toggleParameterPanel: () => { - configInstance.panel.parameterPanelOpened = !configInstance.panel.parameterPanelOpened - self.emitConfigChange(configInstance) + configInstance.panel.parameterPanelOpened = !configInstance.panel.parameterPanelOpened; + self.emitConfigChange(configInstance); }, getAxisAnnotation: (axisSpec) => { - let anno = `${axisSpec.name}` + let anno = `${axisSpec.name}`; if (axisSpec.valueType) { -anno = `${anno} (${axisSpec.valueType})` +anno = `${anno} (${axisSpec.valueType})`; } - return anno + return anno; }, getAxisTypeAnnotation: (axisSpec) => { - let anno = '' + let anno = ''; - let minAxisCount = axisSpec.minAxisCount - let maxAxisCount = axisSpec.maxAxisCount + let minAxisCount = axisSpec.minAxisCount; + let maxAxisCount = axisSpec.maxAxisCount; if (isSingleDimensionAxis(axisSpec)) { -maxAxisCount = 1 +maxAxisCount = 1; } - let comment = '' - if (minAxisCount) { comment = `min: ${minAxisCount}` } - if (minAxisCount && maxAxisCount) { comment = `${comment}, ` } - if (maxAxi