[09/12] zeppelin git commit: [ZEPPELIN-3245] checkstyle/eslintrc for zeppelin-web (JavaScript)

2018-02-22 Thread prabhjyotsingh
http://git-wip-us.apache.org/repos/asf/zeppelin/blob/ed517a20/zeppelin-web/src/app/notebook/notebook.controller.js
--
diff --git a/zeppelin-web/src/app/notebook/notebook.controller.js 
b/zeppelin-web/src/app/notebook/notebook.controller.js
index b02b74e..05ab9fb 100644
--- a/zeppelin-web/src/app/notebook/notebook.controller.js
+++ b/zeppelin-web/src/app/notebook/notebook.controller.js
@@ -12,30 +12,30 @@
  * limitations under the License.
  */
 
-import moment from 'moment'
+import moment from 'moment';
 
-import { isParagraphRunning, } from './paragraph/paragraph.status'
+import {isParagraphRunning} from './paragraph/paragraph.status';
 
-angular.module('zeppelinWebApp').controller('NotebookCtrl', NotebookCtrl)
+angular.module('zeppelinWebApp').controller('NotebookCtrl', NotebookCtrl);
 
-function NotebookCtrl ($scope, $route, $routeParams, $location, $rootScope,
+function NotebookCtrl($scope, $route, $routeParams, $location, $rootScope,
   $http, websocketMsgSrv, baseUrlSrv, $timeout, 
saveAsService,
   ngToast, noteActionService, noteVarShareService, 
TRASH_FOLDER_ID,
   heliumService) {
-  'ngInject'
-
-  ngToast.dismiss()
-
-  $scope.note = null
-  $scope.actionOnFormSelectionChange = true
-  $scope.hideForms = false
-  $scope.disableForms = false
-  $scope.editorToggled = false
-  $scope.tableToggled = false
-  $scope.viewOnly = false
-  $scope.showSetting = false
-  $scope.showRevisionsComparator = false
-  $scope.looknfeelOption = ['default', 'simple', 'report']
+  'ngInject';
+
+  ngToast.dismiss();
+
+  $scope.note = null;
+  $scope.actionOnFormSelectionChange = true;
+  $scope.hideForms = false;
+  $scope.disableForms = false;
+  $scope.editorToggled = false;
+  $scope.tableToggled = false;
+  $scope.viewOnly = false;
+  $scope.showSetting = false;
+  $scope.showRevisionsComparator = false;
+  $scope.looknfeelOption = ['default', 'simple', 'report'];
   $scope.cronOption = [
 {name: 'None', value: undefined},
 {name: '1m', value: '0 0/1 * * * ?'},
@@ -44,28 +44,28 @@ function NotebookCtrl ($scope, $route, $routeParams, 
$location, $rootScope,
 {name: '3h', value: '0 0 0/3 * * ?'},
 {name: '6h', value: '0 0 0/6 * * ?'},
 {name: '12h', value: '0 0 0/12 * * ?'},
-{name: '1d', value: '0 0 0 * * ?'}
-  ]
+{name: '1d', value: '0 0 0 * * ?'},
+  ];
 
   $scope.formatRevisionDate = function(date) {
-return moment.unix(date).format(' Do , h:mm a')
-  }
+return moment.unix(date).format(' Do , h:mm a');
+  };
 
-  $scope.interpreterSettings = []
-  $scope.interpreterBindings = []
-  $scope.isNoteDirty = null
-  $scope.saveTimer = null
-  $scope.paragraphWarningDialog = {}
+  $scope.interpreterSettings = [];
+  $scope.interpreterBindings = [];
+  $scope.isNoteDirty = null;
+  $scope.saveTimer = null;
+  $scope.paragraphWarningDialog = {};
 
-  let connectedOnce = false
-  let isRevisionPath = function (path) {
-let pattern = new 
RegExp('^.*\/notebook\/[a-zA-Z0-9_]*\/revision\/[a-zA-Z0-9_]*')
-return pattern.test(path)
-  }
+  let connectedOnce = false;
+  let isRevisionPath = function(path) {
+let pattern = new 
RegExp('^.*\/notebook\/[a-zA-Z0-9_]*\/revision\/[a-zA-Z0-9_]*');
+return pattern.test(path);
+  };
 
-  $scope.noteRevisions = []
-  $scope.currentRevision = 'Head'
-  $scope.revisionView = isRevisionPath($location.path())
+  $scope.noteRevisions = [];
+  $scope.currentRevision = 'Head';
+  $scope.revisionView = isRevisionPath($location.path());
 
   $scope.search = {
 searchText: '',
@@ -78,48 +78,48 @@ function NotebookCtrl ($scope, $route, $routeParams, 
$location, $rootScope,
 currentOccurrence: 0,
 searchBoxOpened: false,
 searchBoxWidth: 350,
-left: '0px'
-  }
-  let currentSearchParagraph = 0
+left: '0px',
+  };
+  let currentSearchParagraph = 0;
 
-  $scope.$watch('note', function (value) {
-let title
+  $scope.$watch('note', function(value) {
+let title;
 if (value) {
-  title = value.name.substr(value.name.lastIndexOf('/') + 1, 
value.name.length)
-  title += ' - Zeppelin'
+  title = value.name.substr(value.name.lastIndexOf('/') + 1, 
value.name.length);
+  title += ' - Zeppelin';
 } else {
-  title = 'Zeppelin'
+  title = 'Zeppelin';
 }
-$rootScope.pageTitle = title
-  }, true)
+$rootScope.pageTitle = title;
+  }, true);
 
-  $scope.$on('setConnectedStatus', function (event, param) {
+  $scope.$on('setConnectedStatus', function(event, param) {
 if (connectedOnce && param) {
-  initNotebook()
+  initNotebook();
 }
-connectedOnce = true
-  })
+connectedOnce = true;
+  });
 
-  $scope.getCronOptionNameFromValue = function (value) {
+  $scope.getCronOptionNameFromValue = function(value) {
 if (!value) {
-  return ''
+  return '';
 }
 
 for (let o in $scope.cronOption) {
   if 

[09/12] zeppelin git commit: [ZEPPELIN-3245] checkstyle/eslintrc for zeppelin-web (JavaScript)

2018-02-22 Thread prabhjyotsingh
http://git-wip-us.apache.org/repos/asf/zeppelin/blob/ea2c9447/zeppelin-web/src/app/notebook/notebook.controller.js
--
diff --git a/zeppelin-web/src/app/notebook/notebook.controller.js 
b/zeppelin-web/src/app/notebook/notebook.controller.js
index b02b74e..05ab9fb 100644
--- a/zeppelin-web/src/app/notebook/notebook.controller.js
+++ b/zeppelin-web/src/app/notebook/notebook.controller.js
@@ -12,30 +12,30 @@
  * limitations under the License.
  */
 
-import moment from 'moment'
+import moment from 'moment';
 
-import { isParagraphRunning, } from './paragraph/paragraph.status'
+import {isParagraphRunning} from './paragraph/paragraph.status';
 
-angular.module('zeppelinWebApp').controller('NotebookCtrl', NotebookCtrl)
+angular.module('zeppelinWebApp').controller('NotebookCtrl', NotebookCtrl);
 
-function NotebookCtrl ($scope, $route, $routeParams, $location, $rootScope,
+function NotebookCtrl($scope, $route, $routeParams, $location, $rootScope,
   $http, websocketMsgSrv, baseUrlSrv, $timeout, 
saveAsService,
   ngToast, noteActionService, noteVarShareService, 
TRASH_FOLDER_ID,
   heliumService) {
-  'ngInject'
-
-  ngToast.dismiss()
-
-  $scope.note = null
-  $scope.actionOnFormSelectionChange = true
-  $scope.hideForms = false
-  $scope.disableForms = false
-  $scope.editorToggled = false
-  $scope.tableToggled = false
-  $scope.viewOnly = false
-  $scope.showSetting = false
-  $scope.showRevisionsComparator = false
-  $scope.looknfeelOption = ['default', 'simple', 'report']
+  'ngInject';
+
+  ngToast.dismiss();
+
+  $scope.note = null;
+  $scope.actionOnFormSelectionChange = true;
+  $scope.hideForms = false;
+  $scope.disableForms = false;
+  $scope.editorToggled = false;
+  $scope.tableToggled = false;
+  $scope.viewOnly = false;
+  $scope.showSetting = false;
+  $scope.showRevisionsComparator = false;
+  $scope.looknfeelOption = ['default', 'simple', 'report'];
   $scope.cronOption = [
 {name: 'None', value: undefined},
 {name: '1m', value: '0 0/1 * * * ?'},
@@ -44,28 +44,28 @@ function NotebookCtrl ($scope, $route, $routeParams, 
$location, $rootScope,
 {name: '3h', value: '0 0 0/3 * * ?'},
 {name: '6h', value: '0 0 0/6 * * ?'},
 {name: '12h', value: '0 0 0/12 * * ?'},
-{name: '1d', value: '0 0 0 * * ?'}
-  ]
+{name: '1d', value: '0 0 0 * * ?'},
+  ];
 
   $scope.formatRevisionDate = function(date) {
-return moment.unix(date).format(' Do , h:mm a')
-  }
+return moment.unix(date).format(' Do , h:mm a');
+  };
 
-  $scope.interpreterSettings = []
-  $scope.interpreterBindings = []
-  $scope.isNoteDirty = null
-  $scope.saveTimer = null
-  $scope.paragraphWarningDialog = {}
+  $scope.interpreterSettings = [];
+  $scope.interpreterBindings = [];
+  $scope.isNoteDirty = null;
+  $scope.saveTimer = null;
+  $scope.paragraphWarningDialog = {};
 
-  let connectedOnce = false
-  let isRevisionPath = function (path) {
-let pattern = new 
RegExp('^.*\/notebook\/[a-zA-Z0-9_]*\/revision\/[a-zA-Z0-9_]*')
-return pattern.test(path)
-  }
+  let connectedOnce = false;
+  let isRevisionPath = function(path) {
+let pattern = new 
RegExp('^.*\/notebook\/[a-zA-Z0-9_]*\/revision\/[a-zA-Z0-9_]*');
+return pattern.test(path);
+  };
 
-  $scope.noteRevisions = []
-  $scope.currentRevision = 'Head'
-  $scope.revisionView = isRevisionPath($location.path())
+  $scope.noteRevisions = [];
+  $scope.currentRevision = 'Head';
+  $scope.revisionView = isRevisionPath($location.path());
 
   $scope.search = {
 searchText: '',
@@ -78,48 +78,48 @@ function NotebookCtrl ($scope, $route, $routeParams, 
$location, $rootScope,
 currentOccurrence: 0,
 searchBoxOpened: false,
 searchBoxWidth: 350,
-left: '0px'
-  }
-  let currentSearchParagraph = 0
+left: '0px',
+  };
+  let currentSearchParagraph = 0;
 
-  $scope.$watch('note', function (value) {
-let title
+  $scope.$watch('note', function(value) {
+let title;
 if (value) {
-  title = value.name.substr(value.name.lastIndexOf('/') + 1, 
value.name.length)
-  title += ' - Zeppelin'
+  title = value.name.substr(value.name.lastIndexOf('/') + 1, 
value.name.length);
+  title += ' - Zeppelin';
 } else {
-  title = 'Zeppelin'
+  title = 'Zeppelin';
 }
-$rootScope.pageTitle = title
-  }, true)
+$rootScope.pageTitle = title;
+  }, true);
 
-  $scope.$on('setConnectedStatus', function (event, param) {
+  $scope.$on('setConnectedStatus', function(event, param) {
 if (connectedOnce && param) {
-  initNotebook()
+  initNotebook();
 }
-connectedOnce = true
-  })
+connectedOnce = true;
+  });
 
-  $scope.getCronOptionNameFromValue = function (value) {
+  $scope.getCronOptionNameFromValue = function(value) {
 if (!value) {
-  return ''
+  return '';
 }
 
 for (let o in $scope.cronOption) {
   if