This is an automated email from the ASF dual-hosted git repository. kihwal pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/hadoop.git
The following commit(s) were added to refs/heads/trunk by this push: new 928b81a HDFS-15350. Set dfs.client.failover.random.order to true as default. (#2008) 928b81a is described below commit 928b81a5339a3d91e77b268d825973a0d9efc1ab Author: Takanobu Asanuma <tasan...@apache.org> AuthorDate: Tue May 12 23:04:03 2020 +0900 HDFS-15350. Set dfs.client.failover.random.order to true as default. (#2008) --- .../main/java/org/apache/hadoop/hdfs/client/HdfsClientConfigKeys.java | 2 +- hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml | 2 +- .../hadoop/hdfs/server/namenode/ha/TestObserverReadProxyProvider.java | 1 + 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/client/HdfsClientConfigKeys.java b/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/client/HdfsClientConfigKeys.java index efc2766..ab3f6f2 100755 --- a/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/client/HdfsClientConfigKeys.java +++ b/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/client/HdfsClientConfigKeys.java @@ -343,7 +343,7 @@ public interface HdfsClientConfigKeys { PREFIX + "connection.retries.on.timeouts"; int CONNECTION_RETRIES_ON_SOCKET_TIMEOUTS_DEFAULT = 0; String RANDOM_ORDER = PREFIX + "random.order"; - boolean RANDOM_ORDER_DEFAULT = false; + boolean RANDOM_ORDER_DEFAULT = true; String RESOLVE_ADDRESS_NEEDED_KEY = PREFIX + "resolve-needed"; boolean RESOLVE_ADDRESS_NEEDED_DEFAULT = false; String RESOLVE_SERVICE_KEY = PREFIX + "resolver.impl"; diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml b/hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml index 0dc2799..76b4a49 100755 --- a/hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml +++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml @@ -4070,7 +4070,7 @@ <property> <name>dfs.client.failover.random.order</name> - <value>false</value> + <value>true</value> <description> Determines if the failover proxies are picked in random order instead of the configured order. Random order may be enabled for better load balancing diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestObserverReadProxyProvider.java b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestObserverReadProxyProvider.java index e23bb24..630789b 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestObserverReadProxyProvider.java +++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestObserverReadProxyProvider.java @@ -78,6 +78,7 @@ public class TestObserverReadProxyProvider { // transition observer back and forth conf.setTimeDuration( OBSERVER_PROBE_RETRY_PERIOD_KEY, 0, TimeUnit.MILLISECONDS); + conf.setBoolean(HdfsClientConfigKeys.Failover.RANDOM_ORDER, false); } private void setupProxyProvider(int namenodeCount) throws Exception { --------------------------------------------------------------------- To unsubscribe, e-mail: common-commits-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-commits-h...@hadoop.apache.org