HADOOP-13323. Downgrade stack trace on FS load from Warn to debug. Contributed by Steve Loughran.
Project: http://git-wip-us.apache.org/repos/asf/hadoop/repo Commit: http://git-wip-us.apache.org/repos/asf/hadoop/commit/2d46c3f6 Tree: http://git-wip-us.apache.org/repos/asf/hadoop/tree/2d46c3f6 Diff: http://git-wip-us.apache.org/repos/asf/hadoop/diff/2d46c3f6 Branch: refs/heads/HADOOP-13037 Commit: 2d46c3f6b7d55b6a2f124d07fe26d37359615df4 Parents: 2cc841f Author: Chris Nauroth <cnaur...@apache.org> Authored: Thu Oct 6 10:57:01 2016 -0700 Committer: Chris Nauroth <cnaur...@apache.org> Committed: Thu Oct 6 10:57:01 2016 -0700 ---------------------------------------------------------------------- .../src/main/java/org/apache/hadoop/fs/FileSystem.java | 10 +++++++++- .../apache/hadoop/fs/TestFileSystemInitialization.java | 12 ++++-------- 2 files changed, 13 insertions(+), 9 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hadoop/blob/2d46c3f6/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java ---------------------------------------------------------------------- diff --git a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java index c36598f..cc062c4 100644 --- a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java +++ b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java @@ -2858,7 +2858,15 @@ public abstract class FileSystem extends Configured implements Closeable { ClassUtil.findContainingJar(fs.getClass()), e); } } catch (ServiceConfigurationError ee) { - LOG.warn("Cannot load filesystem", ee); + LOG.warn("Cannot load filesystem: " + ee); + Throwable cause = ee.getCause(); + // print all the nested exception messages + while (cause != null) { + LOG.warn(cause.toString()); + cause = cause.getCause(); + } + // and at debug: the full stack + LOG.debug("Stack Trace", ee); } } FILE_SYSTEMS_LOADED = true; http://git-wip-us.apache.org/repos/asf/hadoop/blob/2d46c3f6/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFileSystemInitialization.java ---------------------------------------------------------------------- diff --git a/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFileSystemInitialization.java b/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFileSystemInitialization.java index 18e8b01..4d627a5 100644 --- a/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFileSystemInitialization.java +++ b/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFileSystemInitialization.java @@ -47,16 +47,12 @@ public class TestFileSystemInitialization { @Test public void testMissingLibraries() { - boolean catched = false; try { Configuration conf = new Configuration(); - FileSystem.getFileSystemClass("s3a", conf); - } catch (Exception e) { - catched = true; - } catch (ServiceConfigurationError e) { - // S3A shouldn't find AWS SDK and fail - catched = true; + Class<? extends FileSystem> fs = FileSystem.getFileSystemClass("s3a", + conf); + fail("Expected an exception, got a filesystem: " + fs); + } catch (Exception | ServiceConfigurationError expected) { } - assertTrue(catched); } } --------------------------------------------------------------------- To unsubscribe, e-mail: common-commits-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-commits-h...@hadoop.apache.org